From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 363F9C47097 for ; Thu, 3 Jun 2021 14:49:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14669613D8 for ; Thu, 3 Jun 2021 14:49:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230503AbhFCOvK (ORCPT ); Thu, 3 Jun 2021 10:51:10 -0400 Received: from mx01.ayax.eu ([188.137.98.110]:41138 "EHLO mx01.ayax.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230138AbhFCOvJ (ORCPT ); Thu, 3 Jun 2021 10:51:09 -0400 Received: from [192.168.192.146] (port=48238 helo=nx64de-df6d00) by mx01.ayax.eu with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1looeo-0005Ut-DI; Thu, 03 Jun 2021 16:49:14 +0200 Date: Thu, 3 Jun 2021 16:49:13 +0200 From: Grzegorz Szymaszek To: Ahmad Fatoum Cc: Grzegorz Szymaszek , Alexandre Torgue , Maxime Coquelin , Marcin Sloniewski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH] ARM: dts: stm32: set stm32mp157c-odyssey DCMI pins Message-ID: Mail-Followup-To: Grzegorz Szymaszek , Ahmad Fatoum , Alexandre Torgue , Maxime Coquelin , Marcin Sloniewski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Ahmad, On Thu, Jun 03, 2021 at 04:26:59PM +0200, Ahmad Fatoum wrote: > On 03.06.21 16:23, Grzegorz Szymaszek wrote: > > The Seeed Odyssey-STM32MP157C board has a 20-pin DVP camera output. > > stm32mp15-pinctrl.dtsi contains one pin state definition for the DCMI > > interface, dcmi-0, AKA phandle dcmi_pins_a. This definition is > > incompatible with the pins used on the Odyssey board, where: > > - there are 8 data pins instead of 12, > > - […] > > > > Override the dcmi_pins_a definition (as well as dcmi_sleep_pins_a) in > > the Odyssey device tree. > > Rather define a new pinctrl group (e.g. &dcmi_pins_b) and use that > instead of overriding an existing one. Can I simply use dcmi_pins_b (as the first unused identifier) or is there some way to match specific pin groups to an identifier (b, c, d, and so on)? > Current convention is also to place all STM32MP1 pinctrl nodes into > a central file, not in the individual board device trees. Sure, I will update the patch. Thanks for your comments! -- Grzegorz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD96DC47096 for ; Thu, 3 Jun 2021 14:51:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABBB2613E7 for ; Thu, 3 Jun 2021 14:51:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABBB2613E7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=short.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lgYjeWltVyY4NC0qMiG574aSQZW8tAg7XiHTQ82nti8=; b=b/RPhwku5E17A5 f2kUiH28WrOU871snph+h+fCQGGRQNOj6Wa6vyiUbUwr5mRysiNdEocuLXb4TxvGcHGNV+dc2/83g EEFBtrXk7cZsmcnpMJA9Z4BPyOqAJ5av3tVFbFkrmAseWH2glwZd+BjxVK8S54Gg/Zlu/r5SdKIfG boOHx0Fc0TPZM1+ZwUDvJlYSpM3rjOBpiJU7kJXRat1cTOYQZXbVM60ZdaXlX+rNtyK/SR0pkg5LS NELAKAukBlD+1WMEaDUcUD6H4Rh/KI27yVY6qiCSSS9CoUFJs4jTTUc64qtedqkVUXAJfUBevSHsW 8vIVzyiGGzUNZU4k0vUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1loof3-009FYO-2f; Thu, 03 Jun 2021 14:49:29 +0000 Received: from mx01.ayax.eu ([188.137.98.110]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1looey-009FXX-Jw for linux-arm-kernel@lists.infradead.org; Thu, 03 Jun 2021 14:49:26 +0000 Received: from [192.168.192.146] (port=48238 helo=nx64de-df6d00) by mx01.ayax.eu with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1looeo-0005Ut-DI; Thu, 03 Jun 2021 16:49:14 +0200 Date: Thu, 3 Jun 2021 16:49:13 +0200 From: Grzegorz Szymaszek To: Ahmad Fatoum Cc: Grzegorz Szymaszek , Alexandre Torgue , Maxime Coquelin , Marcin Sloniewski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH] ARM: dts: stm32: set stm32mp157c-odyssey DCMI pins Message-ID: Mail-Followup-To: Grzegorz Szymaszek , Ahmad Fatoum , Alexandre Torgue , Maxime Coquelin , Marcin Sloniewski , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210603_074924_674550_AD29668F X-CRM114-Status: GOOD ( 14.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGVsbG8gQWhtYWQsCgpPbiBUaHUsIEp1biAwMywgMjAyMSBhdCAwNDoyNjo1OVBNICswMjAwLCBB aG1hZCBGYXRvdW0gd3JvdGU6Cj4gT24gMDMuMDYuMjEgMTY6MjMsIEdyemVnb3J6IFN6eW1hc3pl ayB3cm90ZToKPiA+IFRoZSBTZWVlZCBPZHlzc2V5LVNUTTMyTVAxNTdDIGJvYXJkIGhhcyBhIDIw LXBpbiBEVlAgY2FtZXJhIG91dHB1dC4KPiA+IHN0bTMybXAxNS1waW5jdHJsLmR0c2kgY29udGFp bnMgb25lIHBpbiBzdGF0ZSBkZWZpbml0aW9uIGZvciB0aGUgRENNSQo+ID4gaW50ZXJmYWNlLCBk Y21pLTAsIEFLQSBwaGFuZGxlIGRjbWlfcGluc19hLiBUaGlzIGRlZmluaXRpb24gaXMKPiA+IGlu Y29tcGF0aWJsZSB3aXRoIHRoZSBwaW5zIHVzZWQgb24gdGhlIE9keXNzZXkgYm9hcmQsIHdoZXJl Ogo+ID4gLSB0aGVyZSBhcmUgOCBkYXRhIHBpbnMgaW5zdGVhZCBvZiAxMiwKPiA+IC0gW+KApl0K PiA+IAo+ID4gT3ZlcnJpZGUgdGhlIGRjbWlfcGluc19hIGRlZmluaXRpb24gKGFzIHdlbGwgYXMg ZGNtaV9zbGVlcF9waW5zX2EpIGluCj4gPiB0aGUgT2R5c3NleSBkZXZpY2UgdHJlZS4KPiAKPiBS YXRoZXIgZGVmaW5lIGEgbmV3IHBpbmN0cmwgZ3JvdXAgKGUuZy4gJmRjbWlfcGluc19iKSBhbmQg dXNlIHRoYXQKPiBpbnN0ZWFkIG9mIG92ZXJyaWRpbmcgYW4gZXhpc3Rpbmcgb25lLgoKQ2FuIEkg c2ltcGx5IHVzZSBkY21pX3BpbnNfYiAoYXMgdGhlIGZpcnN0IHVudXNlZCBpZGVudGlmaWVyKSBv ciBpcwp0aGVyZSBzb21lIHdheSB0byBtYXRjaCBzcGVjaWZpYyBwaW4gZ3JvdXBzIHRvIGFuIGlk ZW50aWZpZXIgKGIsIGMsIGQsCmFuZCBzbyBvbik/Cgo+IEN1cnJlbnQgY29udmVudGlvbiBpcyBh bHNvIHRvIHBsYWNlIGFsbCBTVE0zMk1QMSBwaW5jdHJsIG5vZGVzIGludG8KPiBhIGNlbnRyYWwg ZmlsZSwgbm90IGluIHRoZSBpbmRpdmlkdWFsIGJvYXJkIGRldmljZSB0cmVlcy4KClN1cmUsIEkg d2lsbCB1cGRhdGUgdGhlIHBhdGNoLgoKVGhhbmtzIGZvciB5b3VyIGNvbW1lbnRzIQoKLS0gCkdy emVnb3J6CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==