From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5321D6F49E for ; Thu, 3 Jun 2021 15:06:41 +0000 (UTC) Date: Thu, 3 Jun 2021 11:06:35 -0400 From: Rodrigo Vivi Message-ID: References: <20210518103344.2264397-1-alan.previn.teres.alexis@intel.com> <20210518103344.2264397-8-alan.previn.teres.alexis@intel.com> <5812d2ab06dcb2837295b719dd97f1042367edc1.camel@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5812d2ab06dcb2837295b719dd97f1042367edc1.camel@intel.com> Subject: Re: [igt-dev] [PATCH i-g-t 07/17] Add MI_SET_APPID instruction definition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Teres Alexis, Alan Previn" Cc: "igt-dev@lists.freedesktop.org" List-ID: On Wed, Jun 02, 2021 at 08:54:06PM -0400, Teres Alexis, Alan Previn wrote: > On Wed, 2021-06-02 at 17:40 -0400, Rodrigo Vivi wrote: > > On Tue, May 18, 2021 at 03:33:34AM -0700, Alan Previn wrote: > > > Add MI_SET_APPID instruction and param definitions > > > > > > Signed-off-by: Alan Previn > > > --- > > > lib/intel_reg.h | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/lib/intel_reg.h b/lib/intel_reg.h > > > index ac1fc6cb..46b5da20 100644 > > > --- a/lib/intel_reg.h > > > +++ b/lib/intel_reg.h > > > @@ -2546,6 +2546,15 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE > > > SOFTWARE. > > > #define CTXT_PALETTE_SAVE_DISABLE (1<<3) > > > #define CTXT_PALETTE_RESTORE_DISABLE (1<<2) > > > > > > +#define MI_SET_APPID (0x0E << 23) > > > +#define APPID_CTXSAVE_INHIBIT (1 << 8) > > > +#define APPID_CTXREST_INHIBIT (1 << 9) > > > +#define DISPLAY_APPTYPE (0) > > > +#define TRANSCODE_APPTYPE (1) > > > +#define APPTYPE(n) (n << 7) > > > +#define APPID(n) (n & 0x7f) > > > > What about sorting the bits? > > > What do u mean by "sorting the bits"? if u mean swap > APP_CTXSAVE_INHIBIT with APP_CTXREST_INHIBIT so we work from MSB down, > then sure, i will fix that. If i have misunderstood, could u paste some > psuedocode? (so i understand correctly) I meant something like this: #define MI_SET_APPID (0x0E << 23) #define APPID_CTXREST_INHIBIT (1 << 9) #define APPID_CTXSAVE_INHIBIT (1 << 8) #define APPTYPE(n) (n << 7) #define DISPLAY_APPTYPE (0) #define TRANSCODE_APPTYPE (1) #define APPID(n) (n & 0x7f) > > > anyway > > Reviewed-by: Rodrigo Vivi but up to you, you have the rv-b already ;) > > > > > > > + > > > + > > > /* Dword 0 */ > > > #define MI_VERTEX_BUFFER (0x17<<23) > > > #define MI_VERTEX_BUFFER_IDX(x) (x<<20) > > > -- > > > 2.25.1 > > > > > > _______________________________________________ > > > igt-dev mailing list > > > igt-dev@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/igt-dev _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev