From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3635BC47098 for ; Thu, 3 Jun 2021 18:12:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1D8276124B for ; Thu, 3 Jun 2021 18:12:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbhFCSO1 (ORCPT ); Thu, 3 Jun 2021 14:14:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:47564 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhFCSO0 (ORCPT ); Thu, 3 Jun 2021 14:14:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D8BCE61358; Thu, 3 Jun 2021 18:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622743960; bh=F/y2/Xdi0ro0EVjX6ng9wtgqyP3SEfu7omS9AaaCxz0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E+zwjwbZ5433owWIuNAL0slq9gnMTykhFnj259Z7uuxekTrLWZ8d0/2oSKIaXjOtm wgnKEzggP+U3Ure3VSX81M+MGaA5bKQbUF72rvUVg1RSTQsUQ6VkhIwT0zKG2Eq2j4 zJv+K6EbCV/Cc50bFTABSoerC5xw3DRTaAG7bkj0= Date: Thu, 3 Jun 2021 20:12:37 +0200 From: Greg KH To: Jaegeuk Kim Cc: Daniel Rosenberg , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Gabriel Krisman Bertazi , kernel-team@android.com, stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs Message-ID: References: <20210603095038.314949-1-drosen@google.com> <20210603095038.314949-3-drosen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 03, 2021 at 10:53:26AM -0700, Jaegeuk Kim wrote: > On 06/03, Greg KH wrote: > > On Thu, Jun 03, 2021 at 08:40:24AM -0700, Jaegeuk Kim wrote: > > > On 06/03, Greg KH wrote: > > > > On Thu, Jun 03, 2021 at 09:50:38AM +0000, Daniel Rosenberg wrote: > > > > > Older kernels don't support encryption with casefolding. This adds > > > > > the sysfs entry encrypted_casefold to show support for those combined > > > > > features. Support for this feature was originally added by > > > > > commit 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") > > > > > > > > > > Fixes: 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") > > > > > Cc: stable@vger.kernel.org # v5.11+ > > > > > Signed-off-by: Daniel Rosenberg > > > > > --- > > > > > fs/f2fs/sysfs.c | 15 +++++++++++++-- > > > > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > > > > > index 09e3f258eb52..6604291a3cdf 100644 > > > > > --- a/fs/f2fs/sysfs.c > > > > > +++ b/fs/f2fs/sysfs.c > > > > > @@ -161,6 +161,9 @@ static ssize_t features_show(struct f2fs_attr *a, > > > > > if (f2fs_sb_has_compression(sbi)) > > > > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > > > len ? ", " : "", "compression"); > > > > > + if (f2fs_sb_has_casefold(sbi) && f2fs_sb_has_encrypt(sbi)) > > > > > + len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > > > + len ? ", " : "", "encrypted_casefold"); > > > > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > > > len ? ", " : "", "pin_file"); > > > > > len += scnprintf(buf + len, PAGE_SIZE - len, "\n"); > > > > > > > > This is a HUGE abuse of sysfs and should not be encouraged and added to. > > > > > > This feature entry was originally added in 2017. Let me try to clean this up > > > after merging this. > > > > Thank you. > > > > > > Please make these "one value per file" and do not keep growing a single > > > > file that has to be parsed otherwise you will break userspace tools. > > > > > > > > And I don't see a Documentation/ABI/ entry for this either :( > > > > > > There is in Documentation/ABI/testing/sysfs-fs-f2fs. > > > > So this new item was documented in the file before the kernel change was > > made? > > Do we need to describe all the strings in this entry? > > 203 What: /sys/fs/f2fs//features > 204 Date: July 2017 > 205 Contact: "Jaegeuk Kim" > 206 Description: Shows all enabled features in current device. Of course! Especially as this is a total violation of normal sysfs files, how else are you going to parse the thing? Why wouldn't you describe the contents? But again, please obsolete this file and make the features all individual files like they should be so that you do not have any parsing problems. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62C3FC47096 for ; Thu, 3 Jun 2021 18:13:02 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D9F061358 for ; Thu, 3 Jun 2021 18:13:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D9F061358 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1lorq0-0000sy-Od; Thu, 03 Jun 2021 18:13:00 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lorps-0000s4-6r for linux-f2fs-devel@lists.sourceforge.net; Thu, 03 Jun 2021 18:12:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1MM/KF2zb9kJTPLvn+kI9WBkJJJ1ZUI5/inenGZho9E=; b=cQllQUyP1zbtCKRJJvopvPMIEZ p0/X6kxG0fOxRviHtMco+EEOTE0tlj/TM0QzBHgmJ6owexNGu1bH9hxKv04RI5HaP+FHYgv10+qN6 wCmF994fg+Q2/CpDH3wGc8k7a883TueodTnPgAxKlcjV6wq/vsWC+cU4iaI6BJ0PwpfI=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1MM/KF2zb9kJTPLvn+kI9WBkJJJ1ZUI5/inenGZho9E=; b=PqjKj90gN/er2k0NfNahU3Wghh kyZXuTvuCtl7MCD2suHHc/SrZ3eBss4YiXBHF50s8U/9Zez+Zk4t9+/cBUC2LxcpkD8DCO/6In9V6 tJvHQaLd2uXO/NQ/F3UxI8AeRKkO6gusu6q6pmbFpqXkeprk92VI4GiaFiOm1uLSTx/g=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1lorpl-0006J7-5q for linux-f2fs-devel@lists.sourceforge.net; Thu, 03 Jun 2021 18:12:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D8BCE61358; Thu, 3 Jun 2021 18:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622743960; bh=F/y2/Xdi0ro0EVjX6ng9wtgqyP3SEfu7omS9AaaCxz0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E+zwjwbZ5433owWIuNAL0slq9gnMTykhFnj259Z7uuxekTrLWZ8d0/2oSKIaXjOtm wgnKEzggP+U3Ure3VSX81M+MGaA5bKQbUF72rvUVg1RSTQsUQ6VkhIwT0zKG2Eq2j4 zJv+K6EbCV/Cc50bFTABSoerC5xw3DRTaAG7bkj0= Date: Thu, 3 Jun 2021 20:12:37 +0200 From: Greg KH To: Jaegeuk Kim Message-ID: References: <20210603095038.314949-1-drosen@google.com> <20210603095038.314949-3-drosen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1lorpl-0006J7-5q Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Rosenberg , kernel-team@android.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, Gabriel Krisman Bertazi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Jun 03, 2021 at 10:53:26AM -0700, Jaegeuk Kim wrote: > On 06/03, Greg KH wrote: > > On Thu, Jun 03, 2021 at 08:40:24AM -0700, Jaegeuk Kim wrote: > > > On 06/03, Greg KH wrote: > > > > On Thu, Jun 03, 2021 at 09:50:38AM +0000, Daniel Rosenberg wrote: > > > > > Older kernels don't support encryption with casefolding. This adds > > > > > the sysfs entry encrypted_casefold to show support for those combined > > > > > features. Support for this feature was originally added by > > > > > commit 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") > > > > > > > > > > Fixes: 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") > > > > > Cc: stable@vger.kernel.org # v5.11+ > > > > > Signed-off-by: Daniel Rosenberg > > > > > --- > > > > > fs/f2fs/sysfs.c | 15 +++++++++++++-- > > > > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > > > > > index 09e3f258eb52..6604291a3cdf 100644 > > > > > --- a/fs/f2fs/sysfs.c > > > > > +++ b/fs/f2fs/sysfs.c > > > > > @@ -161,6 +161,9 @@ static ssize_t features_show(struct f2fs_attr *a, > > > > > if (f2fs_sb_has_compression(sbi)) > > > > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > > > len ? ", " : "", "compression"); > > > > > + if (f2fs_sb_has_casefold(sbi) && f2fs_sb_has_encrypt(sbi)) > > > > > + len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > > > + len ? ", " : "", "encrypted_casefold"); > > > > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > > > > len ? ", " : "", "pin_file"); > > > > > len += scnprintf(buf + len, PAGE_SIZE - len, "\n"); > > > > > > > > This is a HUGE abuse of sysfs and should not be encouraged and added to. > > > > > > This feature entry was originally added in 2017. Let me try to clean this up > > > after merging this. > > > > Thank you. > > > > > > Please make these "one value per file" and do not keep growing a single > > > > file that has to be parsed otherwise you will break userspace tools. > > > > > > > > And I don't see a Documentation/ABI/ entry for this either :( > > > > > > There is in Documentation/ABI/testing/sysfs-fs-f2fs. > > > > So this new item was documented in the file before the kernel change was > > made? > > Do we need to describe all the strings in this entry? > > 203 What: /sys/fs/f2fs//features > 204 Date: July 2017 > 205 Contact: "Jaegeuk Kim" > 206 Description: Shows all enabled features in current device. Of course! Especially as this is a total violation of normal sysfs files, how else are you going to parse the thing? Why wouldn't you describe the contents? But again, please obsolete this file and make the features all individual files like they should be so that you do not have any parsing problems. thanks, greg k-h _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel