All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-block@vger.kernel.org,
	Colin Ian King <colin.king@canonical.com>,
	Pavel Tatashin <pasha.tatashin@soleen.com>
Subject: Re: [PATCH] block: loop: fix deadlock between open and remove
Date: Fri, 4 Jun 2021 16:56:44 +0800	[thread overview]
Message-ID: <YLnqzJkwipxZ1hY8@T590> (raw)
In-Reply-To: <20210604065733.GA11135@lst.de>

On Fri, Jun 04, 2021 at 08:57:33AM +0200, Christoph Hellwig wrote:
> This looks good, but I think we can do simple by just adding add new
> Lo_deleting state.  Completely untested as I'm at the tail end of a vacation
> with a broken laptop:

Indeed, adding one deleting state is simpler to kill the lock of loop_ctl_mutex
in lo_open():

Reviewed-by: Ming Lei <ming.lei@redhat.com>

-- 
Ming


  reply	other threads:[~2021-06-04  8:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04  0:04 [PATCH] block: loop: fix deadlock between open and remove Ming Lei
2021-06-04  6:57 ` Christoph Hellwig
2021-06-04  8:56   ` Ming Lei [this message]
2021-06-05 14:09 Christoph Hellwig
2021-06-05 15:00 ` Colin Ian King
2021-06-07  0:11 ` Ming Lei
2021-06-11 17:51 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLnqzJkwipxZ1hY8@T590 \
    --to=ming.lei@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=colin.king@canonical.com \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    --cc=pasha.tatashin@soleen.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.