From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue
Date: Fri, 4 Jun 2021 08:50:00 -0400 [thread overview]
Message-ID: <YLoheJuGxUjOgHd1@intel.com> (raw)
In-Reply-To: <20210603220754.13920-1-manasi.d.navare@intel.com>
On Thu, Jun 03, 2021 at 03:07:54PM -0700, Manasi Navare wrote:
> Static analysis identified an issue in skl_crtc_allocate_ddb where
> mbus_offset may be used uninitialized.
> This patch fixes it.
I'm sorry, but I really cannot see what this tool is seeing...
I even tried to look to our internal branch to see if it was an issue
there.
But I'm failing to see how it is possible...
>
> Fixes: 835c176cb1c4 ("drm/i915: Introduce MBUS relative dbuf offsets")
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 00f3dead20ad..a385b8b7414f 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4163,7 +4163,7 @@ skl_crtc_allocate_ddb(struct intel_atomic_state *state, struct intel_crtc *crtc)
> struct intel_crtc_state *crtc_state;
> struct skl_ddb_entry ddb_slices;
> enum pipe pipe = crtc->pipe;
> - unsigned int mbus_offset;
> + unsigned int mbus_offset = 0;
> u32 ddb_range_size;
> u32 dbuf_slice_mask;
> u32 start, end;
> --
> 2.19.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-06-04 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 22:07 [Intel-gfx] [PATCH v2] drm/i915: Initialize the mbus_offset to fix static analysis issue Manasi Navare
2021-06-04 1:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-06-04 3:38 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-06-04 12:50 ` Rodrigo Vivi [this message]
2021-06-04 15:22 ` [Intel-gfx] [PATCH v2] " Mika Kuoppala
2021-06-04 15:37 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLoheJuGxUjOgHd1@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.