From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1986C07E94 for ; Fri, 4 Jun 2021 14:09:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82C0361405 for ; Fri, 4 Jun 2021 14:09:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82C0361405 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F264E6E043; Fri, 4 Jun 2021 14:09:14 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 080036E043; Fri, 4 Jun 2021 14:09:12 +0000 (UTC) IronPort-SDR: DnpoU4K6YyZZ+glynSZta2OvG7io/Csn+yY5d6k9aKfDJQu6Dg1NX5dujzH4jE087bSTa0PZNj 8zJxMr/m9sUQ== X-IronPort-AV: E=McAfee;i="6200,9189,10005"; a="289925108" X-IronPort-AV: E=Sophos;i="5.83,248,1616482800"; d="scan'208";a="289925108" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2021 07:08:58 -0700 IronPort-SDR: KPXmf99+P6VoEJe2JhtYMp2eVCwwZ/bjSp6mBK0IyRlhdrdJP737/S8WvsEG+Xv+OfM3V1uOib RrtqHSZA0+TQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,248,1616482800"; d="scan'208";a="412379056" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga007.fm.intel.com with SMTP; 04 Jun 2021 07:08:55 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 04 Jun 2021 17:08:54 +0300 Date: Fri, 4 Jun 2021 17:08:54 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Emil Velikov Subject: Re: [PATCH] drm/i915: only disable default vga device Message-ID: References: <20210516171432.1734268-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , kernel@collabora.com, ML dri-devel , Rodrigo Vivi Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 04, 2021 at 02:47:16PM +0100, Emil Velikov wrote: > On Wed, 26 May 2021 at 17:21, Emil Velikov wrote: > > > > Hi Ville, > > > > On Tue, 18 May 2021 at 12:17, Ville Syrjälä > > wrote: > > > > > > On Tue, May 18, 2021 at 12:09:56PM +0100, Emil Velikov wrote: > > > > Hi Ville, > > > > > > > > On Mon, 17 May 2021 at 18:24, Ville Syrjälä > > > > wrote: > > > > > > > > > > On Sun, May 16, 2021 at 06:14:32PM +0100, Emil Velikov wrote: > > > > > > From: Vivek Das Mohapatra > > > > > > > > > > > > This patch is to do with seamless handover, eg when the sequence is > > > > > > bootloader → plymouth → desktop. > > > > > > > > > > > > It switches the vga arbiter from the "other" GPU to the default one > > > > > > (intel in this case), so the driver can issue some io(). > > > > > > > > > > I don't understand what this commit message is trying to say. > > > > > > > > > Bunch of context is lost due to the patch age, so I'm not 100% sure of > > > > the actual hardware setup where this occurs. > > > > Does the following make sense? > > > > > > > > Currently on dual GPU systems, we do not get seamless handover as the > > > > output flickers during the transition bootloader -> plymouth -> > > > > desktop. > > > > This happens as a result of switching (via the VGA arbiter) from the > > > > "other" GPU back to the default i915 one and issuing io() commands. > > > > > > Hmm. Does this work? > > > > > > --- a/drivers/gpu/drm/i915/display/intel_vga.c > > > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > > > @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) > > > i915_reg_t vga_reg = intel_vga_cntrl_reg(dev_priv); > > > u8 sr1; > > > > > > + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) > > > + return; > > > + > > > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > > > vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > > > outb(SR01, VGA_SR_INDEX); > > > > > Was able to replicate the issue somewhat and the above does help quite a lot. > > Feel free to add my: > > Reviewed-by: Emil Velikov > > Tested-by: Emil Velikov > > > Humble poke. > > Cannot see this patch in the drm-misc or drm-intel trees. Is there > anything I do to help move it forward? Can you just respin the patch with this? -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FADAC07E94 for ; Fri, 4 Jun 2021 14:09:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 219D061405 for ; Fri, 4 Jun 2021 14:09:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 219D061405 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A5986EBFF; Fri, 4 Jun 2021 14:09:15 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 080036E043; Fri, 4 Jun 2021 14:09:12 +0000 (UTC) IronPort-SDR: DnpoU4K6YyZZ+glynSZta2OvG7io/Csn+yY5d6k9aKfDJQu6Dg1NX5dujzH4jE087bSTa0PZNj 8zJxMr/m9sUQ== X-IronPort-AV: E=McAfee;i="6200,9189,10005"; a="289925108" X-IronPort-AV: E=Sophos;i="5.83,248,1616482800"; d="scan'208";a="289925108" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jun 2021 07:08:58 -0700 IronPort-SDR: KPXmf99+P6VoEJe2JhtYMp2eVCwwZ/bjSp6mBK0IyRlhdrdJP737/S8WvsEG+Xv+OfM3V1uOib RrtqHSZA0+TQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,248,1616482800"; d="scan'208";a="412379056" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga007.fm.intel.com with SMTP; 04 Jun 2021 07:08:55 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 04 Jun 2021 17:08:54 +0300 Date: Fri, 4 Jun 2021 17:08:54 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Emil Velikov Message-ID: References: <20210516171432.1734268-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH] drm/i915: only disable default vga device X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel Graphics Development , kernel@collabora.com, ML dri-devel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gRnJpLCBKdW4gMDQsIDIwMjEgYXQgMDI6NDc6MTZQTSArMDEwMCwgRW1pbCBWZWxpa292IHdy b3RlOgo+IE9uIFdlZCwgMjYgTWF5IDIwMjEgYXQgMTc6MjEsIEVtaWwgVmVsaWtvdiA8ZW1pbC5s LnZlbGlrb3ZAZ21haWwuY29tPiB3cm90ZToKPiA+Cj4gPiBIaSBWaWxsZSwKPiA+Cj4gPiBPbiBU dWUsIDE4IE1heSAyMDIxIGF0IDEyOjE3LCBWaWxsZSBTeXJqw6Rsw6QKPiA+IDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiA+Cj4gPiA+IE9uIFR1ZSwgTWF5IDE4LCAy MDIxIGF0IDEyOjA5OjU2UE0gKzAxMDAsIEVtaWwgVmVsaWtvdiB3cm90ZToKPiA+ID4gPiBIaSBW aWxsZSwKPiA+ID4gPgo+ID4gPiA+IE9uIE1vbiwgMTcgTWF5IDIwMjEgYXQgMTg6MjQsIFZpbGxl IFN5cmrDpGzDpAo+ID4gPiA+IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6 Cj4gPiA+ID4gPgo+ID4gPiA+ID4gT24gU3VuLCBNYXkgMTYsIDIwMjEgYXQgMDY6MTQ6MzJQTSAr MDEwMCwgRW1pbCBWZWxpa292IHdyb3RlOgo+ID4gPiA+ID4gPiBGcm9tOiBWaXZlayBEYXMgTW9o YXBhdHJhIDx2aXZla0Bjb2xsYWJvcmEuY29tPgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBUaGlz IHBhdGNoIGlzIHRvIGRvIHdpdGggc2VhbWxlc3MgaGFuZG92ZXIsIGVnIHdoZW4gdGhlIHNlcXVl bmNlIGlzCj4gPiA+ID4gPiA+IGJvb3Rsb2FkZXIg4oaSIHBseW1vdXRoIOKGkiBkZXNrdG9wLgo+ ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBJdCBzd2l0Y2hlcyB0aGUgdmdhIGFyYml0ZXIgZnJvbSB0 aGUgIm90aGVyIiBHUFUgdG8gdGhlIGRlZmF1bHQgb25lCj4gPiA+ID4gPiA+IChpbnRlbCBpbiB0 aGlzIGNhc2UpLCBzbyB0aGUgZHJpdmVyIGNhbiBpc3N1ZSBzb21lIGlvKCkuCj4gPiA+ID4gPgo+ ID4gPiA+ID4gSSBkb24ndCB1bmRlcnN0YW5kIHdoYXQgdGhpcyBjb21taXQgbWVzc2FnZSBpcyB0 cnlpbmcgdG8gc2F5Lgo+ID4gPiA+ID4KPiA+ID4gPiBCdW5jaCBvZiBjb250ZXh0IGlzIGxvc3Qg ZHVlIHRvIHRoZSBwYXRjaCBhZ2UsIHNvIEknbSBub3QgMTAwJSBzdXJlIG9mCj4gPiA+ID4gdGhl IGFjdHVhbCBoYXJkd2FyZSBzZXR1cCB3aGVyZSB0aGlzIG9jY3Vycy4KPiA+ID4gPiBEb2VzIHRo ZSBmb2xsb3dpbmcgbWFrZSBzZW5zZT8KPiA+ID4gPgo+ID4gPiA+IEN1cnJlbnRseSBvbiBkdWFs IEdQVSBzeXN0ZW1zLCB3ZSBkbyBub3QgZ2V0IHNlYW1sZXNzIGhhbmRvdmVyIGFzIHRoZQo+ID4g PiA+IG91dHB1dCBmbGlja2VycyBkdXJpbmcgdGhlIHRyYW5zaXRpb24gYm9vdGxvYWRlciAtPiBw bHltb3V0aCAtPgo+ID4gPiA+IGRlc2t0b3AuCj4gPiA+ID4gVGhpcyBoYXBwZW5zIGFzIGEgcmVz dWx0IG9mIHN3aXRjaGluZyAodmlhIHRoZSBWR0EgYXJiaXRlcikgZnJvbSB0aGUKPiA+ID4gPiAi b3RoZXIiIEdQVSBiYWNrIHRvIHRoZSBkZWZhdWx0IGk5MTUgb25lIGFuZCBpc3N1aW5nIGlvKCkg Y29tbWFuZHMuCj4gPiA+Cj4gPiA+IEhtbS4gRG9lcyB0aGlzIHdvcms/Cj4gPiA+Cj4gPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfdmdhLmMKPiA+ID4gKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF92Z2EuYwo+ID4gPiBAQCAtMjksNiAr MjksOSBAQCB2b2lkIGludGVsX3ZnYV9kaXNhYmxlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk ZXZfcHJpdikKPiA+ID4gICAgICAgICBpOTE1X3JlZ190IHZnYV9yZWcgPSBpbnRlbF92Z2FfY250 cmxfcmVnKGRldl9wcml2KTsKPiA+ID4gICAgICAgICB1OCBzcjE7Cj4gPiA+Cj4gPiA+ICsgICAg ICAgaWYgKGludGVsX2RlX3JlYWQoZGV2X3ByaXYsIHZnYV9yZWcpICYgVkdBX0RJU1BfRElTQUJM RSkKPiA+ID4gKyAgICAgICAgICAgICAgIHJldHVybjsKPiA+ID4gKwo+ID4gPiAgICAgICAgIC8q IFdhRW5hYmxlVkdBQWNjZXNzVGhyb3VnaElPUG9ydDpjdGcsZWxrLGlsayxzbmIsaXZiLHZsdixo c3cgKi8KPiA+ID4gICAgICAgICB2Z2FfZ2V0X3VuaW50ZXJydXB0aWJsZShwZGV2LCBWR0FfUlNS Q19MRUdBQ1lfSU8pOwo+ID4gPiAgICAgICAgIG91dGIoU1IwMSwgVkdBX1NSX0lOREVYKTsKPiA+ ID4KPiA+IFdhcyBhYmxlIHRvIHJlcGxpY2F0ZSB0aGUgaXNzdWUgc29tZXdoYXQgYW5kIHRoZSBh Ym92ZSBkb2VzIGhlbHAgcXVpdGUgYSBsb3QuCj4gPiBGZWVsIGZyZWUgdG8gYWRkIG15Ogo+ID4g UmV2aWV3ZWQtYnk6IEVtaWwgVmVsaWtvdiA8ZW1pbC52ZWxpa292QGNvbGxhYm9yYS5jb20+Cj4g PiBUZXN0ZWQtYnk6IEVtaWwgVmVsaWtvdiA8ZW1pbC52ZWxpa292QGNvbGxhYm9yYS5jb20+Cj4g Pgo+IEh1bWJsZSBwb2tlLgo+IAo+IENhbm5vdCBzZWUgdGhpcyBwYXRjaCBpbiB0aGUgZHJtLW1p c2Mgb3IgZHJtLWludGVsIHRyZWVzLiBJcyB0aGVyZQo+IGFueXRoaW5nIEkgZG8gdG8gaGVscCBt b3ZlIGl0IGZvcndhcmQ/CgpDYW4geW91IGp1c3QgcmVzcGluIHRoZSBwYXRjaCB3aXRoIHRoaXM/ CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=