All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Eric Biggers <ebiggers@kernel.org>,
	Daniel Rosenberg <drosen@google.com>, Chao Yu <chao@kernel.org>,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Gabriel Krisman Bertazi <krisman@collabora.com>,
	kernel-team@android.com, stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs
Date: Fri, 4 Jun 2021 14:58:45 -0400	[thread overview]
Message-ID: <YLp35XvlTuuZrcYf@mit.edu> (raw)
In-Reply-To: <YLm8aOs6Sc/CLaAv@google.com>

On Thu, Jun 03, 2021 at 10:38:48PM -0700, Jaegeuk Kim wrote:
 > > Yes, but in the on-disk case, encrypted_casefold is redundant because it simply
> > means encrypt && casefold.  There is no encrypted_casefold flag on-disk.
> 
> I prefer to keep encrypted_casefold likewise kernel feature, which is more
> intuitive to users.

At least for ext4, there are kernel vesions which support encryption
and casefold *separetely*, but which do not support the file systems
that have encryption and casefold enabled simultaneously.  This is why
I had added /sys/fs/ext4/features/encrypted_casefold.  It was
originally not to indicate whether the on-disk file system supported
those features, but to indicate that the kernel in question supported
both features being enabled simultaneously.

					- Ted

WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Ts'o" <tytso@mit.edu>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Daniel Rosenberg <drosen@google.com>,
	kernel-team@android.com, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net,
	Eric Biggers <ebiggers@kernel.org>,
	linux-fsdevel@vger.kernel.org,
	Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs
Date: Fri, 4 Jun 2021 14:58:45 -0400	[thread overview]
Message-ID: <YLp35XvlTuuZrcYf@mit.edu> (raw)
In-Reply-To: <YLm8aOs6Sc/CLaAv@google.com>

On Thu, Jun 03, 2021 at 10:38:48PM -0700, Jaegeuk Kim wrote:
 > > Yes, but in the on-disk case, encrypted_casefold is redundant because it simply
> > means encrypt && casefold.  There is no encrypted_casefold flag on-disk.
> 
> I prefer to keep encrypted_casefold likewise kernel feature, which is more
> intuitive to users.

At least for ext4, there are kernel vesions which support encryption
and casefold *separetely*, but which do not support the file systems
that have encryption and casefold enabled simultaneously.  This is why
I had added /sys/fs/ext4/features/encrypted_casefold.  It was
originally not to indicate whether the on-disk file system supported
those features, but to indicate that the kernel in question supported
both features being enabled simultaneously.

					- Ted


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  parent reply	other threads:[~2021-06-04 18:59 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-03  9:50 [PATCH v2 0/2] Fix up casefolding sysfs entries for F2FS Daniel Rosenberg
2021-06-03  9:50 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2021-06-03  9:50 ` [PATCH v2 1/2] f2fs: Show casefolding support only when supported Daniel Rosenberg
2021-06-03  9:50   ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2021-06-03 18:20   ` Eric Biggers
2021-06-03 18:20     ` [f2fs-dev] " Eric Biggers
2021-06-04 23:46   ` Chao Yu
2021-06-04 23:46     ` [f2fs-dev] " Chao Yu
2021-06-03  9:50 ` [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs Daniel Rosenberg
2021-06-03  9:50   ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2021-06-03 10:04   ` Greg KH
2021-06-03 10:04     ` [f2fs-dev] " Greg KH
2021-06-03 15:40     ` Jaegeuk Kim
2021-06-03 15:40       ` [f2fs-dev] " Jaegeuk Kim
2021-06-03 17:26       ` Greg KH
2021-06-03 17:26         ` [f2fs-dev] " Greg KH
2021-06-03 17:53         ` Jaegeuk Kim
2021-06-03 17:53           ` [f2fs-dev] " Jaegeuk Kim
2021-06-03 18:12           ` Greg KH
2021-06-03 18:12             ` [f2fs-dev] " Greg KH
2021-06-03 19:20             ` Jaegeuk Kim
2021-06-03 19:20               ` [f2fs-dev] " Jaegeuk Kim
2021-06-03 20:54             ` David Laight
2021-06-03 20:54               ` [f2fs-dev] " David Laight
2021-06-03 18:26   ` Eric Biggers
2021-06-03 18:26     ` [f2fs-dev] " Eric Biggers
2021-06-03 23:21   ` Eric Biggers
2021-06-03 23:21     ` [f2fs-dev] " Eric Biggers
2021-06-04  4:45     ` Jaegeuk Kim
2021-06-04  4:45       ` [f2fs-dev] " Jaegeuk Kim
2021-06-04  5:01       ` Eric Biggers
2021-06-04  5:01         ` [f2fs-dev] " Eric Biggers
2021-06-04  5:38         ` Jaegeuk Kim
2021-06-04  5:38           ` [f2fs-dev] " Jaegeuk Kim
2021-06-04  5:54           ` Daniel Rosenberg
2021-06-04  5:54             ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2021-06-04 18:58           ` Theodore Ts'o [this message]
2021-06-04 18:58             ` Theodore Ts'o
2021-06-05  0:11           ` Chao Yu
2021-06-05  0:11             ` [f2fs-dev] " Chao Yu
2021-06-05  0:15             ` Jaegeuk Kim
2021-06-05  0:15               ` [f2fs-dev] " Jaegeuk Kim
2021-06-04  8:27       ` David Laight
2021-06-04  8:27         ` [f2fs-dev] " David Laight
2021-06-04  8:33         ` Greg KH
2021-06-04  8:33           ` [f2fs-dev] " Greg KH
2021-06-04 23:46   ` Chao Yu
2021-06-04 23:46     ` [f2fs-dev] " Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLp35XvlTuuZrcYf@mit.edu \
    --to=tytso@mit.edu \
    --cc=chao@kernel.org \
    --cc=drosen@google.com \
    --cc=ebiggers@kernel.org \
    --cc=jaegeuk@kernel.org \
    --cc=kernel-team@android.com \
    --cc=krisman@collabora.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.