From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D71BC07E94 for ; Fri, 4 Jun 2021 15:22:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E150F61405 for ; Fri, 4 Jun 2021 15:22:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbhFDPX5 (ORCPT ); Fri, 4 Jun 2021 11:23:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229675AbhFDPX5 (ORCPT ); Fri, 4 Jun 2021 11:23:57 -0400 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2DEAC061766 for ; Fri, 4 Jun 2021 08:22:10 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id 983AC3A9; Fri, 4 Jun 2021 17:22:08 +0200 (CEST) Date: Fri, 4 Jun 2021 17:22:07 +0200 From: Joerg Roedel To: Jean-Philippe Brucker Cc: kernel test robot , rjw@rjwysocki.net, lenb@kernel.org, mst@redhat.com, kbuild-all@lists.01.org, clang-built-linux@googlegroups.com, will@kernel.org, catalin.marinas@arm.com, baolu.lu@linux.intel.com, dwmw2@infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH v3 2/6] ACPI: Move IOMMU setup code out of IORT Message-ID: References: <20210602154444.1077006-3-jean-philippe@linaro.org> <202106030417.97asL7dA-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Thu, Jun 03, 2021 at 09:26:39AM +0200, Jean-Philippe Brucker wrote: > These are only defined when CONFIG_IOMMU_API is set. IORT uses them inside > an #ifdef, I can do the same. Maybe moving these two functions to a new > drivers/acpi/iommu.c would be nicer, though. Not sure what the ACPI maintainers and reviewers prefer, but I would just #ifdef the functions and provide stubs in the #else path if necessary. Regards, Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98387C07E94 for ; Fri, 4 Jun 2021 15:22:22 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35A6D61405 for ; Fri, 4 Jun 2021 15:22:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35A6D61405 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=8bytes.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 03B7D607B9; Fri, 4 Jun 2021 15:22:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2jQJiVwIeQo7; Fri, 4 Jun 2021 15:22:17 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTP id B082A6079F; Fri, 4 Jun 2021 15:22:16 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 87F72C000D; Fri, 4 Jun 2021 15:22:16 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 3AE0CC000D for ; Fri, 4 Jun 2021 15:22:14 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2874F415C0 for ; Fri, 4 Jun 2021 15:22:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PuBqWAF0tInh for ; Fri, 4 Jun 2021 15:22:10 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 Received: from theia.8bytes.org (8bytes.org [IPv6:2a01:238:4383:600:38bc:a715:4b6d:a889]) by smtp4.osuosl.org (Postfix) with ESMTPS id 727744068A for ; Fri, 4 Jun 2021 15:22:10 +0000 (UTC) Received: by theia.8bytes.org (Postfix, from userid 1000) id 983AC3A9; Fri, 4 Jun 2021 17:22:08 +0200 (CEST) Date: Fri, 4 Jun 2021 17:22:07 +0200 From: Joerg Roedel To: Jean-Philippe Brucker Subject: Re: [PATCH v3 2/6] ACPI: Move IOMMU setup code out of IORT Message-ID: References: <20210602154444.1077006-3-jean-philippe@linaro.org> <202106030417.97asL7dA-lkp@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: kbuild-all@lists.01.org, kernel test robot , mst@redhat.com, catalin.marinas@arm.com, rjw@rjwysocki.net, linux-acpi@vger.kernel.org, clang-built-linux@googlegroups.com, iommu@lists.linux-foundation.org, will@kernel.org, dwmw2@infradead.org, lenb@kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Jun 03, 2021 at 09:26:39AM +0200, Jean-Philippe Brucker wrote: > These are only defined when CONFIG_IOMMU_API is set. IORT uses them inside > an #ifdef, I can do the same. Maybe moving these two functions to a new > drivers/acpi/iommu.c would be nicer, though. Not sure what the ACPI maintainers and reviewers prefer, but I would just #ifdef the functions and provide stubs in the #else path if necessary. Regards, Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============6952860940949861227==" MIME-Version: 1.0 From: Joerg Roedel To: kbuild-all@lists.01.org Subject: Re: [PATCH v3 2/6] ACPI: Move IOMMU setup code out of IORT Date: Fri, 04 Jun 2021 17:22:07 +0200 Message-ID: In-Reply-To: List-Id: --===============6952860940949861227== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Jun 03, 2021 at 09:26:39AM +0200, Jean-Philippe Brucker wrote: > These are only defined when CONFIG_IOMMU_API is set. IORT uses them inside > an #ifdef, I can do the same. Maybe moving these two functions to a new > drivers/acpi/iommu.c would be nicer, though. Not sure what the ACPI maintainers and reviewers prefer, but I would just #ifdef the functions and provide stubs in the #else path if necessary. Regards, Joerg --===============6952860940949861227==--