From: Patrick Wildt <patrick@blueri.se>
To: Anand Moon <linux.amoon@gmail.com>
Cc: u-boot@lists.denx.de, Neil Armstrong <narmstrong@baylibre.com>,
Kever Yang <kever.yang@rock-chips.com>
Subject: Re: [PATCHv3 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error
Date: Fri, 4 Jun 2021 17:46:42 +0200 [thread overview]
Message-ID: <YLpK4tf2tXirxbjW@mini.fritz.box> (raw)
In-Reply-To: <20210604045607.1003-1-linux.amoon@gmail.com>
Am Fri, Jun 04, 2021 at 04:56:05AM +0000 schrieb Anand Moon:
> Use the generic error number instead of specific error number.
> Changes fix the below error.
>
> drivers/pci/pcie_dw_rockchip.c: In function 'rk_pcie_read':
> drivers/pci/pcie_dw_rockchip.c:70:10: error: 'PCIBIOS_UNSUPPORTED'
> undeclared (first use in this function)
> 70 | return PCIBIOS_UNSUPPORTED;
> | ^~~~~~~~~~~~~~~~~~~
> drivers/pci/pcie_dw_rockchip.c: In function 'rk_pcie_write':
> drivers/pci/pcie_dw_rockchip.c:90:10: error: 'PCIBIOS_UNSUPPORTED'
> undeclared (first use in this function)
> 90 | return PCIBIOS_UNSUPPORTED;
> | ^~~~~~~~~~~~~~~~~~~
>
> Cc: Patrick Wildt <patrick@blueri.se>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> v1: Drop the PCI ERROR MACRO,
> v2: added the Neil review tag.
> ---
> ---
> drivers/pci/pcie_dw_rockchip.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c
> index bc22af4230..3ac2434b69 100644
> --- a/drivers/pci/pcie_dw_rockchip.c
> +++ b/drivers/pci/pcie_dw_rockchip.c
> @@ -67,7 +67,7 @@ static int rk_pcie_read(void __iomem *addr, int size, u32 *val)
> {
> if ((uintptr_t)addr & (size - 1)) {
> *val = 0;
> - return PCIBIOS_UNSUPPORTED;
> + return -EOPNOTSUPP;
> }
>
> if (size == 4) {
> @@ -87,7 +87,7 @@ static int rk_pcie_read(void __iomem *addr, int size, u32 *val)
> static int rk_pcie_write(void __iomem *addr, int size, u32 val)
> {
> if ((uintptr_t)addr & (size - 1))
> - return PCIBIOS_UNSUPPORTED;
> + return -EOPNOTSUPP;
>
> if (size == 4)
> writel(val, addr);
> --
> 2.31.1
>
Reviewed-by: Patrick Wildt <patrick@blueri.se>
next prev parent reply other threads:[~2021-06-04 15:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-04 4:56 [PATCHv3 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error Anand Moon
2021-06-04 4:56 ` [PATCHv3 2/3] pci: pcie_dw_rockchip: Drop the unused variable warning Anand Moon
2021-06-04 15:45 ` Patrick Wildt
2021-06-08 7:05 ` Kever Yang
2021-06-04 4:56 ` [PATCHv3 3/3] pci: pcie_dw_rockchip: Replace msleep occurences by udelay Anand Moon
2021-06-04 15:44 ` Patrick Wildt
2021-06-05 11:56 ` Anand Moon
2021-06-08 7:06 ` Kever Yang
2021-06-04 15:46 ` Patrick Wildt [this message]
2021-06-08 7:05 ` [PATCHv3 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error Kever Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLpK4tf2tXirxbjW@mini.fritz.box \
--to=patrick@blueri.se \
--cc=kever.yang@rock-chips.com \
--cc=linux.amoon@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.