From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86893C47082 for ; Sat, 5 Jun 2021 11:06:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64BEE613B4 for ; Sat, 5 Jun 2021 11:06:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230131AbhFELIA (ORCPT ); Sat, 5 Jun 2021 07:08:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229929AbhFELH7 (ORCPT ); Sat, 5 Jun 2021 07:07:59 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 775FFC061766 for ; Sat, 5 Jun 2021 04:06:11 -0700 (PDT) Received: from zn.tnic (p4fed32f0.dip0.t-ipconnect.de [79.237.50.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 10AC61EC01A2; Sat, 5 Jun 2021 13:06:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1622891170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=JZ9YF6+OF3bCVwHOtW45Mhrnr9jvP3HjzwjBTkIhoOI=; b=IQ0pCBU62C2BSj2MTIYWps6/806yC5yXG7Q+x7gCNFkUK+z8JJxA9UfjNMuMqnnrkHAkn3 Ps4cIPw1fTHl3+rqnfNU15Xf83oIT3xthx+JBWqFIntxQChhh4W/7yP4FeRjmClPfge0Yi xO4qKCZWJpu6HToqasL2VgKMMW6BRpA= Date: Sat, 5 Jun 2021 13:03:53 +0200 From: Borislav Petkov To: Tom Lendacky Cc: Kuppuswamy Sathyanarayanan , Peter Zijlstra , Andy Lutomirski , Dave Hansen , Tony Luck , Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Dan Williams , Raj Ashok , Sean Christopherson , linux-kernel@vger.kernel.org Subject: Re: [RFC v2-fix-v2 1/1] x86: Introduce generic protected guest abstractionn Message-ID: References: <20210527042356.3983284-2-sathyanarayanan.kuppuswamy@linux.intel.com> <20210601211417.2177598-1-sathyanarayanan.kuppuswamy@linux.intel.com> <1c8938fb-c9e9-af51-5224-70fc869eedea@amd.com> <12bba26f-5605-fabf-53ea-f0bc1bb9db44@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <12bba26f-5605-fabf-53ea-f0bc1bb9db44@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 04, 2021 at 06:31:03PM -0500, Tom Lendacky wrote: > If Intel has XYZ but AMD does not, you don't want to WARN, just return false. Aha, *now*, I see what you mean. Ok, so the reason why I added the WARN is to sanity-check whether we're handling all possible VM_* or PROT_GUEST_* flags properly and whether we're missing some. As a debugging help. It'll get removed before applying I guess. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette