From: Seth Forshee <seth.forshee@canonical.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] selftests/tls: don't change cipher type in bidirectional test
Date: Fri, 18 Jun 2021 17:04:16 -0500 [thread overview]
Message-ID: <YM0YYNrkihtExlTR@ubuntu-x1> (raw)
In-Reply-To: <20210618144149.35192fcc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Fri, Jun 18, 2021 at 02:41:49PM -0700, Jakub Kicinski wrote:
> On Fri, 18 Jun 2021 15:45:32 -0500 Seth Forshee wrote:
> > The bidirectional test attempts to change the cipher to
> > TLS_CIPHER_AES_GCM_128. The test fixture setup will have already set
> > the cipher to be tested, and if it was different than the one set by
> > the bidir test setsockopt() will fail on account of having different
> > ciphers for rx and tx, causing the test to fail.
>
> It's setting it up in the opposite direction, TLS is uni-directional.
> I've posted this earlier:
Ah, so it is, I missed that detail.
> https://patchwork.kernel.org/project/netdevbpf/patch/20210618202504.1435179-2-kuba@kernel.org/
>
> Sorry for not CCing you.
No worries.
Thanks,
Seth
prev parent reply other threads:[~2021-06-18 22:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 20:45 [PATCH] selftests/tls: don't change cipher type in bidirectional test Seth Forshee
2021-06-18 21:41 ` Jakub Kicinski
2021-06-18 22:04 ` Seth Forshee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YM0YYNrkihtExlTR@ubuntu-x1 \
--to=seth.forshee@canonical.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.