From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Zhenzhong Duan <zhenzhong.duan@intel.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] vl: Fix an assert failure in error path
Date: Wed, 9 Jun 2021 13:15:32 +0100 [thread overview]
Message-ID: <YMCw5E2havaaC+UI@redhat.com> (raw)
In-Reply-To: <87fsxrnss4.fsf@dusky.pond.sub.org>
On Wed, Jun 09, 2021 at 02:09:47PM +0200, Markus Armbruster wrote:
> Paolo Bonzini <pbonzini@redhat.com> writes:
>
> > On 10/06/21 10:47, Zhenzhong Duan wrote:
> >> Based on the description of error_setg(), the local variable err in
> >> qemu_maybe_daemonize() should be initialized to NULL.
> >> Without fix, the uninitialized *errp triggers assert failure which
> >> doesn't show much valuable information.
> >> Before the fix:
> >> qemu-system-x86_64: ../util/error.c:59: error_setv: Assertion `*errp == NULL' failed.
> >> After fix:
> >> qemu-system-x86_64: cannot create PID file: Cannot open pid file: Permission denied
> >> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> >> ---
> >> softmmu/vl.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> diff --git a/softmmu/vl.c b/softmmu/vl.c
> >> index 326c1e9080..feb4d201f3 100644
> >> --- a/softmmu/vl.c
> >> +++ b/softmmu/vl.c
> >> @@ -2522,7 +2522,7 @@ static void qemu_process_help_options(void)
> >> static void qemu_maybe_daemonize(const char *pid_file)
> >> {
> >> - Error *err;
> >> + Error *err = NULL;
>
> Common mistake, I'm afraid.
Initializing isn't likely to be a performance impact, so I'd think
we should make 'checkpatch.pl' complain about any 'Error *' variable
that is not initialized to NULL, as a safety net, even if not technically
required in some cases.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2021-06-09 12:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 8:47 [PATCH] vl: Fix an assert failure in error path Zhenzhong Duan
2021-06-09 9:30 ` Paolo Bonzini
2021-06-09 12:09 ` Markus Armbruster
2021-06-09 12:15 ` Daniel P. Berrangé [this message]
2021-06-10 1:47 ` Peng Liang
2021-06-10 7:32 ` Markus Armbruster
2021-06-10 13:29 ` Peng Liang
2021-06-10 12:55 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMCw5E2havaaC+UI@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.