From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45467C48BCD for ; Wed, 9 Jun 2021 15:02:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E9F2611CC for ; Wed, 9 Jun 2021 15:02:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238860AbhFIPEB (ORCPT ); Wed, 9 Jun 2021 11:04:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234433AbhFIPDv (ORCPT ); Wed, 9 Jun 2021 11:03:51 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CB65C061574 for ; Wed, 9 Jun 2021 08:01:56 -0700 (PDT) Received: from zn.tnic (p200300ec2f0cf6002c8ea3a9506b9c3f.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:f600:2c8e:a3a9:506b:9c3f]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 503F21EC047D; Wed, 9 Jun 2021 17:01:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1623250914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=kfX77Ymnle+d34mKDWN8JPq3/lkoDzCapvIk1TX61Go=; b=RuWsfiN3GmZbEZfNWc4n/+NwSdXPl4TrwBuqz8CEhUjdUwMCtsxI/w+f/ttXTI29DVD8lR y8ZvuAAjrzo8dC2DYRARxUv+WUTtgrgUbNxHClmXkhwN3ih14U1MjTVYoyha5yPdeWP09F eRB7SPr9vSC8iKofGPDZ6h0xSk+/XN8= Date: Wed, 9 Jun 2021 17:01:48 +0200 From: Borislav Petkov To: "Kuppuswamy, Sathyanarayanan" Cc: Peter Zijlstra , Andy Lutomirski , Dave Hansen , Tony Luck , Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Dan Williams , Raj Ashok , Sean Christopherson , linux-kernel@vger.kernel.org, Tom Lendacky Subject: Re: [RFC v2-fix-v2 1/1] x86: Introduce generic protected guest abstraction Message-ID: References: <20210527042356.3983284-2-sathyanarayanan.kuppuswamy@linux.intel.com> <20210601211417.2177598-1-sathyanarayanan.kuppuswamy@linux.intel.com> <82f9e5a9-682a-70be-e5ea-938bb742265f@linux.intel.com> <9466ae0b-3a2a-5a43-a4c6-39e07ebe0fbc@linux.intel.com> <040a760a-de34-f184-1157-0c8c2d5fcacd@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <040a760a-de34-f184-1157-0c8c2d5fcacd@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 09, 2021 at 07:56:14AM -0700, Kuppuswamy, Sathyanarayanan wrote: > And any arch which wants to support prot_guest_has() can enable above > config option and create their own asm/protected_guest. I wouldnt've done even that but only the x86 asm version of protected_guest.h and left it to other arches to extend it. I don't like "preempting" use of functionality by other arches and would leave them to extend stuff themselves, as they see fit, but ok, ARCH_HAS_PROTECTED_GUEST sounds clean enough to me too, so sure, that's fine too. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette