From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28963C48BCF for ; Wed, 9 Jun 2021 15:27:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 030AF61351 for ; Wed, 9 Jun 2021 15:27:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239465AbhFIP3k (ORCPT ); Wed, 9 Jun 2021 11:29:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235543AbhFIP3D (ORCPT ); Wed, 9 Jun 2021 11:29:03 -0400 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 614FEC061574 for ; Wed, 9 Jun 2021 08:27:08 -0700 (PDT) Received: by mail-oi1-x22b.google.com with SMTP id a26so4748209oie.11 for ; Wed, 09 Jun 2021 08:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CgJuBx+Pz7LVmI0PFBi6kdiCkymNrSp5mHVaaKI3av4=; b=qp/JEUr4X5TDvBZmnLsMFOCFzx+kDAgnp0yl0wdmEKLnFnb51Gt3TOzzNP4ckU5597 Bloq+oNivWX3ewJOfClJeIlniSuEH0gtIyoq7b5hL4AfyXlJTJ7G0f0nFnro+SODHaP7 VOCVnNXyku3hnlkXr2eWqBpG6o+wJOwnZUigE1hKQTJulQhqbELy/kPxYwke8TZH3qUr DRR79HcTgJBTIL9ZZ+9rbz8YKLzRlgNGbOzknothmu2l5mT4jPbqIPC5gmR8qttCNwx5 dsO/iw2064VVew1oZ6UC0iCcKmwsrCj61lQFiJzzv1+nuEFALUNdQESnI1DGbWuScuwP N5TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CgJuBx+Pz7LVmI0PFBi6kdiCkymNrSp5mHVaaKI3av4=; b=ED9YFLVnjOicZstWunXK0EI09W72iyRwK9PpTvJFh3AgSYZ7Gc3c085JhgRc9mt6m7 uY73PxCGKyZj2C0MwUsabuJr6cnr3Le4mqJk59qZdpO2X97M1tQ4xQjqGCFgq7k/AP9V Lni+/QmW2a6ukDMALp/5mFTAXqDGSJ1qOFuxOhWJ4Fcnmm3mTlDFquNI+yh/oAbcxzhQ +ud5+bhcNgVCRJhBDo3vfH4PmBRsS7bihD3Wgfbt/n9dlxK/ve2QsT5IzlI1qyH2tQyh hys5teovIvG9hoURH4fl246erNmhLCuoSjvU3BEdk8KCUJghC2SNeNSbicAwE1ke4MCG Dzsw== X-Gm-Message-State: AOAM530Up4dATUyeTTV8x4KzHPsd0r6prTVOTSLxrtPRrnVXULvFTFqI fdVE7uId/yHna9Cqy6HWz7u5uQ== X-Google-Smtp-Source: ABdhPJyolhMXyfsnX4dd8qid83wHXAc8WqbuNrQQd9y6dWJSSJ8cdN7AVqfoCd9puEeQt9C6524BxA== X-Received: by 2002:aca:38c1:: with SMTP id f184mr122667oia.101.1623252427729; Wed, 09 Jun 2021 08:27:07 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id u26sm49756ote.53.2021.06.09.08.27.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 08:27:07 -0700 (PDT) Date: Wed, 9 Jun 2021 10:27:04 -0500 From: Bjorn Andersson To: Douglas Anderson Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Sam Ravnborg , Linus W , robdclark@chromium.org, Maarten Lankhorst , Stanislav Lisovskiy , Steev Klimaszewski , linux-arm-msm@vger.kernel.org, Thierry Reding , Lyude Paul , dri-devel@lists.freedesktop.org, Stephen Boyd , Andy Gross , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 11/11] arm64: dts: qcom: sc7180-trogdor: Move panel under the bridge chip Message-ID: References: <20210607170555.4006050-1-dianders@chromium.org> <20210607100234.v9.11.Ibdb7735fb1844561b902252215a69526a14f9abd@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210607100234.v9.11.Ibdb7735fb1844561b902252215a69526a14f9abd@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 07 Jun 12:05 CDT 2021, Douglas Anderson wrote: > Putting the panel under the bridge chip (under the aux-bus node) > allows the panel driver to get access to the DP AUX bus, enabling all > sorts of fabulous new features. > > While we're at this, get rid of a level of hierarchy for the panel > node. It doesn't need "ports / port" and can just have a "port" child. > > For Linux, this patch has a hard requirement on the patches adding DP > AUX bus support to the ti-sn65dsi86 bridge chip driver. See the patch > ("drm/bridge: ti-sn65dsi86: Add support for the DP AUX bus"). > > Signed-off-by: Douglas Anderson > Acked-by: Linus Walleij In case you want to merge this together with the driver changes (even though there's no direct need for them to go together): Acked-by: Bjorn Andersson Regards, Bjorn > --- > > (no changes since v7) > > Changes in v7: > - Panel now under bridge chip instead of getting a link to ddc-i2c > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 30 ++++++++++---------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 24d293ef56d7..c76afd857b54 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -260,21 +260,6 @@ max98357a: audio-codec-0 { > #sound-dai-cells = <0>; > }; > > - panel: panel { > - /* Compatible will be filled in per-board */ > - power-supply = <&pp3300_dx_edp>; > - backlight = <&backlight>; > - hpd-gpios = <&sn65dsi86_bridge 2 GPIO_ACTIVE_HIGH>; > - > - ports { > - port { > - panel_in_edp: endpoint { > - remote-endpoint = <&sn65dsi86_out>; > - }; > - }; > - }; > - }; > - > pwmleds { > compatible = "pwm-leds"; > keyboard_backlight: keyboard-backlight { > @@ -674,6 +659,21 @@ sn65dsi86_out: endpoint { > }; > }; > }; > + > + aux-bus { > + panel: panel { > + /* Compatible will be filled in per-board */ > + power-supply = <&pp3300_dx_edp>; > + backlight = <&backlight>; > + hpd-gpios = <&sn65dsi86_bridge 2 GPIO_ACTIVE_HIGH>; > + > + port { > + panel_in_edp: endpoint { > + remote-endpoint = <&sn65dsi86_out>; > + }; > + }; > + }; > + }; > }; > }; > > -- > 2.32.0.rc1.229.g3e70b5a671-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF938C48BCF for ; Wed, 9 Jun 2021 15:27:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95E80611CC for ; Wed, 9 Jun 2021 15:27:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95E80611CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 152746E0F6; Wed, 9 Jun 2021 15:27:10 +0000 (UTC) Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F32A6E0F6 for ; Wed, 9 Jun 2021 15:27:08 +0000 (UTC) Received: by mail-oi1-x229.google.com with SMTP id u11so25466891oiv.1 for ; Wed, 09 Jun 2021 08:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CgJuBx+Pz7LVmI0PFBi6kdiCkymNrSp5mHVaaKI3av4=; b=qp/JEUr4X5TDvBZmnLsMFOCFzx+kDAgnp0yl0wdmEKLnFnb51Gt3TOzzNP4ckU5597 Bloq+oNivWX3ewJOfClJeIlniSuEH0gtIyoq7b5hL4AfyXlJTJ7G0f0nFnro+SODHaP7 VOCVnNXyku3hnlkXr2eWqBpG6o+wJOwnZUigE1hKQTJulQhqbELy/kPxYwke8TZH3qUr DRR79HcTgJBTIL9ZZ+9rbz8YKLzRlgNGbOzknothmu2l5mT4jPbqIPC5gmR8qttCNwx5 dsO/iw2064VVew1oZ6UC0iCcKmwsrCj61lQFiJzzv1+nuEFALUNdQESnI1DGbWuScuwP N5TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CgJuBx+Pz7LVmI0PFBi6kdiCkymNrSp5mHVaaKI3av4=; b=X7TGN/QGq3L851pG4rdJSAOaBRqz3aM15Q48cHqfh2RtL76FFdrCg4MGzPDUzOPLO1 PhQh3h4RWSoSJvS+BGcC2y2pvmSEuBZuzMaKd3peU/5I9+MOpCCn2q6W+5ymXr4IAvQZ ck9lIas+MIf3yjsvPIEZgQ3N4yjI0NNdd2yJIxIWZmyCkhbM4CmEGETWxTKQ4emRhLbh 0h7DXXra760Ugp3d7h4Chq/QNzxjB4iX88QE2vCw4J7/TWC0TJdMUkenY/rSlbK5+JKi quRMPdP1Igm3KZnHca8NsQmsOzipGanNl1jOx1UkeOPXuOtYpMHEEl848zC9O+1sv6Wq CQ7Q== X-Gm-Message-State: AOAM533OnGps0LVvE+XTesQXY9P3yI9gsCC7pMuRdHdQAnVJogk6cpDP dDAoFplyYaE7S0W1JO9ZSobhlw== X-Google-Smtp-Source: ABdhPJyolhMXyfsnX4dd8qid83wHXAc8WqbuNrQQd9y6dWJSSJ8cdN7AVqfoCd9puEeQt9C6524BxA== X-Received: by 2002:aca:38c1:: with SMTP id f184mr122667oia.101.1623252427729; Wed, 09 Jun 2021 08:27:07 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id u26sm49756ote.53.2021.06.09.08.27.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Jun 2021 08:27:07 -0700 (PDT) Date: Wed, 9 Jun 2021 10:27:04 -0500 From: Bjorn Andersson To: Douglas Anderson Subject: Re: [PATCH v9 11/11] arm64: dts: qcom: sc7180-trogdor: Move panel under the bridge chip Message-ID: References: <20210607170555.4006050-1-dianders@chromium.org> <20210607100234.v9.11.Ibdb7735fb1844561b902252215a69526a14f9abd@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210607100234.v9.11.Ibdb7735fb1844561b902252215a69526a14f9abd@changeid> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Jonas Karlman , linux-arm-msm@vger.kernel.org, Neil Armstrong , linux-kernel@vger.kernel.org, Steev Klimaszewski , Stephen Boyd , Stanislav Lisovskiy , Andrzej Hajda , Andy Gross , Laurent Pinchart , Rob Herring , Thierry Reding , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon 07 Jun 12:05 CDT 2021, Douglas Anderson wrote: > Putting the panel under the bridge chip (under the aux-bus node) > allows the panel driver to get access to the DP AUX bus, enabling all > sorts of fabulous new features. > > While we're at this, get rid of a level of hierarchy for the panel > node. It doesn't need "ports / port" and can just have a "port" child. > > For Linux, this patch has a hard requirement on the patches adding DP > AUX bus support to the ti-sn65dsi86 bridge chip driver. See the patch > ("drm/bridge: ti-sn65dsi86: Add support for the DP AUX bus"). > > Signed-off-by: Douglas Anderson > Acked-by: Linus Walleij In case you want to merge this together with the driver changes (even though there's no direct need for them to go together): Acked-by: Bjorn Andersson Regards, Bjorn > --- > > (no changes since v7) > > Changes in v7: > - Panel now under bridge chip instead of getting a link to ddc-i2c > > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 30 ++++++++++---------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index 24d293ef56d7..c76afd857b54 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -260,21 +260,6 @@ max98357a: audio-codec-0 { > #sound-dai-cells = <0>; > }; > > - panel: panel { > - /* Compatible will be filled in per-board */ > - power-supply = <&pp3300_dx_edp>; > - backlight = <&backlight>; > - hpd-gpios = <&sn65dsi86_bridge 2 GPIO_ACTIVE_HIGH>; > - > - ports { > - port { > - panel_in_edp: endpoint { > - remote-endpoint = <&sn65dsi86_out>; > - }; > - }; > - }; > - }; > - > pwmleds { > compatible = "pwm-leds"; > keyboard_backlight: keyboard-backlight { > @@ -674,6 +659,21 @@ sn65dsi86_out: endpoint { > }; > }; > }; > + > + aux-bus { > + panel: panel { > + /* Compatible will be filled in per-board */ > + power-supply = <&pp3300_dx_edp>; > + backlight = <&backlight>; > + hpd-gpios = <&sn65dsi86_bridge 2 GPIO_ACTIVE_HIGH>; > + > + port { > + panel_in_edp: endpoint { > + remote-endpoint = <&sn65dsi86_out>; > + }; > + }; > + }; > + }; > }; > }; > > -- > 2.32.0.rc1.229.g3e70b5a671-goog >