From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4636AC48BCD for ; Wed, 9 Jun 2021 18:43:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EDBE613E1 for ; Wed, 9 Jun 2021 18:43:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230197AbhFISpe (ORCPT ); Wed, 9 Jun 2021 14:45:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:50014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230161AbhFISp2 (ORCPT ); Wed, 9 Jun 2021 14:45:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1BBE2613AC; Wed, 9 Jun 2021 18:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623264213; bh=vQ1SsFfCywlqRQRnaHRZ0AG6i982cLly1NBLPalQ438=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KNq0WJ0yN5xclxnJkMdACG3Nq7ICu17YRELK6TYkDFTbdsmlCv+C6JxITHWzlqi22 ZKw1TUCA62EdnA12aBTi+YKko9SRWAy3wKyrLQ6tCw5EJicYpB5pks9D1qK1vOMn17 FPKQ9mNwgC0IZA3FzV8Qw6Q368AlvIkeg65SFSHJim10xmlGe2URIopbZymCTEl3bm JGdcCCNIsR/LZcLmK+Lv8Cnr7aJZ8E9UDUJbCc0pr3NRvVZ40OZnN0rPS9TfziWNWg L/x90essw1KJFOjv4iCrSzKAJD1wP70/mdKFQmD10HuwiANoFbNbisicFaGDSf/Ocu LOSKgO+P8ufNw== Date: Wed, 9 Jun 2021 11:43:31 -0700 From: Jaegeuk Kim To: Chao Yu Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: introduce FI_COMPRESS_RELEASED instead of using IMMUTABLE bit Message-ID: References: <20210525204955.2512409-1-jaegeuk@kernel.org> <20210525204955.2512409-2-jaegeuk@kernel.org> <95b5669f-a521-5865-2089-320e2a2493de@kernel.org> <3f2c2543-c8a4-3477-76af-5c7614b643e8@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3f2c2543-c8a4-3477-76af-5c7614b643e8@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08, Chao Yu wrote: > On 2021/6/8 0:56, Jaegeuk Kim wrote: > > On 06/06, Chao Yu wrote: > > > On 2021/5/26 4:49, Jaegeuk Kim wrote: > > > > Once we release compressed blocks, we used to set IMMUTABLE bit. But it turned > > > > out it disallows every fs operations which we don't need for compression. > > > > > > > > Let's just prevent writing data only. > > > > > > > > Signed-off-by: Jaegeuk Kim > > > > > > Reviewed-by: Chao Yu > > > > > > BTW, we need to expose .i_inline field to userspace since there is no > > > way to check status of inode whether it has released blocks? > > > > Need to add some in F2FS_IOC_GET_COMPRESS_OPTION? > > We should not change this interface, in order to keep its compatibility for > userspace usage. How about adding it in F2FS_IOC_GET_COMPRESS_OPTION_EX? Hmm, or need to add it in getflags? > > Thanks, > > > > > > > > > Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B33FBC48BCD for ; Wed, 9 Jun 2021 18:43:49 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CDD2613DC for ; Wed, 9 Jun 2021 18:43:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CDD2613DC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1lr3B5-00010s-6r; Wed, 09 Jun 2021 18:43:47 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lr3B1-000109-Aw for linux-f2fs-devel@lists.sourceforge.net; Wed, 09 Jun 2021 18:43:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dON7xF/idpASYpnfKuhXI4rlP9ab85ZunO4am1eHyf0=; b=VqXborISfn6rcB5CnqmqCNsrPV A3Qx+2Rsfk8Q41lKCE6FLGeFp0WK+FvdQVADpSPRd0GOC75DRb0GqCHSyYGxqU2ZM7nNPYI0KnURU 4URVXInYVQByLmoeVgKHStclKdBfNvWfB0Nm37n9b02BgqcpX/KQgYmFFxHVqTQ8FXhA=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dON7xF/idpASYpnfKuhXI4rlP9ab85ZunO4am1eHyf0=; b=b29HXiWLk/ciCBrgaAN93pZCHQ GnMym096v7++S60HNuS5LysgWL7gbGAAvjVqDsHmtip4FB0lr+u10mHhLQqknslKKuHS9zcN/zKHf qopLiKGn+WBrCNDuUTmT1KL2voTYpFL+PFEErR52hGZRUk1q1sFh8r9cdMGJ4m0bJeWI=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1lr3Aw-002Trk-JJ for linux-f2fs-devel@lists.sourceforge.net; Wed, 09 Jun 2021 18:43:42 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1BBE2613AC; Wed, 9 Jun 2021 18:43:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623264213; bh=vQ1SsFfCywlqRQRnaHRZ0AG6i982cLly1NBLPalQ438=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KNq0WJ0yN5xclxnJkMdACG3Nq7ICu17YRELK6TYkDFTbdsmlCv+C6JxITHWzlqi22 ZKw1TUCA62EdnA12aBTi+YKko9SRWAy3wKyrLQ6tCw5EJicYpB5pks9D1qK1vOMn17 FPKQ9mNwgC0IZA3FzV8Qw6Q368AlvIkeg65SFSHJim10xmlGe2URIopbZymCTEl3bm JGdcCCNIsR/LZcLmK+Lv8Cnr7aJZ8E9UDUJbCc0pr3NRvVZ40OZnN0rPS9TfziWNWg L/x90essw1KJFOjv4iCrSzKAJD1wP70/mdKFQmD10HuwiANoFbNbisicFaGDSf/Ocu LOSKgO+P8ufNw== Date: Wed, 9 Jun 2021 11:43:31 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20210525204955.2512409-1-jaegeuk@kernel.org> <20210525204955.2512409-2-jaegeuk@kernel.org> <95b5669f-a521-5865-2089-320e2a2493de@kernel.org> <3f2c2543-c8a4-3477-76af-5c7614b643e8@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3f2c2543-c8a4-3477-76af-5c7614b643e8@kernel.org> X-Headers-End: 1lr3Aw-002Trk-JJ Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: introduce FI_COMPRESS_RELEASED instead of using IMMUTABLE bit X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 06/08, Chao Yu wrote: > On 2021/6/8 0:56, Jaegeuk Kim wrote: > > On 06/06, Chao Yu wrote: > > > On 2021/5/26 4:49, Jaegeuk Kim wrote: > > > > Once we release compressed blocks, we used to set IMMUTABLE bit. But it turned > > > > out it disallows every fs operations which we don't need for compression. > > > > > > > > Let's just prevent writing data only. > > > > > > > > Signed-off-by: Jaegeuk Kim > > > > > > Reviewed-by: Chao Yu > > > > > > BTW, we need to expose .i_inline field to userspace since there is no > > > way to check status of inode whether it has released blocks? > > > > Need to add some in F2FS_IOC_GET_COMPRESS_OPTION? > > We should not change this interface, in order to keep its compatibility for > userspace usage. How about adding it in F2FS_IOC_GET_COMPRESS_OPTION_EX? Hmm, or need to add it in getflags? > > Thanks, > > > > > > > > > Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel