All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan@gerhold.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	linux-iio <linux-iio@vger.kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Bastien Nocera <hadess@hadess.net>,
	Hans de Goede <hdegoede@redhat.com>,
	~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 6/9] iio: accel: bmc150: Add device IDs for BMA253
Date: Thu, 10 Jun 2021 15:02:52 +0200	[thread overview]
Message-ID: <YMINfLkT0gxZKI2g@gerhold.net> (raw)
In-Reply-To: <CAHp75VdutqFuhTnZsi79ZgcVcL+o7M1k+cOFUKRB_vUUXiWJgA@mail.gmail.com>

On Thu, Jun 10, 2021 at 03:51:46PM +0300, Andy Shevchenko wrote:
> On Thu, Jun 10, 2021 at 3:24 PM Stephan Gerhold <stephan@gerhold.net> wrote:
> > BMA253 is mostly like BMA255 and has exactly the same register layout
> > as used by the bmc150-accel driver as far I can tell. Making it work
> > is as simple as adding new device IDs for it since it has the same
> > chip_id = 0xFA (250) as BMA255 and others.
> 
> ...
> 
> > -               .name = "BMC150/BMI055/BMA255",
> 
> Somehow this is unsorted.
> 
> > +               .name = "BMC150/BMI055/BMA253/BMA255",
> 
> So does this.
> 

Yeah I sorted multi-line lists and Kconfig but not those "one-line"
lists... :-) Time for v3...

Thanks for your review!
Stephan

  reply	other threads:[~2021-06-10 13:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-10 12:21 [PATCH v2 0/9] iio: accel: bmc150: Add support for BMA253/BMA254 Stephan Gerhold
2021-06-10 12:21 ` [PATCH v2 1/9] iio: accel: bmc150: Fix bma222 scale unit Stephan Gerhold
2021-06-10 12:21 ` [PATCH v2 2/9] iio: accel: bmc150: Drop misleading/duplicate chip identifiers Stephan Gerhold
2021-06-10 12:21 ` [PATCH v2 3/9] iio: accel: bmc150: Drop duplicated documentation of supported chips Stephan Gerhold
2021-06-10 12:45   ` Andy Shevchenko
2021-06-10 12:48     ` Stephan Gerhold
2021-06-10 12:21 ` [PATCH v2 4/9] iio: accel: bmc150: Sort all chip names alphabetically / by chip ID Stephan Gerhold
2021-06-10 12:50   ` Andy Shevchenko
2021-06-10 13:00     ` Stephan Gerhold
2021-06-10 12:21 ` [PATCH v2 5/9] dt-bindings: iio: accel: bma255: Document bosch,bma253 Stephan Gerhold
2021-06-10 12:21 ` [PATCH v2 6/9] iio: accel: bmc150: Add device IDs for BMA253 Stephan Gerhold
2021-06-10 12:51   ` Andy Shevchenko
2021-06-10 13:02     ` Stephan Gerhold [this message]
2021-06-10 12:21 ` [PATCH v2 7/9] dt-bindings: iio: bma255: Allow multiple interrupts Stephan Gerhold
2021-06-10 12:21 ` [PATCH v2 8/9] dt-bindings: iio: accel: bma180/bma255: Move bma254 to bma255 schema Stephan Gerhold
2021-06-10 12:21 ` [PATCH v2 9/9] iio: accel: bma180/bmc150: Move BMA254 to bmc150-accel driver Stephan Gerhold
2021-06-10 12:54   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMINfLkT0gxZKI2g@gerhold.net \
    --to=stephan@gerhold.net \
    --cc=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hadess@hadess.net \
    --cc=hdegoede@redhat.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.