From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Andy Shevchenko <andy@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH] pinctrl: intel: fix NULL pointer deref
Date: Thu, 10 Jun 2021 17:25:04 +0300 [thread overview]
Message-ID: <YMIgwORlAzz/gJcK@smile.fi.intel.com> (raw)
In-Reply-To: <20210609130816.3631f0aa@md1za8fc.ad001.siemens.net>
On Wed, Jun 09, 2021 at 01:08:16PM +0200, Henning Schild wrote:
> Am Wed, 9 Jun 2021 13:33:34 +0300
> schrieb Andy Shevchenko <andy.shevchenko@gmail.com>:
...
> In order to use GPIO from the drivers i need to make sure
> "broxton-pinctrl" comes up even if p2sb is hidden.
>
> Long story short, i thought the patch was simple enough to merge even
> taken out of my special context.
>
> Currently intel_pinctl only works if "ps2b is not hidden by BIOS" or
> "ACPI tables are correct", lifting the ban on the hidden p2sb seems
> like a useful thing in general (i.e. sysfs gpio interface). And i was
> hoping Andy would take the lead on that. It is something my Siemens
> drivers would depend on, but really a generic thing as far as i
> understand it.
From p2sb series discussion it appears that this patch is not needed.
The case is when BIOS already provides an ACPI device.
So, the initial bug is in that series that needs to check if the ACPI device is
exposed and forbid platform device instantiation in that case.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-06-10 14:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 6:27 [PATCH] pinctrl: intel: fix NULL pointer deref Henning Schild
2021-06-09 10:12 ` Mika Westerberg
2021-06-09 10:33 ` Andy Shevchenko
2021-06-09 11:08 ` Henning Schild
2021-06-10 14:25 ` Andy Shevchenko [this message]
2021-06-10 14:32 ` Andy Shevchenko
2021-06-10 14:56 ` Henning Schild
2021-06-10 15:00 ` Andy Shevchenko
2021-06-10 15:28 ` Andy Shevchenko
2021-06-11 18:19 ` Henning Schild
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMIgwORlAzz/gJcK@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=henning.schild@siemens.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.