From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB6D7C48BE0 for ; Thu, 10 Jun 2021 14:42:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E546613FE for ; Thu, 10 Jun 2021 14:42:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231425AbhFJOon (ORCPT ); Thu, 10 Jun 2021 10:44:43 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:56482 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230153AbhFJOoj (ORCPT ); Thu, 10 Jun 2021 10:44:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=G/4KF+EXeK0CRlPgzQxnXXiJ5+yIDNT85WHr1QHw8N4=; b=bq6a+xbXIB1VsshgmgoWDw7fAT /kuSotYXw8oH5HLpnxnKBV4PyCkWApEMh58y6y4Aotl9R0MwhEAwj+aVwrPImpTouEQDSwaRS+zU/ zO4nYHZVJiwA//O0wt9I9mViPntavLET86XzTsSw3ftWyntMVOZ5mPkRvC1Yl2tROeww=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lrLt2-008fqS-RB; Thu, 10 Jun 2021 16:42:24 +0200 Date: Thu, 10 Jun 2021 16:42:24 +0200 From: Andrew Lunn To: Zhou Yanjie Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, rick.tyliu@ingenic.com, sihui.liu@ingenic.com, jun.jiang@ingenic.com, sernia.zhou@foxmail.com, paul@crapouillou.net Subject: Re: [PATCH v2 2/2] net: stmmac: Add Ingenic SoCs MAC support. Message-ID: References: <1623260110-25842-1-git-send-email-zhouyanjie@wanyeetech.com> <1623260110-25842-3-git-send-email-zhouyanjie@wanyeetech.com> <405696cb-5987-0e56-87f8-5a1443eadc19@wanyeetech.com> <346f64d9-6949-b506-258f-4cfa7eb22784@wanyeetech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <346f64d9-6949-b506-258f-4cfa7eb22784@wanyeetech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > We are much more strict about this now than before. You have to use > standard units and convert to hardware values. It also makes it a lot > easier for DT writers, if they have an idea what the units mean. > > Having the MAC add small delays is something you can add later, > without breaking backwards compatibility. So if you cannot determine > what the units are now, just submit the glue driver without support > for this feature. If anybody really needs it, they can do the needed > research, maybe do some measurements, and then add the code. > > > I did an experiment, when the tx delay is not set, RGMII works a You had rgmii-id in your device tree, so that the PHY added the delays? Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63BF8C47094 for ; Thu, 10 Jun 2021 14:44:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23F48613F8 for ; Thu, 10 Jun 2021 14:44:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23F48613F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6rjxrpiOL4ExKLm6K4P7kjjz1s9ga8mzQQjZSPV+RSU=; b=Sy9MF1qQ/p66Ur GzTo/DpzFIeDWPFPsukRYjE5QMRwHAEk0jJ0Liu4qp/VZNxd236eECPr61qJ/dA/BPHadkpYJj89o ulathTKrmOn2EknXln6QwLuXcktDp+ta6ZZQgcnKLnTkO0TXXrcdl7DfxjR/4YUIEgJM1dvImImqq Xj4Pt6lhz98aSc/IUtBhoaiIAGW7u8DnIO3Nw/r56K0CHu/ThVGUA7PjuzLIR2KtSLApRyu6AC0/a FHx62mnTLOt1o6p24GomWOWVU+NAUIjHrDBMMspnHBl398GEwgRQyuYT1iX8J/RtwBLpaw0xzn9tu 2VewCn0XpvqWBmq0ozIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrLtS-001Bol-CC; Thu, 10 Jun 2021 14:42:50 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lrLtO-001BnH-DS for linux-arm-kernel@lists.infradead.org; Thu, 10 Jun 2021 14:42:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=G/4KF+EXeK0CRlPgzQxnXXiJ5+yIDNT85WHr1QHw8N4=; b=bq6a+xbXIB1VsshgmgoWDw7fAT /kuSotYXw8oH5HLpnxnKBV4PyCkWApEMh58y6y4Aotl9R0MwhEAwj+aVwrPImpTouEQDSwaRS+zU/ zO4nYHZVJiwA//O0wt9I9mViPntavLET86XzTsSw3ftWyntMVOZ5mPkRvC1Yl2tROeww=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1lrLt2-008fqS-RB; Thu, 10 Jun 2021 16:42:24 +0200 Date: Thu, 10 Jun 2021 16:42:24 +0200 From: Andrew Lunn To: Zhou Yanjie Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, rick.tyliu@ingenic.com, sihui.liu@ingenic.com, jun.jiang@ingenic.com, sernia.zhou@foxmail.com, paul@crapouillou.net Subject: Re: [PATCH v2 2/2] net: stmmac: Add Ingenic SoCs MAC support. Message-ID: References: <1623260110-25842-1-git-send-email-zhouyanjie@wanyeetech.com> <1623260110-25842-3-git-send-email-zhouyanjie@wanyeetech.com> <405696cb-5987-0e56-87f8-5a1443eadc19@wanyeetech.com> <346f64d9-6949-b506-258f-4cfa7eb22784@wanyeetech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <346f64d9-6949-b506-258f-4cfa7eb22784@wanyeetech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210610_074246_488417_CAC2A2C8 X-CRM114-Status: GOOD ( 10.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > We are much more strict about this now than before. You have to use > standard units and convert to hardware values. It also makes it a lot > easier for DT writers, if they have an idea what the units mean. > > Having the MAC add small delays is something you can add later, > without breaking backwards compatibility. So if you cannot determine > what the units are now, just submit the glue driver without support > for this feature. If anybody really needs it, they can do the needed > research, maybe do some measurements, and then add the code. > > > I did an experiment, when the tx delay is not set, RGMII works a You had rgmii-id in your device tree, so that the PHY added the delays? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel