From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25D86C47094 for ; Thu, 10 Jun 2021 15:01:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E32C9613C8 for ; Thu, 10 Jun 2021 15:01:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E32C9613C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 398096EB9A; Thu, 10 Jun 2021 15:01:39 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 840776E364; Thu, 10 Jun 2021 15:01:37 +0000 (UTC) IronPort-SDR: ei7PJGnFyVIq8HDkGtxAUxlfvmbNM7+Yc88GYPsXJIMQ0Iik6xfKttiDiuucqE/WvhIp97/nY5 U6UUwWRefAiA== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="205128082" X-IronPort-AV: E=Sophos;i="5.83,263,1616482800"; d="scan'208";a="205128082" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 08:01:33 -0700 IronPort-SDR: DfzEqKMNR6W8nene9JKY81pK7FYImXmYCRcbia8QkGnT/id8DmCa7mrscNJruz89BfkPlvspiQ v+XAEwg4MN7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,263,1616482800"; d="scan'208";a="414145612" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga007.fm.intel.com with SMTP; 10 Jun 2021 08:01:29 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 10 Jun 2021 18:01:29 +0300 Date: Thu, 10 Jun 2021 18:01:29 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Emil Velikov Subject: Re: [PATCH] drm/i915: apply WaEnableVGAAccessThroughIOPort as needed Message-ID: References: <20210604154905.660142-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210604154905.660142-1-emil.l.velikov@gmail.com> X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi , kernel@collabora.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 04, 2021 at 04:49:05PM +0100, Emil Velikov wrote: > From: Emil Velikov > > Currently as the workaround is applied the screen flickers. As a result > we do not achieve seamless boot experience. > > Avoiding the issue in the common use-case might be hard, although we can > resolve it for dual GPU setups - when the "other" GPU is primary and/or > outputs are connected to it. > > With this I was able to get seamless experience on my Intel/Nvidia box, > running systemd-boot and sddm/Xorg. Note that the i915 driver is within > initrd while the Nvidia one is not. > > Without this patch, the splash presented by systemd-boot (UEFI BGRT) is > torn down as the code-path kicks in, leaving the monitor blank until the > login manager starts. > > Same issue were reported with plymouth/grub, although personally I > wasn't able to get them to behave on my setup. > > Suggested-by: Ville Syrjälä > Signed-off-by: Emil Velikov > --- Pushed to drm-intel-next. Thanks. > > Supersedes > https://lore.kernel.org/dri-devel/20210516171432.1734268-1-emil.l.velikov@gmail.com/ > > Ville, others, > > Patch is based against drm-intel/drm-intel-next and will apply cleanly > against drm-intel/drm-intel-fixes. > > If possible, can one of the i915 maintainers apply it to the latter? > > Thanks > Emil > --- > drivers/gpu/drm/i915/display/intel_vga.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i915/display/intel_vga.c > index be333699c515..7beef1206097 100644 > --- a/drivers/gpu/drm/i915/display/intel_vga.c > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_priv) > i915_reg_t vga_reg = intel_vga_cntrl_reg(dev_priv); > u8 sr1; > > + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) > + return; > + > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > outb(SR01, VGA_SR_INDEX); > -- > 2.31.1 -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEF05C47094 for ; Thu, 10 Jun 2021 15:01:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 777FA61359 for ; Thu, 10 Jun 2021 15:01:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 777FA61359 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 015EF6E364; Thu, 10 Jun 2021 15:01:39 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 840776E364; Thu, 10 Jun 2021 15:01:37 +0000 (UTC) IronPort-SDR: ei7PJGnFyVIq8HDkGtxAUxlfvmbNM7+Yc88GYPsXJIMQ0Iik6xfKttiDiuucqE/WvhIp97/nY5 U6UUwWRefAiA== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="205128082" X-IronPort-AV: E=Sophos;i="5.83,263,1616482800"; d="scan'208";a="205128082" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 08:01:33 -0700 IronPort-SDR: DfzEqKMNR6W8nene9JKY81pK7FYImXmYCRcbia8QkGnT/id8DmCa7mrscNJruz89BfkPlvspiQ v+XAEwg4MN7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,263,1616482800"; d="scan'208";a="414145612" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga007.fm.intel.com with SMTP; 10 Jun 2021 08:01:29 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 10 Jun 2021 18:01:29 +0300 Date: Thu, 10 Jun 2021 18:01:29 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Emil Velikov Message-ID: References: <20210604154905.660142-1-emil.l.velikov@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210604154905.660142-1-emil.l.velikov@gmail.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH] drm/i915: apply WaEnableVGAAccessThroughIOPort as needed X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, kernel@collabora.com Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Jun 04, 2021 at 04:49:05PM +0100, Emil Velikov wrote: > From: Emil Velikov > = > Currently as the workaround is applied the screen flickers. As a result > we do not achieve seamless boot experience. > = > Avoiding the issue in the common use-case might be hard, although we can > resolve it for dual GPU setups - when the "other" GPU is primary and/or > outputs are connected to it. > = > With this I was able to get seamless experience on my Intel/Nvidia box, > running systemd-boot and sddm/Xorg. Note that the i915 driver is within > initrd while the Nvidia one is not. > = > Without this patch, the splash presented by systemd-boot (UEFI BGRT) is > torn down as the code-path kicks in, leaving the monitor blank until the > login manager starts. > = > Same issue were reported with plymouth/grub, although personally I > wasn't able to get them to behave on my setup. > = > Suggested-by: Ville Syrj=E4l=E4 > Signed-off-by: Emil Velikov > --- Pushed to drm-intel-next. Thanks. > = > Supersedes > https://lore.kernel.org/dri-devel/20210516171432.1734268-1-emil.l.velikov= @gmail.com/ > = > Ville, others, > = > Patch is based against drm-intel/drm-intel-next and will apply cleanly > against drm-intel/drm-intel-fixes. > = > If possible, can one of the i915 maintainers apply it to the latter? > = > Thanks > Emil > --- > drivers/gpu/drm/i915/display/intel_vga.c | 3 +++ > 1 file changed, 3 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/display/intel_vga.c b/drivers/gpu/drm/i= 915/display/intel_vga.c > index be333699c515..7beef1206097 100644 > --- a/drivers/gpu/drm/i915/display/intel_vga.c > +++ b/drivers/gpu/drm/i915/display/intel_vga.c > @@ -29,6 +29,9 @@ void intel_vga_disable(struct drm_i915_private *dev_pri= v) > i915_reg_t vga_reg =3D intel_vga_cntrl_reg(dev_priv); > u8 sr1; > = > + if (intel_de_read(dev_priv, vga_reg) & VGA_DISP_DISABLE) > + return; > + > /* WaEnableVGAAccessThroughIOPort:ctg,elk,ilk,snb,ivb,vlv,hsw */ > vga_get_uninterruptible(pdev, VGA_RSRC_LEGACY_IO); > outb(SR01, VGA_SR_INDEX); > -- = > 2.31.1 -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx