* compiler.h:417:38: error: call to '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON failed: sizeof(_i) > sizeof(long)
@ 2021-06-13 14:55 Naresh Kamboju
2021-06-13 15:05 ` Greg Kroah-Hartman
0 siblings, 1 reply; 10+ messages in thread
From: Naresh Kamboju @ 2021-06-13 14:55 UTC (permalink / raw)
To: Greg Kroah-Hartman, Sasha Levin; +Cc: linux-stable, lkft-triage
The following error was noticed on stable-rc 5.12, 5.10, 5.4, 4.19,
4.14, 4.9 and 4.4
for i386 and arm.
make --silent --keep-going --jobs=8
O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm
CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache
arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'
In file included from /builds/linux/include/linux/kernel.h:11,
from /builds/linux/include/linux/list.h:9,
from /builds/linux/include/linux/preempt.h:11,
from /builds/linux/include/linux/hardirq.h:5,
from /builds/linux/include/linux/kvm_host.h:7,
from
/builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:18:
In function '__gfn_to_hva_memslot',
inlined from '__gfn_to_hva_many.part.6' at
/builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1446:9,
inlined from '__gfn_to_hva_many' at
/builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1434:22:
/builds/linux/include/linux/compiler.h:417:38: error: call to
'__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON
failed: sizeof(_i) > sizeof(long)
_compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
^
Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
ref:
https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1342604370#L389
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: compiler.h:417:38: error: call to '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON failed: sizeof(_i) > sizeof(long)
2021-06-13 14:55 compiler.h:417:38: error: call to '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON failed: sizeof(_i) > sizeof(long) Naresh Kamboju
@ 2021-06-13 15:05 ` Greg Kroah-Hartman
2021-06-14 4:54 ` Naresh Kamboju
0 siblings, 1 reply; 10+ messages in thread
From: Greg Kroah-Hartman @ 2021-06-13 15:05 UTC (permalink / raw)
To: Naresh Kamboju; +Cc: Sasha Levin, linux-stable, lkft-triage
On Sun, Jun 13, 2021 at 08:25:19PM +0530, Naresh Kamboju wrote:
> The following error was noticed on stable-rc 5.12, 5.10, 5.4, 4.19,
> 4.14, 4.9 and 4.4
> for i386 and arm.
>
> make --silent --keep-going --jobs=8
> O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm
> CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache
> arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'
> In file included from /builds/linux/include/linux/kernel.h:11,
> from /builds/linux/include/linux/list.h:9,
> from /builds/linux/include/linux/preempt.h:11,
> from /builds/linux/include/linux/hardirq.h:5,
> from /builds/linux/include/linux/kvm_host.h:7,
> from
> /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:18:
> In function '__gfn_to_hva_memslot',
> inlined from '__gfn_to_hva_many.part.6' at
> /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1446:9,
> inlined from '__gfn_to_hva_many' at
> /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1434:22:
> /builds/linux/include/linux/compiler.h:417:38: error: call to
> '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON
> failed: sizeof(_i) > sizeof(long)
> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> ^
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> ref:
> https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1342604370#L389
Odd. Does Linus's tree have this problem?
The only arm changes was in arch/arm/include/asm/cpuidle.h in the tree
right now. There are some kvm changes, but they are tiny...
Can you bisect this?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: compiler.h:417:38: error: call to '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON failed: sizeof(_i) > sizeof(long)
2021-06-13 15:05 ` Greg Kroah-Hartman
@ 2021-06-14 4:54 ` Naresh Kamboju
2021-06-14 5:18 ` Greg Kroah-Hartman
0 siblings, 1 reply; 10+ messages in thread
From: Naresh Kamboju @ 2021-06-14 4:54 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Sasha Levin, linux-stable, lkft-triage
On Sun, 13 Jun 2021 at 20:35, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Sun, Jun 13, 2021 at 08:25:19PM +0530, Naresh Kamboju wrote:
> > The following error was noticed on stable-rc 5.12, 5.10, 5.4, 4.19,
> > 4.14, 4.9 and 4.4
> > for i386 and arm.
> >
> > make --silent --keep-going --jobs=8
> > O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm
> > CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache
> > arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'
> > In file included from /builds/linux/include/linux/kernel.h:11,
> > from /builds/linux/include/linux/list.h:9,
> > from /builds/linux/include/linux/preempt.h:11,
> > from /builds/linux/include/linux/hardirq.h:5,
> > from /builds/linux/include/linux/kvm_host.h:7,
> > from
> > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:18:
> > In function '__gfn_to_hva_memslot',
> > inlined from '__gfn_to_hva_many.part.6' at
> > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1446:9,
> > inlined from '__gfn_to_hva_many' at
> > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1434:22:
> > /builds/linux/include/linux/compiler.h:417:38: error: call to
> > '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON
> > failed: sizeof(_i) > sizeof(long)
> > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > ^
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> >
> > ref:
> > https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1342604370#L389
>
> Odd. Does Linus's tree have this problem?
>
> The only arm changes was in arch/arm/include/asm/cpuidle.h in the tree
> right now. There are some kvm changes, but they are tiny...
>
> Can you bisect this?
The bisect script pointing to,
commit 1aa1b47db53e0a66899d63103b3ac1d7f54816bc
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: Tue Jun 8 15:31:42 2021 -0400
kvm: avoid speculation-based attacks from out-of-range memslot accesses
commit da27a83fd6cc7780fea190e1f5c19e87019da65c upstream.
KVM's mechanism for accessing guest memory translates a guest physical
address (gpa) to a host virtual address using the right-shifted gpa
(also known as gfn) and a struct kvm_memory_slot. The translation is
performed in __gfn_to_hva_memslot using the following formula:
hva = slot->userspace_addr + (gfn - slot->base_gfn) * PAGE_SIZE
It is expected that gfn falls within the boundaries of the guest's
physical memory. However, a guest can access invalid physical addresses
in such a way that the gfn is invalid.
__gfn_to_hva_memslot is called from kvm_vcpu_gfn_to_hva_prot, which first
retrieves a memslot through __gfn_to_memslot. While __gfn_to_memslot
does check that the gfn falls within the boundaries of the guest's
physical memory or not, a CPU can speculate the result of the check and
continue execution speculatively using an illegal gfn. The speculation
can result in calculating an out-of-bounds hva. If the resulting host
virtual address is used to load another guest physical address, this
is effectively a Spectre gadget consisting of two consecutive reads,
the second of which is data dependent on the first.
Right now it's not clear if there are any cases in which this is
exploitable. One interesting case was reported by the original author
of this patch, and involves visiting guest page tables on x86. Right
now these are not vulnerable because the hva read goes through get_user(),
which contains an LFENCE speculation barrier. However, there are
patches in progress for x86 uaccess.h to mask kernel addresses instead of
using LFENCE; once these land, a guest could use speculation to read
from the VMM's ring 3 address space. Other architectures such as ARM
already use the address masking method, and would be susceptible to
this same kind of data-dependent access gadgets. Therefore, this patch
proactively protects from these attacks by masking out-of-bounds gfns
in __gfn_to_hva_memslot, which blocks speculation of invalid hvas.
Sean Christopherson noted that this patch does not cover
kvm_read_guest_offset_cached. This however is limited to a few bytes
past the end of the cache, and therefore it is unlikely to be useful in
the context of building a chain of data dependent accesses.
Reported-by: Artemiy Margaritov <artemiy.margaritov@gmail.com>
Co-developed-by: Artemiy Margaritov <artemiy.margaritov@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/kvm_host.h | 10 +++++++++-
- Naresh
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: compiler.h:417:38: error: call to '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON failed: sizeof(_i) > sizeof(long)
2021-06-14 4:54 ` Naresh Kamboju
@ 2021-06-14 5:18 ` Greg Kroah-Hartman
2021-06-14 6:24 ` Naresh Kamboju
0 siblings, 1 reply; 10+ messages in thread
From: Greg Kroah-Hartman @ 2021-06-14 5:18 UTC (permalink / raw)
To: Naresh Kamboju; +Cc: Sasha Levin, linux-stable, lkft-triage
On Mon, Jun 14, 2021 at 10:24:23AM +0530, Naresh Kamboju wrote:
> On Sun, 13 Jun 2021 at 20:35, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Sun, Jun 13, 2021 at 08:25:19PM +0530, Naresh Kamboju wrote:
> > > The following error was noticed on stable-rc 5.12, 5.10, 5.4, 4.19,
> > > 4.14, 4.9 and 4.4
> > > for i386 and arm.
> > >
> > > make --silent --keep-going --jobs=8
> > > O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm
> > > CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache
> > > arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'
> > > In file included from /builds/linux/include/linux/kernel.h:11,
> > > from /builds/linux/include/linux/list.h:9,
> > > from /builds/linux/include/linux/preempt.h:11,
> > > from /builds/linux/include/linux/hardirq.h:5,
> > > from /builds/linux/include/linux/kvm_host.h:7,
> > > from
> > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:18:
> > > In function '__gfn_to_hva_memslot',
> > > inlined from '__gfn_to_hva_many.part.6' at
> > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1446:9,
> > > inlined from '__gfn_to_hva_many' at
> > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1434:22:
> > > /builds/linux/include/linux/compiler.h:417:38: error: call to
> > > '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON
> > > failed: sizeof(_i) > sizeof(long)
> > > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > > ^
> > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > >
> > > ref:
> > > https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1342604370#L389
> >
> > Odd. Does Linus's tree have this problem?
> >
> > The only arm changes was in arch/arm/include/asm/cpuidle.h in the tree
> > right now. There are some kvm changes, but they are tiny...
> >
> > Can you bisect this?
>
> The bisect script pointing to,
>
> commit 1aa1b47db53e0a66899d63103b3ac1d7f54816bc
> Author: Paolo Bonzini <pbonzini@redhat.com>
> Date: Tue Jun 8 15:31:42 2021 -0400
> kvm: avoid speculation-based attacks from out-of-range memslot accesses
>
> commit da27a83fd6cc7780fea190e1f5c19e87019da65c upstream.
Ah, so is Linus's tree also broken the same way?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: compiler.h:417:38: error: call to '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON failed: sizeof(_i) > sizeof(long)
2021-06-14 5:18 ` Greg Kroah-Hartman
@ 2021-06-14 6:24 ` Naresh Kamboju
2021-06-14 8:36 ` Greg Kroah-Hartman
0 siblings, 1 reply; 10+ messages in thread
From: Naresh Kamboju @ 2021-06-14 6:24 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Sasha Levin, linux-stable, lkft-triage
On Mon, 14 Jun 2021 at 10:48, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Mon, Jun 14, 2021 at 10:24:23AM +0530, Naresh Kamboju wrote:
> > On Sun, 13 Jun 2021 at 20:35, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Sun, Jun 13, 2021 at 08:25:19PM +0530, Naresh Kamboju wrote:
> > > > The following error was noticed on stable-rc 5.12, 5.10, 5.4, 4.19,
> > > > 4.14, 4.9 and 4.4
> > > > for i386 and arm.
> > > >
> > > > make --silent --keep-going --jobs=8
> > > > O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm
> > > > CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache
> > > > arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'
> > > > In file included from /builds/linux/include/linux/kernel.h:11,
> > > > from /builds/linux/include/linux/list.h:9,
> > > > from /builds/linux/include/linux/preempt.h:11,
> > > > from /builds/linux/include/linux/hardirq.h:5,
> > > > from /builds/linux/include/linux/kvm_host.h:7,
> > > > from
> > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:18:
> > > > In function '__gfn_to_hva_memslot',
> > > > inlined from '__gfn_to_hva_many.part.6' at
> > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1446:9,
> > > > inlined from '__gfn_to_hva_many' at
> > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1434:22:
> > > > /builds/linux/include/linux/compiler.h:417:38: error: call to
> > > > '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON
> > > > failed: sizeof(_i) > sizeof(long)
> > > > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > > > ^
> > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > >
> > > > ref:
> > > > https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1342604370#L389
> > >
> > > Odd. Does Linus's tree have this problem?
> > >
> > > The only arm changes was in arch/arm/include/asm/cpuidle.h in the tree
> > > right now. There are some kvm changes, but they are tiny...
> > >
> > > Can you bisect this?
> >
> > The bisect script pointing to,
> >
> > commit 1aa1b47db53e0a66899d63103b3ac1d7f54816bc
> > Author: Paolo Bonzini <pbonzini@redhat.com>
> > Date: Tue Jun 8 15:31:42 2021 -0400
> > kvm: avoid speculation-based attacks from out-of-range memslot accesses
> >
> > commit da27a83fd6cc7780fea190e1f5c19e87019da65c upstream.
>
> Ah, so is Linus's tree also broken the same way?
No.
Linus's tree builds successfully.
- Naresh
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: compiler.h:417:38: error: call to '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON failed: sizeof(_i) > sizeof(long)
2021-06-14 6:24 ` Naresh Kamboju
@ 2021-06-14 8:36 ` Greg Kroah-Hartman
2021-06-14 8:40 ` Greg Kroah-Hartman
0 siblings, 1 reply; 10+ messages in thread
From: Greg Kroah-Hartman @ 2021-06-14 8:36 UTC (permalink / raw)
To: Paolo Bonzini, Naresh Kamboju; +Cc: Sasha Levin, linux-stable, lkft-triage
On Mon, Jun 14, 2021 at 11:54:40AM +0530, Naresh Kamboju wrote:
> On Mon, 14 Jun 2021 at 10:48, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Mon, Jun 14, 2021 at 10:24:23AM +0530, Naresh Kamboju wrote:
> > > On Sun, 13 Jun 2021 at 20:35, Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > On Sun, Jun 13, 2021 at 08:25:19PM +0530, Naresh Kamboju wrote:
> > > > > The following error was noticed on stable-rc 5.12, 5.10, 5.4, 4.19,
> > > > > 4.14, 4.9 and 4.4
> > > > > for i386 and arm.
> > > > >
> > > > > make --silent --keep-going --jobs=8
> > > > > O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm
> > > > > CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache
> > > > > arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'
> > > > > In file included from /builds/linux/include/linux/kernel.h:11,
> > > > > from /builds/linux/include/linux/list.h:9,
> > > > > from /builds/linux/include/linux/preempt.h:11,
> > > > > from /builds/linux/include/linux/hardirq.h:5,
> > > > > from /builds/linux/include/linux/kvm_host.h:7,
> > > > > from
> > > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:18:
> > > > > In function '__gfn_to_hva_memslot',
> > > > > inlined from '__gfn_to_hva_many.part.6' at
> > > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1446:9,
> > > > > inlined from '__gfn_to_hva_many' at
> > > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1434:22:
> > > > > /builds/linux/include/linux/compiler.h:417:38: error: call to
> > > > > '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON
> > > > > failed: sizeof(_i) > sizeof(long)
> > > > > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > > > > ^
> > > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > > >
> > > > > ref:
> > > > > https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1342604370#L389
> > > >
> > > > Odd. Does Linus's tree have this problem?
> > > >
> > > > The only arm changes was in arch/arm/include/asm/cpuidle.h in the tree
> > > > right now. There are some kvm changes, but they are tiny...
> > > >
> > > > Can you bisect this?
> > >
> > > The bisect script pointing to,
> > >
> > > commit 1aa1b47db53e0a66899d63103b3ac1d7f54816bc
> > > Author: Paolo Bonzini <pbonzini@redhat.com>
> > > Date: Tue Jun 8 15:31:42 2021 -0400
> > > kvm: avoid speculation-based attacks from out-of-range memslot accesses
> > >
> > > commit da27a83fd6cc7780fea190e1f5c19e87019da65c upstream.
> >
> > Ah, so is Linus's tree also broken the same way?
>
> No.
> Linus's tree builds successfully.
Odd. Paolo, did your above commit da27a83fd6cc ("kvm: avoid
speculation-based attacks from out-of-range memslot accesses"), require
any other changes to get arm32 systems to build properly?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: compiler.h:417:38: error: call to '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON failed: sizeof(_i) > sizeof(long)
2021-06-14 8:36 ` Greg Kroah-Hartman
@ 2021-06-14 8:40 ` Greg Kroah-Hartman
2021-06-14 9:39 ` Naresh Kamboju
0 siblings, 1 reply; 10+ messages in thread
From: Greg Kroah-Hartman @ 2021-06-14 8:40 UTC (permalink / raw)
To: Paolo Bonzini, Naresh Kamboju; +Cc: Sasha Levin, linux-stable, lkft-triage
On Mon, Jun 14, 2021 at 10:36:14AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jun 14, 2021 at 11:54:40AM +0530, Naresh Kamboju wrote:
> > On Mon, 14 Jun 2021 at 10:48, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Mon, Jun 14, 2021 at 10:24:23AM +0530, Naresh Kamboju wrote:
> > > > On Sun, 13 Jun 2021 at 20:35, Greg Kroah-Hartman
> > > > <gregkh@linuxfoundation.org> wrote:
> > > > >
> > > > > On Sun, Jun 13, 2021 at 08:25:19PM +0530, Naresh Kamboju wrote:
> > > > > > The following error was noticed on stable-rc 5.12, 5.10, 5.4, 4.19,
> > > > > > 4.14, 4.9 and 4.4
> > > > > > for i386 and arm.
> > > > > >
> > > > > > make --silent --keep-going --jobs=8
> > > > > > O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm
> > > > > > CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache
> > > > > > arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'
> > > > > > In file included from /builds/linux/include/linux/kernel.h:11,
> > > > > > from /builds/linux/include/linux/list.h:9,
> > > > > > from /builds/linux/include/linux/preempt.h:11,
> > > > > > from /builds/linux/include/linux/hardirq.h:5,
> > > > > > from /builds/linux/include/linux/kvm_host.h:7,
> > > > > > from
> > > > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:18:
> > > > > > In function '__gfn_to_hva_memslot',
> > > > > > inlined from '__gfn_to_hva_many.part.6' at
> > > > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1446:9,
> > > > > > inlined from '__gfn_to_hva_many' at
> > > > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1434:22:
> > > > > > /builds/linux/include/linux/compiler.h:417:38: error: call to
> > > > > > '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON
> > > > > > failed: sizeof(_i) > sizeof(long)
> > > > > > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > > > > > ^
> > > > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > > > >
> > > > > > ref:
> > > > > > https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1342604370#L389
> > > > >
> > > > > Odd. Does Linus's tree have this problem?
> > > > >
> > > > > The only arm changes was in arch/arm/include/asm/cpuidle.h in the tree
> > > > > right now. There are some kvm changes, but they are tiny...
> > > > >
> > > > > Can you bisect this?
> > > >
> > > > The bisect script pointing to,
> > > >
> > > > commit 1aa1b47db53e0a66899d63103b3ac1d7f54816bc
> > > > Author: Paolo Bonzini <pbonzini@redhat.com>
> > > > Date: Tue Jun 8 15:31:42 2021 -0400
> > > > kvm: avoid speculation-based attacks from out-of-range memslot accesses
> > > >
> > > > commit da27a83fd6cc7780fea190e1f5c19e87019da65c upstream.
> > >
> > > Ah, so is Linus's tree also broken the same way?
> >
> > No.
> > Linus's tree builds successfully.
>
> Odd. Paolo, did your above commit da27a83fd6cc ("kvm: avoid
> speculation-based attacks from out-of-range memslot accesses"), require
> any other changes to get arm32 systems to build properly?
Doh, I need 4422829e8053 ("kvm: fix previous commit for 32-bit builds")
as well...
Nevermind, will go queue that up right now...
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: compiler.h:417:38: error: call to '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON failed: sizeof(_i) > sizeof(long)
2021-06-14 8:40 ` Greg Kroah-Hartman
@ 2021-06-14 9:39 ` Naresh Kamboju
2021-06-14 9:46 ` Greg Kroah-Hartman
0 siblings, 1 reply; 10+ messages in thread
From: Naresh Kamboju @ 2021-06-14 9:39 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Paolo Bonzini, Sasha Levin, linux-stable, lkft-triage
On Mon, 14 Jun 2021 at 14:10, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Mon, Jun 14, 2021 at 10:36:14AM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Jun 14, 2021 at 11:54:40AM +0530, Naresh Kamboju wrote:
> > > On Mon, 14 Jun 2021 at 10:48, Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > On Mon, Jun 14, 2021 at 10:24:23AM +0530, Naresh Kamboju wrote:
> > > > > On Sun, 13 Jun 2021 at 20:35, Greg Kroah-Hartman
> > > > > <gregkh@linuxfoundation.org> wrote:
> > > > > >
> > > > > > On Sun, Jun 13, 2021 at 08:25:19PM +0530, Naresh Kamboju wrote:
> > > > > > > The following error was noticed on stable-rc 5.12, 5.10, 5.4, 4.19,
> > > > > > > 4.14, 4.9 and 4.4
> > > > > > > for i386 and arm.
> > > > > > >
> > > > > > > make --silent --keep-going --jobs=8
> > > > > > > O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm
> > > > > > > CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache
> > > > > > > arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'
> > > > > > > In file included from /builds/linux/include/linux/kernel.h:11,
> > > > > > > from /builds/linux/include/linux/list.h:9,
> > > > > > > from /builds/linux/include/linux/preempt.h:11,
> > > > > > > from /builds/linux/include/linux/hardirq.h:5,
> > > > > > > from /builds/linux/include/linux/kvm_host.h:7,
> > > > > > > from
> > > > > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:18:
> > > > > > > In function '__gfn_to_hva_memslot',
> > > > > > > inlined from '__gfn_to_hva_many.part.6' at
> > > > > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1446:9,
> > > > > > > inlined from '__gfn_to_hva_many' at
> > > > > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1434:22:
> > > > > > > /builds/linux/include/linux/compiler.h:417:38: error: call to
> > > > > > > '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON
> > > > > > > failed: sizeof(_i) > sizeof(long)
> > > > > > > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > > > > > > ^
> > > > > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > > > > >
> > > > > > > ref:
> > > > > > > https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1342604370#L389
> > > > > >
> > > > > > Odd. Does Linus's tree have this problem?
> > > > > >
> > > > > > The only arm changes was in arch/arm/include/asm/cpuidle.h in the tree
> > > > > > right now. There are some kvm changes, but they are tiny...
> > > > > >
> > > > > > Can you bisect this?
> > > > >
> > > > > The bisect script pointing to,
> > > > >
> > > > > commit 1aa1b47db53e0a66899d63103b3ac1d7f54816bc
> > > > > Author: Paolo Bonzini <pbonzini@redhat.com>
> > > > > Date: Tue Jun 8 15:31:42 2021 -0400
> > > > > kvm: avoid speculation-based attacks from out-of-range memslot accesses
> > > > >
> > > > > commit da27a83fd6cc7780fea190e1f5c19e87019da65c upstream.
> > > >
> > > > Ah, so is Linus's tree also broken the same way?
> > >
> > > No.
> > > Linus's tree builds successfully.
> >
> > Odd. Paolo, did your above commit da27a83fd6cc ("kvm: avoid
> > speculation-based attacks from out-of-range memslot accesses"), require
> > any other changes to get arm32 systems to build properly?
>
> Doh, I need 4422829e8053 ("kvm: fix previous commit for 32-bit builds")
> as well...
>
> Nevermind, will go queue that up right now...
The reported build issue is fixed now.
- Naresh
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: compiler.h:417:38: error: call to '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON failed: sizeof(_i) > sizeof(long)
2021-06-14 9:39 ` Naresh Kamboju
@ 2021-06-14 9:46 ` Greg Kroah-Hartman
2021-06-14 9:56 ` Paolo Bonzini
0 siblings, 1 reply; 10+ messages in thread
From: Greg Kroah-Hartman @ 2021-06-14 9:46 UTC (permalink / raw)
To: Naresh Kamboju; +Cc: Paolo Bonzini, Sasha Levin, linux-stable, lkft-triage
On Mon, Jun 14, 2021 at 03:09:47PM +0530, Naresh Kamboju wrote:
> On Mon, 14 Jun 2021 at 14:10, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Mon, Jun 14, 2021 at 10:36:14AM +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Jun 14, 2021 at 11:54:40AM +0530, Naresh Kamboju wrote:
> > > > On Mon, 14 Jun 2021 at 10:48, Greg Kroah-Hartman
> > > > <gregkh@linuxfoundation.org> wrote:
> > > > >
> > > > > On Mon, Jun 14, 2021 at 10:24:23AM +0530, Naresh Kamboju wrote:
> > > > > > On Sun, 13 Jun 2021 at 20:35, Greg Kroah-Hartman
> > > > > > <gregkh@linuxfoundation.org> wrote:
> > > > > > >
> > > > > > > On Sun, Jun 13, 2021 at 08:25:19PM +0530, Naresh Kamboju wrote:
> > > > > > > > The following error was noticed on stable-rc 5.12, 5.10, 5.4, 4.19,
> > > > > > > > 4.14, 4.9 and 4.4
> > > > > > > > for i386 and arm.
> > > > > > > >
> > > > > > > > make --silent --keep-going --jobs=8
> > > > > > > > O=/home/tuxbuild/.cache/tuxmake/builds/current ARCH=arm
> > > > > > > > CROSS_COMPILE=arm-linux-gnueabihf- 'CC=sccache
> > > > > > > > arm-linux-gnueabihf-gcc' 'HOSTCC=sccache gcc'
> > > > > > > > In file included from /builds/linux/include/linux/kernel.h:11,
> > > > > > > > from /builds/linux/include/linux/list.h:9,
> > > > > > > > from /builds/linux/include/linux/preempt.h:11,
> > > > > > > > from /builds/linux/include/linux/hardirq.h:5,
> > > > > > > > from /builds/linux/include/linux/kvm_host.h:7,
> > > > > > > > from
> > > > > > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:18:
> > > > > > > > In function '__gfn_to_hva_memslot',
> > > > > > > > inlined from '__gfn_to_hva_many.part.6' at
> > > > > > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1446:9,
> > > > > > > > inlined from '__gfn_to_hva_many' at
> > > > > > > > /builds/linux/arch/arm/kvm/../../../virt/kvm/kvm_main.c:1434:22:
> > > > > > > > /builds/linux/include/linux/compiler.h:417:38: error: call to
> > > > > > > > '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON
> > > > > > > > failed: sizeof(_i) > sizeof(long)
> > > > > > > > _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > > > > > > > ^
> > > > > > > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > > > > > > >
> > > > > > > > ref:
> > > > > > > > https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc/-/jobs/1342604370#L389
> > > > > > >
> > > > > > > Odd. Does Linus's tree have this problem?
> > > > > > >
> > > > > > > The only arm changes was in arch/arm/include/asm/cpuidle.h in the tree
> > > > > > > right now. There are some kvm changes, but they are tiny...
> > > > > > >
> > > > > > > Can you bisect this?
> > > > > >
> > > > > > The bisect script pointing to,
> > > > > >
> > > > > > commit 1aa1b47db53e0a66899d63103b3ac1d7f54816bc
> > > > > > Author: Paolo Bonzini <pbonzini@redhat.com>
> > > > > > Date: Tue Jun 8 15:31:42 2021 -0400
> > > > > > kvm: avoid speculation-based attacks from out-of-range memslot accesses
> > > > > >
> > > > > > commit da27a83fd6cc7780fea190e1f5c19e87019da65c upstream.
> > > > >
> > > > > Ah, so is Linus's tree also broken the same way?
> > > >
> > > > No.
> > > > Linus's tree builds successfully.
> > >
> > > Odd. Paolo, did your above commit da27a83fd6cc ("kvm: avoid
> > > speculation-based attacks from out-of-range memslot accesses"), require
> > > any other changes to get arm32 systems to build properly?
> >
> > Doh, I need 4422829e8053 ("kvm: fix previous commit for 32-bit builds")
> > as well...
> >
> > Nevermind, will go queue that up right now...
>
>
> The reported build issue is fixed now.
Wonderful, thanks for checking and letting me know.
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: compiler.h:417:38: error: call to '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON failed: sizeof(_i) > sizeof(long)
2021-06-14 9:46 ` Greg Kroah-Hartman
@ 2021-06-14 9:56 ` Paolo Bonzini
0 siblings, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2021-06-14 9:56 UTC (permalink / raw)
To: Greg Kroah-Hartman, Naresh Kamboju; +Cc: Sasha Levin, linux-stable, lkft-triage
On 14/06/21 11:46, Greg Kroah-Hartman wrote:
>>> Doh, I need 4422829e8053 ("kvm: fix previous commit for 32-bit builds")
>>> as well...
>>>
>>> Nevermind, will go queue that up right now...
>>
>> The reported build issue is fixed now.
> Wonderful, thanks for checking and letting me know.
Sorry for forgetting the Cc: stable and Fixes: tag. This one is 101% on
me...
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-06-14 9:56 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-13 14:55 compiler.h:417:38: error: call to '__compiletime_assert_59' declared with attribute error: BUILD_BUG_ON failed: sizeof(_i) > sizeof(long) Naresh Kamboju
2021-06-13 15:05 ` Greg Kroah-Hartman
2021-06-14 4:54 ` Naresh Kamboju
2021-06-14 5:18 ` Greg Kroah-Hartman
2021-06-14 6:24 ` Naresh Kamboju
2021-06-14 8:36 ` Greg Kroah-Hartman
2021-06-14 8:40 ` Greg Kroah-Hartman
2021-06-14 9:39 ` Naresh Kamboju
2021-06-14 9:46 ` Greg Kroah-Hartman
2021-06-14 9:56 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.