Re: [net-next: PATCH 2/3] net: mvpp2: enable using phylink with ACPI

From: Andrew Lunn <andrew@lunn.ch>
To: Marcin Wojtas <mw@semihalf.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev <netdev@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Russell King - ARM Linux <linux@armlinux.org.uk>,
	Grzegorz Jaszczyk <jaz@semihalf.com>,
	Grzegorz Bernacki <gjb@semihalf.com>,
	upstream@semihalf.com,
	Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
	Jon Nettleton <jon@solid-run.com>
Subject: Re: [net-next: PATCH 2/3] net: mvpp2: enable using phylink with ACPI
Date: Sun, 13 Jun 2021 23:35:15 +0200	[thread overview]
Message-ID: <YMZ6E99Q/zuFh4b1@lunn.ch> (raw)
In-Reply-To: <CAPv3WKfWqdpntPKknZ+H+sscyH9mursvCUwe8Q1DH-wGpsWknQ@mail.gmail.com>

> True. I picked the port type properties that are interpreted by
> phylink. Basically, I think that everything that's described in:
> devicetree/bindings/net/ethernet-controller.yaml
> is valid for the ACPI as well

So you are saying ACPI is just DT stuff into tables? Then why bother
with ACPI? Just use DT.

Right, O.K. Please document anything which phylink already supports:

hylink.c:		ret = fwnode_property_read_u32(fixed_node, "speed", &speed);
phylink.c:		if (fwnode_property_read_bool(fixed_node, "full-duplex"))
phylink.c:		if (fwnode_property_read_bool(fixed_node, "pause"))
phylink.c:		if (fwnode_property_read_bool(fixed_node, "asym-pause"))
phylink.c:		ret = fwnode_property_read_u32_array(fwnode, "fixed-link",
phylink.c:		ret = fwnode_property_read_u32_array(fwnode, "fixed-link",
phylink.c:	if (dn || fwnode_property_present(fwnode, "fixed-link"))
phylink.c:	if ((fwnode_property_read_string(fwnode, "managed", &managed) == 0 &&

If you are adding new properties, please do that In a separate patch,
which needs an ACPI maintainer to ACK it before it gets merged.

	 Andrew