From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34699C48BE6 for ; Mon, 14 Jun 2021 05:55:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1736C6128B for ; Mon, 14 Jun 2021 05:55:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232122AbhFNF5G (ORCPT ); Mon, 14 Jun 2021 01:57:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229696AbhFNF5E (ORCPT ); Mon, 14 Jun 2021 01:57:04 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91A1CC061574; Sun, 13 Jun 2021 22:55:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=b/VCSDcG/G4Bq3256bAnQ0T8CHGeUw7BS7HwOPKZqNA=; b=fdwZ7BbveuLg6fX6xzT/z1xouy 3xIcnoIl42lxCSDd5DwN8keMLIL+TEwjMSy4wNISHDRM4e8sVoSwZmLSfyX9o9IBKpJI/pxcCw/Ph R2/rKIAy1dOlmeDn1hrMX/GgO7SYdNN0nJr5AHZ/5z0wEb2+/t0BiMmEo3AIOckXxugYtwWFN5VTS H6g1tybNCVwbf8474hP0Zsxjfh8DjzJ+9qgZ/e9JNPDU8M9rd1aOshKGJtKzb+lxGwkuBvRwKFCE/ q0jRVLOxaqxo32gRf+FFf/C3gsOnj3bkVw6aegeOPvB5LDNc3z9QjbcZO4OvvrXwOCLgUJTl/nQzR +k0R9f7w==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lsfYP-0054DF-2q; Mon, 14 Jun 2021 05:54:41 +0000 Date: Mon, 14 Jun 2021 06:54:33 +0100 From: Christoph Hellwig To: Dongdong Liu Cc: helgaas@kernel.org, hch@infradead.org, kw@linux.com, linux-pci@vger.kernel.org, rajur@chelsio.com, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [RESEND PATCH V3 4/6] PCI: Enable 10-Bit tag support for PCIe Endpoint devices Message-ID: References: <1623576555-40338-1-git-send-email-liudongdong3@huawei.com> <1623576555-40338-5-git-send-email-liudongdong3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623576555-40338-5-git-send-email-liudongdong3@huawei.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Jun 13, 2021 at 05:29:13PM +0800, Dongdong Liu wrote: > +static void pci_configure_10bit_tags(struct pci_dev *dev) > +{ > + struct pci_dev *bridge; > + > + if (!pci_is_pcie(dev)) > + return; > + > + if (!(dev->pcie_devcap2 & PCI_EXP_DEVCAP2_10BIT_TAG_COMP)) > + return; Doesn't the second check imply the first one? Otherwise looks good: Reviewed-by: Christoph Hellwig