From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04778C48BE6 for ; Mon, 14 Jun 2021 14:29:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CAF2A611C0 for ; Mon, 14 Jun 2021 14:29:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232994AbhFNOcB (ORCPT ); Mon, 14 Jun 2021 10:32:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232978AbhFNOcA (ORCPT ); Mon, 14 Jun 2021 10:32:00 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79CC2C061574; Mon, 14 Jun 2021 07:29:57 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 924CBA59; Mon, 14 Jun 2021 16:29:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1623680993; bh=ItYUbNE1wkEmOLKTUmXApXsK2mUUF//5SSNCNuwzBbE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Qiqu8Wbe4qwcsIr7AZp7ivE6vXi5FF1di15cbmWxutpYnHjDHn9PLEahEFahvRxsB dtcDhCltP+S4pw1BsHPz+fuyO/8iuDpLEDSb1/tPzTHmJUxUtP5AMByDes771T3AB+ nncT0Z83XXXsXAXyOWMAoge6Ld5KjQX6UQLpWwEk= Date: Mon, 14 Jun 2021 17:29:33 +0300 From: Laurent Pinchart To: Biju Das Cc: Geert Uytterhoeven , Vinod Koul , Rob Herring , Chris Brandt , dmaengine , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Chris Paterson , Prabhakar Mahadev Lad , Linux-Renesas Subject: Re: [PATCH 1/5] dt-bindings: dma: Document RZ/G2L bindings Message-ID: References: <20210611113642.18457-1-biju.das.jz@bp.renesas.com> <20210611113642.18457-2-biju.das.jz@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Mon, Jun 14, 2021 at 12:54:02PM +0000, Biju Das wrote: > > -----Original Message----- > > Subject: Re: [PATCH 1/5] dt-bindings: dma: Document RZ/G2L bindings > > > > Hi Biju, > > > > On Fri, Jun 11, 2021 at 1:36 PM Biju Das > > wrote: > > > Document RZ/G2L DMAC bindings. > > > > > > Signed-off-by: Biju Das > > > Reviewed-by: Lad Prabhakar > > > > Thanks for your patch! > > > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/dma/renesas,rz-dmac.yaml > > > @@ -0,0 +1,132 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > > +--- > > > +$id: > > > +https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fschemas%2Fdma%2Frenesas%2Crz-dmac.yaml%23&data=04%7C > > > +01%7Cbiju.das.jz%40bp.renesas.com%7C4b547e10cbe64b6f4d8508d92f2da0c0% > > > +7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C637592695286846809%7CUnk > > > +nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW > > > +wiLCJXVCI6Mn0%3D%7C1000&sdata=5Jh%2FxPaia5ZOY0CrViQCcrNtzuDejp8wo > > > +Nrx9iO0ht8%3D&reserved=0 > > > +$schema: > > > +https://jpn01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=04%7C01%7Cbiju.das. > > > +jz%40bp.renesas.com%7C4b547e10cbe64b6f4d8508d92f2da0c0%7C53d82571da19 > > > +47e49cb4625a166a4a2a%7C0%7C0%7C637592695286846809%7CUnknown%7CTWFpbGZ > > > +sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0% > > > +3D%7C1000&sdata=5qQ1PljM3e4Bn4%2FjdldYUHRBQL3jArJgRIAdLnhJraw%3D& > > > +amp;reserved=0 *sigh* > > > + > > > +title: Renesas RZ/G2L DMA Controller > > > + > > > +maintainers: > > > + - Biju Das > > > + > > > +allOf: > > > + - $ref: "dma-controller.yaml#" > > > + > > > +properties: > > > + compatible: > > > + items: > > > + - enum: > > > + - renesas,dmac-r9a07g044 # RZ/G2{L,LC} > > > > Please use "renesas,r9a07g044-dmac". > > OK. Will change. > > > > + - const: renesas,rz-dmac > > > > Does this need many changes for RZ/A1H and RZ/A2M? > > It will work on both RZ/A1H and RZ/A2M. I have n't tested since I don't have the board. > There is some difference in MID bit size. Other wise both identical. > > > > > + renesas,rz-dmac-slavecfg: > > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > > + description: | > > > + DMA configuration for a slave channel. Each channel must have an > > array of > > > + 3 items as below. > > > + first item in the array is MID+RID > > > > Already in dmas. > > > > > + second item in the array is slave src or dst address > > > > As pointed out by Rob, already known by the slave driver. > > > > > + third item in the array is channel configuration value. > > > > What exactly is this? What would prevent the DMA client from passing the configuration to the DMA channel through the DMA engine API, just like it passes the slave source or destination address ? > > Does the R-Car DMAC have this too? If yes, how does its driver handle it? > > On R-CAR DMAC, we have only MID + RID values. Where as here we have channel configuration value With different set of parameter as mentioned in Table 16.4. > > Please see Page 569, Table 16.4 On-Chip Module requests section. > > For eg:- as per Rob's suggestion, I have modelled the driver with the below entries in ALSA driver for playback/record use case. > > dmas = <&dmac 0x255 0x10049c18 CH_CFG(0x1,0x0,0x1,0x0,0x2,0x1,0x1,0x0)>, > <&dmac 0x256 0x10049c1c CH_CFG(0x0,0x0,0x1,0x0,0x2,0x1,0x1,0x0)>; > dma-names = "tx", "rx"; > > Using first parameter, it gets dmac channel. using second and third parameter it configures > the channel. -- Regards, Laurent Pinchart