From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A68C9C49EA2 for ; Mon, 14 Jun 2021 15:09:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6129661352 for ; Mon, 14 Jun 2021 15:09:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6129661352 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lsoDc-0007VR-FP for qemu-devel@archiver.kernel.org; Mon, 14 Jun 2021 11:09:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsoCz-0006nT-AU for qemu-devel@nongnu.org; Mon, 14 Jun 2021 11:09:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39069) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lsoCv-0007tl-VQ for qemu-devel@nongnu.org; Mon, 14 Jun 2021 11:08:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623683336; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Jn/QeKPYi6P2h0qUOz7cwC92ZjKP4Y4GsrPkC3rjdjk=; b=VVvvUbE7E98HIBGmh3YqxSudS0pOiK6TzFTTIwV70zqIt054W+AXuHeO4bA0Q1Ktg8kXOZ 2eJ4W+dO2GEIz4IYeitU8mtNd7jaEfipWKyJtBW6nZsrOii+fsiC9Cs6W7fZecJTbnz8TR ZWT9fl0Wg6BkVt4Efy7GHJvACNjSYOg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-531-jzcBuw0LMM2cg3CYezDvdg-1; Mon, 14 Jun 2021 11:08:53 -0400 X-MC-Unique: jzcBuw0LMM2cg3CYezDvdg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 20747CC623 for ; Mon, 14 Jun 2021 15:08:52 +0000 (UTC) Received: from redhat.com (ovpn-115-55.ams2.redhat.com [10.36.115.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 36E921002D71; Mon, 14 Jun 2021 15:08:47 +0000 (UTC) Date: Mon, 14 Jun 2021 16:08:45 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Gerd Hoffmann Subject: Re: [PATCH v2 03/18] modules: add qemu-modinfo utility Message-ID: References: <20210610055755.538119-1-kraxel@redhat.com> <20210610055755.538119-4-kraxel@redhat.com> <20210610130424.fj6fsufnunccmhmx@sirius.home.kraxel.org> <1636b96e-9073-b145-3fcc-3370fa2d7506@redhat.com> <20210614150159.6ilpce4dqxi7rju4@sirius.home.kraxel.org> MIME-Version: 1.0 In-Reply-To: <20210614150159.6ilpce4dqxi7rju4@sirius.home.kraxel.org> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.2, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Paolo Bonzini , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Jun 14, 2021 at 05:01:59PM +0200, Gerd Hoffmann wrote: > Hi, > > > > softmmu_mods and block_mods are both lists already, so this sets a > > > nested list and I wonder if it confuses meson ? eg do you need > > > > > > input: softmmu_mods + block_mods > > > > No, that should be fine. Perhaps it's because the inputs are not part of > > the command? You can check what the build.ninja rule for modinfo.json looks > > like. > > > > Also: > > > > - it would be better to support both directories and file names, so that > > stale modules are not included in modinfo.json > > When turning qemu-modinfo into a pure build-utility (see below) there is > no reason to not explicitly list all module files on the command line. > > > - modinfo.json needs to be disabled on non-ELF platforms (x86, Windows). > > On windows modules are not supported. Does anyone recall why modules aren't supported on Windows > Do we have any other non-ELF platforms? macOS uses dynlib IIUC ? > Problem with that approach is that it doesn't work for module > dependencies ... > > Comments on the idea? Suggestions for the module dependency problem? > Could maybe libbfd be used to find module (symbol) dependencies > automatically without writing a full dynamic linker? Is there any value in exploring use of libclang ? It gives us a real C parser that we can use to extract information from the C source. In libvirt we have experimental patches (not yet merged) using libclang to auto-generate XML parser helpers from struct annotations. It is quite nice compared to any other hacks for extracting information from C source files without using a proper parser. libclang can be accessed from Python3 via its bindings and IIUC should be usable on all our build platforms Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|