From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CFD8C2B9F4 for ; Mon, 14 Jun 2021 15:22:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C343613DB for ; Mon, 14 Jun 2021 15:22:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233518AbhFNPYR (ORCPT ); Mon, 14 Jun 2021 11:24:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233387AbhFNPYP (ORCPT ); Mon, 14 Jun 2021 11:24:15 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBC43C061574; Mon, 14 Jun 2021 08:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j1qkA0UBRXmvTXxhVjG/l5z+lefptA704EV3PoN5jFk=; b=IFif+/oeJCeFESO9YTRGsltVL2 i3QUP5oCRIxlWMygISDjFMuE7BECa725GGCbCMX2+ArTR+SbiNGEX3Fd3KXX+/FEvGSynNSlnUZWi UAtIWYj5vLgnhfCCf39nZn8Fz4X1MI5JTGJ/5RsHGA3k33v3w7y9+rmUpJGYFlzknIjntDhrT26Bt WUx0rCPE4MyDFJaC+CoeX1cSkFkLfRQYbsBWLucbgEL2UAmouFyaffB0/ueYb2AtEZKX6aV9hR8aD /5V3sdwAWzxIsTUjLw1XJh6Ofwdp8r1jnrETyXKkqlwToPgIloSXHB4/tPU6yMG5PW9Rt+u3wJ9fz LANxu78g==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lsoP5-005YXM-9W; Mon, 14 Jun 2021 15:21:45 +0000 Date: Mon, 14 Jun 2021 16:21:31 +0100 From: Christoph Hellwig To: Claudio Imbrenda Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, frankja@linux.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, david@redhat.com, linux-mm@kvack.org, Uladzislau Rezki , Nicholas Piggin , Andrew Morton , Catalin Marinas , Thomas Gleixner , Ingo Molnar , David Rientjes , Christoph Hellwig Subject: Re: [PATCH v4 1/2] mm/vmalloc: add vmalloc_no_huge Message-ID: References: <20210614132357.10202-1-imbrenda@linux.ibm.com> <20210614132357.10202-2-imbrenda@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614132357.10202-2-imbrenda@linux.ibm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2021 at 03:23:56PM +0200, Claudio Imbrenda wrote: > +void *vmalloc_no_huge(unsigned long size) > +{ > + return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, GFP_KERNEL, PAGE_KERNEL, > + VM_NO_HUGE_VMAP, NUMA_NO_NODE, __builtin_return_address(0)); Please avoid the overly long lines in favor of something actually human-readable like: return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, GFP_KERNEL, PAGE_KERNEL, VM_NO_HUGE_VMAP, NUMA_NO_NODE, __builtin_return_address(0));