Re: [PATCH 05/14] arm64: dts: renesas: Add Renesas R8A779M1 SoC support

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 05/14] arm64: dts: renesas: Add Renesas R8A779M1 SoC support
Date: Mon, 14 Jun 2021 21:43:27 +0300	[thread overview]
Message-ID: <YMejT7rXT8fp/rR1@pendragon.ideasonboard.com> (raw)
In-Reply-To: <96a1cfd2e8d86e10364fa330c6053b5136e82939.1623315732.git.geert+renesas@glider.be>

Hi Geert,

Thank you for the patch.

On Thu, Jun 10, 2021 at 11:37:18AM +0200, Geert Uytterhoeven wrote:
> Add support for the Renesas R-Car H3e-2G (R8A779M1) SoC, which is a
> different grading of the R-Car H3 ES3.0 (R8A77951) SoC.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/arm64/boot/dts/renesas/r8a779m1.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/renesas/r8a779m1.dtsi
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a779m1.dtsi b/arch/arm64/boot/dts/renesas/r8a779m1.dtsi
> new file mode 100644
> index 0000000000000000..0e9b04469b83c661
> --- /dev/null
> +++ b/arch/arm64/boot/dts/renesas/r8a779m1.dtsi
> @@ -0,0 +1,12 @@
> +// SPDX-License-Identifier: (GPL-2.0 or MIT)
> +/*
> + * Device Tree Source for the R-Car H3e-2G (R8A779M1) SoC
> + *
> + * Copyright (C) 2021 Glider bv
> + */
> +
> +#include "r8a77951.dtsi"
> +
> +/ {
> +	compatible = "renesas,r8a779m1", "renesas,r8a7795";

As commented in a separate patch this will be overridden by the .dts
that includes this file, so we could drop it altogether. I don't care
much though.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

The same applies to 06/14.

> +};

-- 
Regards,

Laurent Pinchart