* [PATCH V2] blk-mq: update hctx->dispatch_busy in case of real scheduler
@ 2021-06-04 0:09 Ming Lei
2021-06-14 21:56 ` Ming Lei
0 siblings, 1 reply; 2+ messages in thread
From: Ming Lei @ 2021-06-04 0:09 UTC (permalink / raw)
To: Jens Axboe, Christoph Hellwig; +Cc: linux-block, Ming Lei, Jan Kara
Commit 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io")
starts to support io batching submission by using hctx->dispatch_busy.
However, blk_mq_update_dispatch_busy() isn't changed to update hctx->dispatch_busy
in that commit, so fix the issue by updating hctx->dispatch_busy in case
of real scheduler.
Reported-by: Jan Kara <jack@suse.cz>
Reviewed-by: Jan Kara <jack@suse.cz>
Fixes: 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-mq.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 4261adee9964..5af4f099cdb0 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -1224,9 +1224,6 @@ static void blk_mq_update_dispatch_busy(struct blk_mq_hw_ctx *hctx, bool busy)
{
unsigned int ewma;
- if (hctx->queue->elevator)
- return;
-
ewma = hctx->dispatch_busy;
if (!ewma && !busy)
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] blk-mq: update hctx->dispatch_busy in case of real scheduler
2021-06-04 0:09 [PATCH V2] blk-mq: update hctx->dispatch_busy in case of real scheduler Ming Lei
@ 2021-06-14 21:56 ` Ming Lei
0 siblings, 0 replies; 2+ messages in thread
From: Ming Lei @ 2021-06-14 21:56 UTC (permalink / raw)
To: Jens Axboe, Christoph Hellwig; +Cc: linux-block, Jan Kara
On Fri, Jun 04, 2021 at 08:09:15AM +0800, Ming Lei wrote:
> Commit 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io")
> starts to support io batching submission by using hctx->dispatch_busy.
>
> However, blk_mq_update_dispatch_busy() isn't changed to update hctx->dispatch_busy
> in that commit, so fix the issue by updating hctx->dispatch_busy in case
> of real scheduler.
>
> Reported-by: Jan Kara <jack@suse.cz>
> Reviewed-by: Jan Kara <jack@suse.cz>
> Fixes: 6e6fcbc27e77 ("blk-mq: support batching dispatch in case of io")
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
Hello Jens,
Can you merge this patch if you are fine?
thanks,
Ming
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-14 21:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 0:09 [PATCH V2] blk-mq: update hctx->dispatch_busy in case of real scheduler Ming Lei
2021-06-14 21:56 ` Ming Lei
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.