All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Jason Gunthorpe <jgg@nvidia.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Kirti Wankhede <kwankhede@nvidia.com>,
	David Airlie <airlied@linux.ie>,
	Tony Krowiak <akrowiak@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Cornelia Huck <cohuck@redhat.com>,
	Jonathan Corbet <corbet@lwn.net>, Daniel Vetter <daniel@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	Vasily Gorbik <gor@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	intel-gfx@lists.freedesktop.org,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Jason Herne <jjherne@linux.ibm.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	kvm@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-s390@vger.kernel.org, Halil Pasic <pasic@linux.ibm.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind
Date: Tue, 15 Jun 2021 07:18:15 +0200	[thread overview]
Message-ID: <YMg4F99j2nsjGxAz@kroah.com> (raw)
In-Reply-To: <20210614150846.4111871-4-hch@lst.de>

On Mon, Jun 14, 2021 at 05:08:39PM +0200, Christoph Hellwig wrote:
> Currently really_probe() returns 1 on success and 0 if the probe() call
> fails. This return code arrangement is designed to be useful for
> __device_attach_driver() which is walking the device list and trying every
> driver. 0 means to keep trying.
> 
> However, it is not useful for the other places that call through to
> really_probe() that do actually want to see the probe() return code.
> 
> For instance bind_store() would be better to return the actual error code
> from the driver's probe method, not discarding it and returning -ENODEV.
> 
> Reorganize things so that really_probe() returns the error code from
> ->probe as a (inverted) positive number, and 0 for successful attach.
> 
> With this, __device_attach_driver can ignore the (positive) probe errors,
> return 1 to exit the loop for a successful binding and pass on the
> other negative errors, while device_driver_attach simplify inverts the
> positive errors and returns all errors to the sysfs code.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/base/bus.c |  6 +-----
>  drivers/base/dd.c  | 29 ++++++++++++++++++++---------
>  2 files changed, 21 insertions(+), 14 deletions(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	Kirti Wankhede <kwankhede@nvidia.com>,
	linux-s390@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Jason Gunthorpe <jgg@nvidia.com>,
	intel-gfx@lists.freedesktop.org,
	Jason Herne <jjherne@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Tony Krowiak <akrowiak@linux.ibm.com>,
	Cornelia Huck <cohuck@redhat.com>
Subject: Re: [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind
Date: Tue, 15 Jun 2021 07:18:15 +0200	[thread overview]
Message-ID: <YMg4F99j2nsjGxAz@kroah.com> (raw)
In-Reply-To: <20210614150846.4111871-4-hch@lst.de>

On Mon, Jun 14, 2021 at 05:08:39PM +0200, Christoph Hellwig wrote:
> Currently really_probe() returns 1 on success and 0 if the probe() call
> fails. This return code arrangement is designed to be useful for
> __device_attach_driver() which is walking the device list and trying every
> driver. 0 means to keep trying.
> 
> However, it is not useful for the other places that call through to
> really_probe() that do actually want to see the probe() return code.
> 
> For instance bind_store() would be better to return the actual error code
> from the driver's probe method, not discarding it and returning -ENODEV.
> 
> Reorganize things so that really_probe() returns the error code from
> ->probe as a (inverted) positive number, and 0 for successful attach.
> 
> With this, __device_attach_driver can ignore the (positive) probe errors,
> return 1 to exit the loop for a successful binding and pass on the
> other negative errors, while device_driver_attach simplify inverts the
> positive errors and returns all errors to the sysfs code.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/base/bus.c |  6 +-----
>  drivers/base/dd.c  | 29 ++++++++++++++++++++---------
>  2 files changed, 21 insertions(+), 14 deletions(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@lst.de>
Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	Kirti Wankhede <kwankhede@nvidia.com>,
	linux-s390@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Halil Pasic <pasic@linux.ibm.com>,
	Christian Borntraeger <borntraeger@de.ibm.com>,
	Jason Gunthorpe <jgg@nvidia.com>,
	intel-gfx@lists.freedesktop.org,
	Jason Herne <jjherne@linux.ibm.com>,
	Vasily Gorbik <gor@linux.ibm.com>,
	Heiko Carstens <hca@linux.ibm.com>,
	Tony Krowiak <akrowiak@linux.ibm.com>,
	Cornelia Huck <cohuck@redhat.com>
Subject: Re: [Intel-gfx] [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind
Date: Tue, 15 Jun 2021 07:18:15 +0200	[thread overview]
Message-ID: <YMg4F99j2nsjGxAz@kroah.com> (raw)
In-Reply-To: <20210614150846.4111871-4-hch@lst.de>

On Mon, Jun 14, 2021 at 05:08:39PM +0200, Christoph Hellwig wrote:
> Currently really_probe() returns 1 on success and 0 if the probe() call
> fails. This return code arrangement is designed to be useful for
> __device_attach_driver() which is walking the device list and trying every
> driver. 0 means to keep trying.
> 
> However, it is not useful for the other places that call through to
> really_probe() that do actually want to see the probe() return code.
> 
> For instance bind_store() would be better to return the actual error code
> from the driver's probe method, not discarding it and returning -ENODEV.
> 
> Reorganize things so that really_probe() returns the error code from
> ->probe as a (inverted) positive number, and 0 for successful attach.
> 
> With this, __device_attach_driver can ignore the (positive) probe errors,
> return 1 to exit the loop for a successful binding and pass on the
> other negative errors, while device_driver_attach simplify inverts the
> positive errors and returns all errors to the sysfs code.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  drivers/base/bus.c |  6 +-----
>  drivers/base/dd.c  | 29 ++++++++++++++++++++---------
>  2 files changed, 21 insertions(+), 14 deletions(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2021-06-15  5:18 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14 15:08 Allow mdev drivers to directly create the vfio_device (v2 / alternative) Christoph Hellwig
2021-06-14 15:08 ` [Intel-gfx] " Christoph Hellwig
2021-06-14 15:08 ` [PATCH 01/10] driver core: Pull required checks into driver_probe_device() Christoph Hellwig
2021-06-14 15:08   ` [Intel-gfx] " Christoph Hellwig
2021-06-15  5:16   ` Greg Kroah-Hartman
2021-06-15  5:16     ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15  5:16     ` Greg Kroah-Hartman
2021-06-15 10:27   ` Cornelia Huck
2021-06-15 10:27     ` [Intel-gfx] " Cornelia Huck
2021-06-15 10:27     ` Cornelia Huck
2021-06-14 15:08 ` [PATCH 02/10] driver core: Better distinguish probe errors in really_probe Christoph Hellwig
2021-06-14 15:08   ` [Intel-gfx] " Christoph Hellwig
2021-06-14 18:47   ` Kirti Wankhede
2021-06-14 18:47     ` [Intel-gfx] " Kirti Wankhede
2021-06-14 18:47     ` Kirti Wankhede
2021-06-15  5:17   ` Greg Kroah-Hartman
2021-06-15  5:17     ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15  5:17     ` Greg Kroah-Hartman
2021-06-15  5:48     ` Christoph Hellwig
2021-06-15  5:48       ` [Intel-gfx] " Christoph Hellwig
2021-06-14 15:08 ` [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind Christoph Hellwig
2021-06-14 15:08   ` [Intel-gfx] " Christoph Hellwig
2021-06-15  5:18   ` Greg Kroah-Hartman [this message]
2021-06-15  5:18     ` Greg Kroah-Hartman
2021-06-15  5:18     ` Greg Kroah-Hartman
2021-06-15 10:31   ` Cornelia Huck
2021-06-15 10:31     ` [Intel-gfx] " Cornelia Huck
2021-06-15 10:31     ` Cornelia Huck
2021-06-14 15:08 ` [PATCH 04/10] driver core: Don't return EPROBE_DEFER to userspace during " Christoph Hellwig
2021-06-14 15:08   ` [Intel-gfx] " Christoph Hellwig
2021-06-14 22:43   ` Jason Gunthorpe
2021-06-14 22:43     ` [Intel-gfx] " Jason Gunthorpe
2021-06-14 22:43     ` Jason Gunthorpe
2021-06-14 15:08 ` [PATCH 05/10] driver core: Export device_driver_attach() Christoph Hellwig
2021-06-14 15:08   ` [Intel-gfx] " Christoph Hellwig
2021-06-15  5:20   ` Greg Kroah-Hartman
2021-06-15  5:20     ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15  5:20     ` Greg Kroah-Hartman
2021-06-15 10:49   ` Cornelia Huck
2021-06-15 10:49     ` [Intel-gfx] " Cornelia Huck
2021-06-15 10:49     ` Cornelia Huck
2021-06-14 15:08 ` [PATCH 06/10] vfio/mdev: Remove CONFIG_VFIO_MDEV_DEVICE Christoph Hellwig
2021-06-14 15:08   ` [Intel-gfx] " Christoph Hellwig
2021-06-15 10:50   ` Cornelia Huck
2021-06-15 10:50     ` [Intel-gfx] " Cornelia Huck
2021-06-15 10:50     ` Cornelia Huck
2021-06-14 15:08 ` [PATCH 07/10] vfio/mdev: Allow the mdev_parent_ops to specify the device driver to bind Christoph Hellwig
2021-06-14 15:08   ` [Intel-gfx] " Christoph Hellwig
2021-06-15 10:54   ` Cornelia Huck
2021-06-15 10:54     ` [Intel-gfx] " Cornelia Huck
2021-06-15 10:54     ` Cornelia Huck
2021-06-14 15:08 ` [PATCH 08/10] vfio/mtty: Convert to use vfio_register_group_dev() Christoph Hellwig
2021-06-14 15:08   ` [Intel-gfx] " Christoph Hellwig
2021-06-14 15:08 ` [PATCH 09/10] vfio/mdpy: " Christoph Hellwig
2021-06-14 15:08   ` [Intel-gfx] " Christoph Hellwig
2021-06-14 15:08 ` [PATCH 10/10] vfio/mbochs: " Christoph Hellwig
2021-06-14 15:08   ` [Intel-gfx] " Christoph Hellwig
2021-06-15  0:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] driver core: Pull required checks into driver_probe_device() Patchwork
2021-06-15  0:23 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-06-15  0:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-06-15  5:21 ` Allow mdev drivers to directly create the vfio_device (v2 / alternative) Greg Kroah-Hartman
2021-06-15  5:21   ` [Intel-gfx] " Greg Kroah-Hartman
2021-06-15  5:21   ` Greg Kroah-Hartman
2021-06-15  5:50   ` Christoph Hellwig
2021-06-15  5:50     ` [Intel-gfx] " Christoph Hellwig
2021-06-15 15:27     ` Jason Gunthorpe
2021-06-15 15:27       ` [Intel-gfx] " Jason Gunthorpe
2021-06-15 15:27       ` Jason Gunthorpe
2021-06-15  9:37 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/10] driver core: Pull required checks into driver_probe_device() Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2021-06-17 14:22 Allow mdev drivers to directly create the vfio_device (v4) Christoph Hellwig
2021-06-17 14:22 ` [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind Christoph Hellwig
2021-06-15 13:35 Allow mdev drivers to directly create the vfio_device (v3) Christoph Hellwig
2021-06-15 13:35 ` [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind Christoph Hellwig
2021-06-08  0:55 [PATCH 00/10] Allow mdev drivers to directly create the vfio_device Jason Gunthorpe
2021-06-08  0:55 ` [PATCH 03/10] driver core: Flow the return code from ->probe() through to sysfs bind Jason Gunthorpe
2021-06-08  6:07   ` Christoph Hellwig
2021-06-08 23:53     ` Jason Gunthorpe
2021-06-08  6:47   ` Greg Kroah-Hartman
2021-06-08 12:30     ` Jason Gunthorpe
2021-06-08 13:16       ` Greg Kroah-Hartman
2021-06-08 14:03         ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMg4F99j2nsjGxAz@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=airlied@linux.ie \
    --cc=akrowiak@linux.ibm.com \
    --cc=alex.williamson@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=corbet@lwn.net \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=hch@lst.de \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=jgg@nvidia.com \
    --cc=jjherne@linux.ibm.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwankhede@nvidia.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=pasic@linux.ibm.com \
    --cc=rafael@kernel.org \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.