From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70B10C48BE5 for ; Tue, 15 Jun 2021 04:54:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5A535613DA for ; Tue, 15 Jun 2021 04:54:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230225AbhFOE4j (ORCPT ); Tue, 15 Jun 2021 00:56:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:48204 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229968AbhFOE4j (ORCPT ); Tue, 15 Jun 2021 00:56:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 867FA6140C; Tue, 15 Jun 2021 04:54:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623732875; bh=LOUrrre8qSZUzINtpnJMg/SuDS2uZEyc8OgjEuONmRs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yg5nwCP1U+2AIZi5180GqrGZxiQygtRJ39hiJbUDPGyvmygZw69Zg2trAbzxvJaVI ohi7+dGvIkj5Nwnnw0dBeDuwbp7phAthXlHvR/qHf6xNyiO4/mVRD5BfJD4cq0wOye d6V8wqcKpNDTZ+xeL/WoWA3a/tKE50UA06NbrVt0= Date: Tue, 15 Jun 2021 06:54:32 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v3 4/4] remoteproc: core: Cleanup device in case of failure Message-ID: References: <1623723671-5517-1-git-send-email-sidgup@codeaurora.org> <1623723671-5517-5-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623723671-5517-5-git-send-email-sidgup@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Mon, Jun 14, 2021 at 07:21:11PM -0700, Siddharth Gupta wrote: > When a failure occurs in rproc_add() it returns an error, but does > not cleanup after itself. This change adds the failure path in such > cases. > > Signed-off-by: Siddharth Gupta > --- > drivers/remoteproc/remoteproc_core.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55D36C48BDF for ; Tue, 15 Jun 2021 19:18:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 106056109D for ; Tue, 15 Jun 2021 19:18:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 106056109D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yWnBRorNkAi3ivAbHpPHJuuSfmgOEfwj8UAQAVDGAmQ=; b=dbo07/G97cH+IV zUpYFdL1B61xBf36/A+HiVV3iRSq+6D7RnDV4vqIoiXfq7xhtupk6VCK1556vHPa2OMiWd4t24IDY KBu2Go12LJFKgx/DQis1dTY+iJbl74Z8ikqz6zXIRV8q8S8Xiioq+yT0tYWobIuInCRHuSK/0sCbw q5cjEdoxbLSR2Gv9+67waxXsw7uje0W+uOxGsF+7YFcBciSaeuYUJ7vCJXf88GlZNAZub+YnTw73P KO5ZkTLSbNEGoh+Kd2KoSq9p0BdveAn+VGenmBlXuQ2aSh4X+1n9j0Lw1RAtD0b/1JBEJg+yEqONd qF5sIcDJmGZm/gNTlSRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltEXU-002Mut-D7; Tue, 15 Jun 2021 19:15:57 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt9N0-000DwX-ET for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Jun 2021 13:44:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jyitj0+zV5WdH/BytNjtp9ybCIUa4wlXrPD9vBCS20o=; b=GJFolhd2brS/wuT/rQFAkQrZt0 OUc/2yC9AHsppmv2UXgYOqMRbORRZ3r53azgxzB8pKcDhIeAUq268Wz6QBwR6PyfiwDjrCEw914n4 iQ2wNv+QpxIoBsAUQQ8SUdDZaQQBZX7aqf4awXMSuUSOrVuoOE+ht4JO4Jx1yx7wnRQ9ZJ8s0DkRR LX7LJ+bjunkg51zGgn+uj5K3pXnUcGTL+rdjvjJVl9QAXJvAkYdzlHZqrIafvnF2u7cO8/tB/09Lp pDn0EZe9QHEP4zHZQCVF7AU+cNoG8XgpaV6HQ29FYFUvJ184AsrB3IjhrhCwERY9bt/3FnhObD+TE D4/9JeEw==; Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt15p-007Ld1-UY for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 04:54:38 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 867FA6140C; Tue, 15 Jun 2021 04:54:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623732875; bh=LOUrrre8qSZUzINtpnJMg/SuDS2uZEyc8OgjEuONmRs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yg5nwCP1U+2AIZi5180GqrGZxiQygtRJ39hiJbUDPGyvmygZw69Zg2trAbzxvJaVI ohi7+dGvIkj5Nwnnw0dBeDuwbp7phAthXlHvR/qHf6xNyiO4/mVRD5BfJD4cq0wOye d6V8wqcKpNDTZ+xeL/WoWA3a/tKE50UA06NbrVt0= Date: Tue, 15 Jun 2021 06:54:32 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v3 4/4] remoteproc: core: Cleanup device in case of failure Message-ID: References: <1623723671-5517-1-git-send-email-sidgup@codeaurora.org> <1623723671-5517-5-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1623723671-5517-5-git-send-email-sidgup@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_055437_069157_FD35F930 X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 14, 2021 at 07:21:11PM -0700, Siddharth Gupta wrote: > When a failure occurs in rproc_add() it returns an error, but does > not cleanup after itself. This change adds the failure path in such > cases. > > Signed-off-by: Siddharth Gupta > --- > drivers/remoteproc/remoteproc_core.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel