From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EB80C48BDF for ; Tue, 15 Jun 2021 19:07:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77D41610EA for ; Tue, 15 Jun 2021 19:07:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230319AbhFOTJE (ORCPT ); Tue, 15 Jun 2021 15:09:04 -0400 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:48045 "EHLO wnew4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229749AbhFOTJD (ORCPT ); Tue, 15 Jun 2021 15:09:03 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 9D4144A4; Tue, 15 Jun 2021 15:06:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 15 Jun 2021 15:06:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=cLDd673qlTPNnbBVHeSueP8NcgB xfNN53BWwhPepOT4=; b=fTeldxXjTw/8zsV5Pq8tgRXD0siUnoi/zcSdmirNCB2 TWS5GvFvfhQIvJL4q8DxQCj06G6tSScnjsGrP5yxaZNpkGZGmt2yTZBqsJAdTE6K QtWUhpy/jqG0ho3MymjpsU30qIqoTInVx4DCczcKwopLopHJ5NAB48R1ij1duoRb 7lldwWgTuSBbLlAiYia6e/CnrK+zPM1sX25XjRBfXmd8+yYEhN6WFiVSFo3Bl4TY TCjzeomCPE8kklHY8aUYco+kOsEdPtLKxsrRKhu/wkcX2U23T4bdNm3zOMYvm1CZ xl6CODnSHAve8q0hxMdD5wbua0DRJGFDfk/5/cLjhDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=cLDd67 3qlTPNnbBVHeSueP8NcgBxfNN53BWwhPepOT4=; b=LhhZDCH90n4FOWIstm5IXE OWJdOXzDfFYVaByP38MNfC1LafowrXs4HPM+KCiDIaR/ZD4j2maMmVw3iJAjNf4S Lg4w1Ky6d8Df0NBPkk2thuXF9yx4FLV+uCamoiKYvR+nGh90viOIknQjXJQhDoQ/ 7VQOUy/Wy4hsWoR46f96QA2QJauSlL2o+7nXsuG2oe5hBeBR2WJ+4ZqZW5NbSgDg pmyxH2QkiV6j5Xu3FLawy3T4zUhPDCPLbyBYgQI8kX1Wih4xDb5GfEIUIUQBgH7v 7xpJiLxBPVcdA9vjZoTj3Tr/r6PXL8Ifn4VNPG1n2gIm6ggCFDgaETVx1Up0dn1A == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedvjedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuhe ejgfffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecuvehluhhs thgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Jun 2021 15:06:56 -0400 (EDT) Date: Tue, 15 Jun 2021 21:06:55 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v4 3/4] remoteproc: core: Fix cdev remove and rproc del Message-ID: References: <1623783824-13395-1-git-send-email-sidgup@codeaurora.org> <1623783824-13395-4-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623783824-13395-4-git-send-email-sidgup@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Tue, Jun 15, 2021 at 12:03:43PM -0700, Siddharth Gupta wrote: > The rproc_char_device_remove() call currently unmaps the cdev > region instead of simply deleting the cdev that was added as a > part of the rproc_char_device_add() call. This change fixes that > behaviour, and also fixes the order in which device_del() and > cdev_del() need to be called. > > Signed-off-by: Siddharth Gupta > Cc: stable@vger.kernel.org Is this really needed for stable? What bug does this solve? ANd again, fixes: ? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1385C48BDF for ; Tue, 15 Jun 2021 22:08:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8395A61246 for ; Tue, 15 Jun 2021 22:08:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8395A61246 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=87eVJgWQhIb0BmATMJwFnArWcH05HFoZMTaoDWjK6bA=; b=WJSgdGk4V0pBzs OnE7y/felQ8E1bYGl/10rCvhz5fg/uGTx5XAjH0SVxrt05DhZUQEhylwHwpuKDxPCg7ksa33QfEb4 B79vsltfbwKSSwj+osSZOHpgl3vmDLmHfonSkVHDHD2N/ANEcJArWlJyW2M/+BBtYMdOIwEGbPVsp GW6GnP1s9EorazBLgCVzSZs5j498llXsW/I9C8okStx5MmQNwP8+5YDPMkc58m5ALbnNKPzE91AmE njQedWNWFAzHGx9ACNisP4oNadMct1Kzf6k7rZQGIac3jAsNKZ9QWOpvmJP4h5QyUNWwa0ZSpCFaz 6ExQkbflr64j2DQEYiUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltHC7-003QHL-V1; Tue, 15 Jun 2021 22:06:04 +0000 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltEOp-002KDl-KB for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 19:07:00 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.west.internal (Postfix) with ESMTP id 9D4144A4; Tue, 15 Jun 2021 15:06:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 15 Jun 2021 15:06:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=cLDd673qlTPNnbBVHeSueP8NcgB xfNN53BWwhPepOT4=; b=fTeldxXjTw/8zsV5Pq8tgRXD0siUnoi/zcSdmirNCB2 TWS5GvFvfhQIvJL4q8DxQCj06G6tSScnjsGrP5yxaZNpkGZGmt2yTZBqsJAdTE6K QtWUhpy/jqG0ho3MymjpsU30qIqoTInVx4DCczcKwopLopHJ5NAB48R1ij1duoRb 7lldwWgTuSBbLlAiYia6e/CnrK+zPM1sX25XjRBfXmd8+yYEhN6WFiVSFo3Bl4TY TCjzeomCPE8kklHY8aUYco+kOsEdPtLKxsrRKhu/wkcX2U23T4bdNm3zOMYvm1CZ xl6CODnSHAve8q0hxMdD5wbua0DRJGFDfk/5/cLjhDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=cLDd67 3qlTPNnbBVHeSueP8NcgBxfNN53BWwhPepOT4=; b=LhhZDCH90n4FOWIstm5IXE OWJdOXzDfFYVaByP38MNfC1LafowrXs4HPM+KCiDIaR/ZD4j2maMmVw3iJAjNf4S Lg4w1Ky6d8Df0NBPkk2thuXF9yx4FLV+uCamoiKYvR+nGh90viOIknQjXJQhDoQ/ 7VQOUy/Wy4hsWoR46f96QA2QJauSlL2o+7nXsuG2oe5hBeBR2WJ+4ZqZW5NbSgDg pmyxH2QkiV6j5Xu3FLawy3T4zUhPDCPLbyBYgQI8kX1Wih4xDb5GfEIUIUQBgH7v 7xpJiLxBPVcdA9vjZoTj3Tr/r6PXL8Ifn4VNPG1n2gIm6ggCFDgaETVx1Up0dn1A == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedvjedgudeffecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuhe ejgfffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecuvehluhhs thgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Jun 2021 15:06:56 -0400 (EDT) Date: Tue, 15 Jun 2021 21:06:55 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v4 3/4] remoteproc: core: Fix cdev remove and rproc del Message-ID: References: <1623783824-13395-1-git-send-email-sidgup@codeaurora.org> <1623783824-13395-4-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1623783824-13395-4-git-send-email-sidgup@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_120659_730322_B7FCADCC X-CRM114-Status: GOOD ( 11.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 15, 2021 at 12:03:43PM -0700, Siddharth Gupta wrote: > The rproc_char_device_remove() call currently unmaps the cdev > region instead of simply deleting the cdev that was added as a > part of the rproc_char_device_add() call. This change fixes that > behaviour, and also fixes the order in which device_del() and > cdev_del() need to be called. > > Signed-off-by: Siddharth Gupta > Cc: stable@vger.kernel.org Is this really needed for stable? What bug does this solve? ANd again, fixes: ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel