From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3C80C48BE5 for ; Tue, 15 Jun 2021 17:34:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0A90611EE for ; Tue, 15 Jun 2021 17:34:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231656AbhFORgq (ORCPT ); Tue, 15 Jun 2021 13:36:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231515AbhFORf6 (ORCPT ); Tue, 15 Jun 2021 13:35:58 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B7E4C0611BE; Tue, 15 Jun 2021 10:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=scxudT0Fgrjf5dg2kq1HoLcZSqo+IAeOJSwNAM+VhfI=; b=B9Wch8bEkIKY6dWxYd/dZu00w6 LND/yDN+axubI22bh2wmeWj46Pwyy2+2jnlO7j2t1rx1zZGHy3RL22ZU/0CoZaCaoKk7bmQQ/9wKp i9yv/y5rT5KGQ+fwdLlDdRuqnlGy6Rv5DEMDptVb5wXhFHqSa3faYMrvjW/fYFcTQb7CO+A+35qQZ uq263anRm97B18VVYWIqTVc+amQQ0j9pkJPIRTQuzM5dZArRZ5TRDu+2fhMU5Sf2XYOJJh9NduuXC 1MiBSwLHvPkFgkKDBp3UofDAM4bgv78VlxzNxQ08/VlmQObpEEBE/KciOa494kxdu2hKvlKpVE6iw 6YmEC2cg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltCvV-0074fj-Qg; Tue, 15 Jun 2021 17:32:40 +0000 Date: Tue, 15 Jun 2021 18:32:37 +0100 From: Matthew Wilcox To: Greg Kroah-Hartman Cc: Christoph Hellwig , Andrew Morton , Jan Kara , Al Viro , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] iomap: Use __set_page_dirty_nobuffers Message-ID: References: <20210615162342.1669332-1-willy@infradead.org> <20210615162342.1669332-4-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 15, 2021 at 07:19:59PM +0200, Greg Kroah-Hartman wrote: > On Tue, Jun 15, 2021 at 05:23:39PM +0100, Matthew Wilcox (Oracle) wrote: > Using __ functions in structures in different modules feels odd to me. > Why not just have iomap_set_page_dirty be a #define to this function now > if you want to do this? > > Or take the __ off of the function name? > > Anyway, logic here is fine, but feels odd. heh, that was how I did it the first time. Then I thought that it was better to follow Christoph's patch: static const struct address_space_operations adfs_aops = { + .set_page_dirty = __set_page_dirty_buffers, (etc)