From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB3B3C48BE5 for ; Tue, 15 Jun 2021 21:13:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDA81613B1 for ; Tue, 15 Jun 2021 21:13:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229931AbhFOVPZ (ORCPT ); Tue, 15 Jun 2021 17:15:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230238AbhFOVPY (ORCPT ); Tue, 15 Jun 2021 17:15:24 -0400 Received: from mail-oi1-x233.google.com (mail-oi1-x233.google.com [IPv6:2607:f8b0:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 056A6C061760 for ; Tue, 15 Jun 2021 14:13:18 -0700 (PDT) Received: by mail-oi1-x233.google.com with SMTP id q10so60422oij.5 for ; Tue, 15 Jun 2021 14:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=iC6RXm/Qahte4XrMG2YsCeTJiMNyyXot3t+H7B1dbsM=; b=zS3QB/UGlGHcJmNr0eJ13Q5X3k1+c7Z8Q68ezzP8qK2P4zw+XBXczNP2iF5EGoE1es eYubnziJmblBo6ZDrBOzavH0Pu/uiHbu0fxtLExWlajRdH7EkKhIg2GKu9AHlrv9gpW8 rGk0P2IB8myCmz5g+JTlrd8RcCX+cG4tGsLOvMs1ztbgy3S/Bc+WKqywSpIIEJ95Rjy/ 5FaKy4DtFmw2fU7wrl69vPItt/VtEULyXnWys/1Aw0mpwFCwokguGgK2USWjmEehRw8z Qw8zgUcJIhLgFrksIUgJfXcivbb2ws8jNgIqyjhnhZZwpkB7K4Tvc4nmOIccFlu1QGSK iNRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=iC6RXm/Qahte4XrMG2YsCeTJiMNyyXot3t+H7B1dbsM=; b=QpqT6EZ1cBAAawulgl5yuQbHNZvvO8X8/NdnulKPVS0U1m0ChjDVMVxygRNdw/eDeG 4V+PWiliyAoMNJjmLKmKPF+hhS+aIYzZl2AZzMs7WbbHqBUkoY7EXq13Bnk7rvP/MXxt rFPCw5Ig0mMol9FYjOCP/9W9kwbqFe+tat886GkCV2WmJ5SjFUdRZzJvrJupgHnO2xP/ TYDRoKvEjbHaOMITPum1d07D0zcd0a+nWr3tzuhz8yDC1xpmF/4HiFRNWCgFI7Z3iv6G cngnBaE0EYp9QQK8QnC1RANeenxUyPkDapiNeA3XrGWqCJGO61iRcouVFtOK89kzlB7D 9/rw== X-Gm-Message-State: AOAM5327HITRM/fmT+fHxVoOKuFPCVtJ26MvgrUM1JKEXg+4f3+Qsfl1 qrTwZ6seEuSGWkBKSrQi3nZPnw== X-Google-Smtp-Source: ABdhPJxoSuVBYBOuuVUqi6aVQmEUuOpXTGRn8L8an3iW+GXJzdRaF6FqRwrIqkbTH8nEN13ZwdecMQ== X-Received: by 2002:aca:618a:: with SMTP id v132mr4568903oib.144.1623791598214; Tue, 15 Jun 2021 14:13:18 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id h8sm10847oie.41.2021.06.15.14.13.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Jun 2021 14:13:17 -0700 (PDT) Date: Tue, 15 Jun 2021 16:13:15 -0500 From: Bjorn Andersson To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Linus Walleij , Liam Girdwood , Mark Brown , Vinod Koul , Rob Herring , Andy Gross Subject: Re: [PATCH v2 10/10] arm64: dts: qcom: sa8155p-adp: Add base dts file Message-ID: References: <20210615074543.26700-1-bhupesh.sharma@linaro.org> <20210615074543.26700-11-bhupesh.sharma@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210615074543.26700-11-bhupesh.sharma@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue 15 Jun 02:45 CDT 2021, Bhupesh Sharma wrote: > Add base DTS file for SA8155p Automotive Development Platform. > It enables boot to console, adds tlmm reserved range and ufs flash. > It also includes pmic file. > > SA8155p-adp board is based on sa8155p Qualcomm Snapdragon SoC. > SA8155p platform is similar to the SM8150, so use this as base > for now. > > Cc: Linus Walleij > Cc: Liam Girdwood > Cc: Mark Brown > Cc: Bjorn Andersson > Cc: Vinod Koul > Cc: Rob Herring > Cc: Andy Gross With the feedback of regulator-allow-set-load addressed this looks good! Reviewed-by: Bjorn Andersson Regards, Bjorn > Signed-off-by: Bhupesh Sharma > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 355 +++++++++++++++++++++++ > 2 files changed, 356 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/sa8155p-adp.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index 456502aeee49..666f3528697d 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -32,6 +32,7 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-oneplus-dumpling.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb > +dtb-$(CONFIG_ARCH_QCOM) += sa8155p-adp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-idp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r1-lte.dtb > diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > new file mode 100644 > index 000000000000..95e0a6612e6b > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts > @@ -0,0 +1,355 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2021, Linaro Limited > + */ > + > +/dts-v1/; > + > +#include > +#include > +#include "sm8150.dtsi" > +#include "pmm8155au_1.dtsi" > +#include "pmm8155au_2.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. SA8155P ADP"; > + compatible = "qcom,sa8155p-adp", "qcom,sa8155p"; > + > + aliases { > + serial0 = &uart2; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + vreg_3p3: vreg_3p3_regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vreg_3p3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + /* > + * S4A is always on and not controllable through RPMh. > + * So model it as a fixed regulator. > + */ > + vreg_s4a_1p8: smps4 { > + compatible = "regulator-fixed"; > + regulator-name = "vreg_s4a_1p8"; > + > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + > + regulator-always-on; > + regulator-boot-on; > + > + vin-supply = <&vreg_3p3>; > + }; > +}; > + > +&apps_rsc { > + pmm8155au-1-rpmh-regulators { > + compatible = "qcom,pmm8155au-rpmh-regulators"; > + qcom,pmic-id = "a"; > + > + vdd-s1-supply = <&vreg_3p3>; > + vdd-s2-supply = <&vreg_3p3>; > + vdd-s3-supply = <&vreg_3p3>; > + vdd-s4-supply = <&vreg_3p3>; > + vdd-s5-supply = <&vreg_3p3>; > + vdd-s6-supply = <&vreg_3p3>; > + vdd-s7-supply = <&vreg_3p3>; > + vdd-s8-supply = <&vreg_3p3>; > + vdd-s9-supply = <&vreg_3p3>; > + vdd-s10-supply = <&vreg_3p3>; > + > + vdd-l1-l8-l11-supply = <&vreg_s6a_0p92>; > + vdd-l2-l10-supply = <&vreg_3p3>; > + vdd-l3-l4-l5-l18-supply = <&vreg_s6a_0p92>; > + vdd-l6-l9-supply = <&vreg_s6a_0p92>; > + vdd-l7-l12-l14-l15-supply = <&vreg_s5a_2p04>; > + vdd-l13-l16-l17-supply = <&vreg_3p3>; > + > + vreg_s5a_2p04: smps5 { > + regulator-name = "vreg_s5a_2p04"; > + regulator-min-microvolt = <1904000>; > + regulator-max-microvolt = <2000000>; > + }; > + > + vreg_s6a_0p92: smps6 { > + regulator-name = "vreg_s6a_0p92"; > + regulator-min-microvolt = <920000>; > + regulator-max-microvolt = <1128000>; > + }; > + > + vreg_l1a_0p752: ldo1 { > + regulator-name = "vreg_l1a_0p752"; > + regulator-min-microvolt = <752000>; > + regulator-max-microvolt = <752000>; > + regulator-initial-mode = ; > + }; > + > + vdda_usb_hs_3p1: > + vreg_l2a_3p072: ldo2 { > + regulator-name = "vreg_l2a_3p072"; > + regulator-min-microvolt = <3072000>; > + regulator-max-microvolt = <3072000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l3a_0p8: ldo3 { > + regulator-name = "vreg_l3a_0p8"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <800000>; > + regulator-initial-mode = ; > + }; > + > + vdd_usb_hs_core: > + vdda_usb_ss_dp_core_1: > + vreg_l5a_0p88: ldo5 { > + regulator-name = "vreg_l5a_0p88"; > + regulator-min-microvolt = <880000>; > + regulator-max-microvolt = <880000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l7a_1p8: ldo7 { > + regulator-name = "vreg_l7a_1p8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l10a_2p96: ldo10 { > + regulator-name = "vreg_l10a_2p96"; > + regulator-min-microvolt = <2504000>; > + regulator-max-microvolt = <2960000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l11a_0p8: ldo11 { > + regulator-name = "vreg_l11a_0p8"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <800000>; > + regulator-initial-mode = ; > + }; > + > + vdda_usb_hs_1p8: > + vreg_l12a_1p8: ldo12 { > + regulator-name = "vreg_l12a_1p8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l13a_2p7: ldo13 { > + regulator-name = "vreg_l13a_2p7"; > + regulator-min-microvolt = <2704000>; > + regulator-max-microvolt = <2704000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l15a_1p7: ldo15 { > + regulator-name = "vreg_l15a_1p7"; > + regulator-min-microvolt = <1704000>; > + regulator-max-microvolt = <1704000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l16a_2p7: ldo16 { > + regulator-name = "vreg_l16a_2p7"; > + regulator-min-microvolt = <2704000>; > + regulator-max-microvolt = <2960000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l17a_2p96: ldo17 { > + regulator-name = "vreg_l17a_2p96"; > + regulator-min-microvolt = <2504000>; > + regulator-max-microvolt = <2960000>; > + regulator-initial-mode = ; > + }; > + }; > + > + pmm8155au-2-rpmh-regulators { > + compatible = "qcom,pmm8155au-rpmh-regulators"; > + qcom,pmic-id = "c"; > + > + vdd-s1-supply = <&vreg_3p3>; > + vdd-s2-supply = <&vreg_3p3>; > + vdd-s3-supply = <&vreg_3p3>; > + vdd-s4-supply = <&vreg_3p3>; > + vdd-s5-supply = <&vreg_3p3>; > + vdd-s6-supply = <&vreg_3p3>; > + vdd-s7-supply = <&vreg_3p3>; > + vdd-s8-supply = <&vreg_3p3>; > + vdd-s9-supply = <&vreg_3p3>; > + vdd-s10-supply = <&vreg_3p3>; > + > + vdd-l1-l8-l11-supply = <&vreg_s4c_1p352>; > + vdd-l2-l10-supply = <&vreg_3p3>; > + vdd-l3-l4-l5-l18-supply = <&vreg_s4c_1p352>; > + vdd-l6-l9-supply = <&vreg_s6c_1p128>; > + vdd-l7-l12-l14-l15-supply = <&vreg_s5c_2p04>; > + vdd-l13-l16-l17-supply = <&vreg_3p3>; > + > + vreg_s4c_1p352: smps4 { > + regulator-name = "vreg_s4c_1p352"; > + regulator-min-microvolt = <1352000>; > + regulator-max-microvolt = <1352000>; > + }; > + > + vreg_s5c_2p04: smps5 { > + regulator-name = "vreg_s5c_2p04"; > + regulator-min-microvolt = <1904000>; > + regulator-max-microvolt = <2000000>; > + }; > + > + vreg_s6c_1p128: smps6 { > + regulator-name = "vreg_s6c_1p128"; > + regulator-min-microvolt = <1128000>; > + regulator-max-microvolt = <1128000>; > + }; > + > + vreg_l1c_1p304: ldo1 { > + regulator-name = "vreg_l1c_1p304"; > + regulator-min-microvolt = <1304000>; > + regulator-max-microvolt = <1304000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l2c_1p808: ldo2 { > + regulator-name = "vreg_l2c_1p808"; > + regulator-min-microvolt = <1704000>; > + regulator-max-microvolt = <2928000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l5c_1p2: ldo5 { > + regulator-name = "vreg_l5c_1p2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l7c_1p8: ldo7 { > + regulator-name = "vreg_l7c_1p8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l8c_1p2: ldo8 { > + regulator-name = "vreg_l8c_1p2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l10c_3p3: ldo10 { > + regulator-name = "vreg_l10c_3p3"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3312000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l11c_0p8: ldo11 { > + regulator-name = "vreg_l11c_0p8"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <800000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l12c_1p808: ldo12 { > + regulator-name = "vreg_l12c_1p808"; > + regulator-min-microvolt = <1704000>; > + regulator-max-microvolt = <2928000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l13c_2p96: ldo13 { > + regulator-name = "vreg_l13c_2p96"; > + regulator-min-microvolt = <2504000>; > + regulator-max-microvolt = <2960000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l15c_1p9: ldo15 { > + regulator-name = "vreg_l15c_1p9"; > + regulator-min-microvolt = <1704000>; > + regulator-max-microvolt = <2928000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l16c_3p008: ldo16 { > + regulator-name = "vreg_l16c_3p008"; > + regulator-min-microvolt = <3008000>; > + regulator-max-microvolt = <3008000>; > + regulator-initial-mode = ; > + }; > + > + vreg_l18c_0p88: ldo18 { > + regulator-name = "vreg_l18c_0p88"; > + regulator-min-microvolt = <880000>; > + regulator-max-microvolt = <880000>; > + regulator-initial-mode = ; > + }; > + }; > +}; > + > +&tlmm { > + gpio-reserved-ranges = <0 4>; > +}; > + > +&uart2 { > + status = "okay"; > +}; > + > +&ufs_mem_hc { > + status = "okay"; > + > + reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>; > + > + vcc-supply = <&vreg_l10a_2p96>; > + vcc-max-microamp = <750000>; > + vccq-supply = <&vreg_l5c_1p2>; > + vccq-max-microamp = <700000>; > + vccq2-supply = <&vreg_s4a_1p8>; > + vccq2-max-microamp = <750000>; > +}; > + > +&ufs_mem_phy { > + status = "okay"; > + > + vdda-phy-supply = <&vreg_l8c_1p2>; > + vdda-max-microamp = <87100>; > + vdda-pll-supply = <&vreg_l5a_0p88>; > + vdda-pll-max-microamp = <18300>; > +}; > + > + > +&usb_1_hsphy { > + status = "okay"; > + vdda-pll-supply = <&vdd_usb_hs_core>; > + vdda33-supply = <&vdda_usb_hs_3p1>; > + vdda18-supply = <&vdda_usb_hs_1p8>; > +}; > + > +&usb_1_qmpphy { > + status = "okay"; > + vdda-phy-supply = <&vreg_l8c_1p2>; > + vdda-pll-supply = <&vdda_usb_ss_dp_core_1>; > +}; > + > +&usb_1 { > + status = "okay"; > +}; > + > +&usb_1_dwc3 { > + dr_mode = "peripheral"; > +}; > + > +&qupv3_id_1 { > + status = "okay"; > +}; > -- > 2.31.1 >