From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Dave Chinner <david@fromorbit.com>,
ceph-devel@vger.kernel.org, Chao Yu <yuchao0@huawei.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
Jeff Layton <jlayton@kernel.org>,
Johannes Thumshirn <jth@kernel.org>,
linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org,
linux-xfs@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
Steve French <sfrench@samba.org>, Ted Tso <tytso@mit.edu>,
Matthew Wilcox <willy@infradead.org>,
"Darrick J. Wong" <djwong@kernel.org>
Subject: Re: [PATCH 09/14] xfs: Convert double locking of MMAPLOCK to use VFS helpers
Date: Wed, 16 Jun 2021 06:38:25 +0100 [thread overview]
Message-ID: <YMmOUXSKfAWSwRFM@infradead.org> (raw)
In-Reply-To: <20210615091814.28626-9-jack@suse.cz>
On Tue, Jun 15, 2021 at 11:17:59AM +0200, Jan Kara wrote:
> Convert places in XFS that take MMAPLOCK for two inodes to use helper
> VFS provides for it (filemap_invalidate_down_write_two()). Note that
> this changes lock ordering for MMAPLOCK from inode number based ordering
> to pointer based ordering VFS generally uses.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-cifs@vger.kernel.org,
Damien Le Moal <damien.lemoal@wdc.com>,
linux-ext4@vger.kernel.org, Ted Tso <tytso@mit.edu>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Jeff Layton <jlayton@kernel.org>,
Steve French <sfrench@samba.org>,
Dave Chinner <david@fromorbit.com>,
Matthew Wilcox <willy@infradead.org>,
linux-f2fs-devel@lists.sourceforge.net,
Christoph Hellwig <hch@infradead.org>,
linux-mm@kvack.org, Miklos Szeredi <miklos@szeredi.hu>,
"Darrick J. Wong" <djwong@kernel.org>,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
ceph-devel@vger.kernel.org, Johannes Thumshirn <jth@kernel.org>,
linux-xfs@vger.kernel.org
Subject: Re: [f2fs-dev] [PATCH 09/14] xfs: Convert double locking of MMAPLOCK to use VFS helpers
Date: Wed, 16 Jun 2021 06:38:25 +0100 [thread overview]
Message-ID: <YMmOUXSKfAWSwRFM@infradead.org> (raw)
In-Reply-To: <20210615091814.28626-9-jack@suse.cz>
On Tue, Jun 15, 2021 at 11:17:59AM +0200, Jan Kara wrote:
> Convert places in XFS that take MMAPLOCK for two inodes to use helper
> VFS provides for it (filemap_invalidate_down_write_two()). Note that
> this changes lock ordering for MMAPLOCK from inode number based ordering
> to pointer based ordering VFS generally uses.
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-06-16 5:38 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 9:17 [PATCH 0/14 v8] fs: Hole punch vs page cache filling races Jan Kara
2021-06-15 9:17 ` [f2fs-dev] " Jan Kara
2021-06-15 9:17 ` [PATCH 01/14] mm: Fix comments mentioning i_mutex Jan Kara
2021-06-15 9:17 ` [f2fs-dev] " Jan Kara
2021-06-15 9:17 ` [PATCH 02/14] documentation: Sync file_operations members with reality Jan Kara
2021-06-15 9:17 ` [f2fs-dev] " Jan Kara
2021-06-16 5:31 ` Christoph Hellwig
2021-06-16 5:31 ` [f2fs-dev] " Christoph Hellwig
2021-06-15 9:17 ` [PATCH 03/14] mm: Protect operations adding pages to page cache with invalidate_lock Jan Kara
2021-06-15 9:17 ` [f2fs-dev] " Jan Kara
2021-06-16 5:33 ` Christoph Hellwig
2021-06-16 5:33 ` [f2fs-dev] " Christoph Hellwig
2021-06-17 16:15 ` Darrick J. Wong
2021-06-17 16:15 ` [f2fs-dev] " Darrick J. Wong
2021-06-15 9:17 ` [PATCH 04/14] mm: Add functions to lock invalidate_lock for two mappings Jan Kara
2021-06-15 9:17 ` [f2fs-dev] " Jan Kara
2021-06-16 5:34 ` Christoph Hellwig
2021-06-16 5:34 ` [f2fs-dev] " Christoph Hellwig
2021-06-15 9:17 ` [PATCH 05/14] ext4: Convert to use mapping->invalidate_lock Jan Kara
2021-06-15 9:17 ` [f2fs-dev] " Jan Kara
2021-06-17 16:22 ` Darrick J. Wong
2021-06-17 16:22 ` [f2fs-dev] " Darrick J. Wong
2021-06-22 9:54 ` Jan Kara
2021-06-22 9:54 ` [f2fs-dev] " Jan Kara
2021-06-22 17:34 ` Theodore Ts'o
2021-06-22 17:34 ` [f2fs-dev] " Theodore Ts'o
2021-06-15 9:17 ` [PATCH 06/14] ext2: Convert to using invalidate_lock Jan Kara
2021-06-15 9:17 ` [f2fs-dev] " Jan Kara
2021-06-16 5:35 ` Christoph Hellwig
2021-06-16 5:35 ` [f2fs-dev] " Christoph Hellwig
2021-06-15 9:17 ` [PATCH 07/14] xfs: Refactor xfs_isilocked() Jan Kara
2021-06-15 9:17 ` [f2fs-dev] " Jan Kara
2021-06-16 5:37 ` Christoph Hellwig
2021-06-16 5:37 ` [f2fs-dev] " Christoph Hellwig
2021-06-16 8:53 ` Jan Kara
2021-06-16 8:53 ` [f2fs-dev] " Jan Kara
2021-06-16 15:47 ` Darrick J. Wong
2021-06-16 15:47 ` [f2fs-dev] " Darrick J. Wong
2021-06-16 15:57 ` Jan Kara
2021-06-16 15:57 ` [f2fs-dev] " Jan Kara
2021-06-17 16:29 ` Darrick J. Wong
2021-06-17 16:29 ` [f2fs-dev] " Darrick J. Wong
2021-06-17 16:32 ` Darrick J. Wong
2021-06-17 16:32 ` [f2fs-dev] " Darrick J. Wong
2021-06-17 7:53 ` Christoph Hellwig
2021-06-17 7:53 ` [f2fs-dev] " Christoph Hellwig
2021-06-17 8:53 ` Jan Kara
2021-06-17 8:53 ` [f2fs-dev] " Jan Kara
2021-06-17 8:54 ` Christoph Hellwig
2021-06-17 8:54 ` [f2fs-dev] " Christoph Hellwig
2021-06-17 16:16 ` Darrick J. Wong
2021-06-17 16:16 ` [f2fs-dev] " Darrick J. Wong
2021-06-15 9:17 ` [PATCH 08/14] xfs: Convert to use invalidate_lock Jan Kara
2021-06-15 9:17 ` [f2fs-dev] " Jan Kara
2021-06-15 9:17 ` [PATCH 09/14] xfs: Convert double locking of MMAPLOCK to use VFS helpers Jan Kara
2021-06-15 9:17 ` [f2fs-dev] " Jan Kara
2021-06-16 5:38 ` Christoph Hellwig [this message]
2021-06-16 5:38 ` Christoph Hellwig
2021-06-15 9:18 ` [PATCH 10/14] zonefs: Convert to using invalidate_lock Jan Kara
2021-06-15 9:18 ` [f2fs-dev] " Jan Kara
2021-06-16 5:39 ` Christoph Hellwig
2021-06-16 5:39 ` [f2fs-dev] " Christoph Hellwig
2021-06-15 9:18 ` [PATCH 11/14] f2fs: " Jan Kara
2021-06-15 9:18 ` [f2fs-dev] " Jan Kara
2021-06-15 9:18 ` [PATCH 12/14] fuse: " Jan Kara
2021-06-15 9:18 ` [f2fs-dev] " Jan Kara
2021-06-15 9:18 ` [PATCH 13/14] ceph: Fix race between hole punch and page fault Jan Kara
2021-06-15 9:18 ` [f2fs-dev] " Jan Kara
2021-06-15 9:18 ` [PATCH 14/14] cifs: " Jan Kara
2021-06-15 9:18 ` [f2fs-dev] " Jan Kara
-- strict thread matches above, loose matches on Subject: below --
2021-07-15 13:40 [PATCH 0/14 v10] fs: Hole punch vs page cache filling races Jan Kara
2021-07-15 13:40 ` [PATCH 09/14] xfs: Convert double locking of MMAPLOCK to use VFS helpers Jan Kara
2021-07-12 16:55 [PATCH 0/14 v9] fs: Hole punch vs page cache filling races Jan Kara
2021-07-12 16:56 ` [PATCH 09/14] xfs: Convert double locking of MMAPLOCK to use VFS helpers Jan Kara
2021-06-07 14:52 [PATCH 0/14 v7] fs: Hole punch vs page cache filling races Jan Kara
2021-06-07 14:52 ` [PATCH 09/14] xfs: Convert double locking of MMAPLOCK to use VFS helpers Jan Kara
2021-06-07 15:57 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMmOUXSKfAWSwRFM@infradead.org \
--to=hch@infradead.org \
--cc=ceph-devel@vger.kernel.org \
--cc=damien.lemoal@wdc.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=jlayton@kernel.org \
--cc=jth@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=sfrench@samba.org \
--cc=tytso@mit.edu \
--cc=willy@infradead.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.