All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] drivers: usb: add missing MODULE_DEVICE_TABLE definition in brcmstb-usb-pinmap.c
@ 2021-06-16  3:50 ` Yu Jiahua
  0 siblings, 0 replies; 6+ messages in thread
From: Yu Jiahua @ 2021-06-16  3:50 UTC (permalink / raw)
  To: alcooperx, gregkh, f.fainelli, bcm-kernel-feedback-list
  Cc: linux-usb, linux-arm-kernel, linux-kernel, Yu Jiahua

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Signed-off-by: Yu Jiahua <yujiahua1@huawei.com>
---
 drivers/usb/misc/brcmstb-usb-pinmap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/misc/brcmstb-usb-pinmap.c b/drivers/usb/misc/brcmstb-usb-pinmap.c
index b3cfe8666ea7..cbc958355359 100644
--- a/drivers/usb/misc/brcmstb-usb-pinmap.c
+++ b/drivers/usb/misc/brcmstb-usb-pinmap.c
@@ -331,6 +331,7 @@ static const struct of_device_id brcmstb_usb_pinmap_of_match[] = {
 	{ .compatible = "brcm,usb-pinmap" },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, brcmstb_usb_pinmap_of_match);
 
 static struct platform_driver brcmstb_usb_pinmap_driver = {
 	.driver = {
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH -next] drivers: usb: add missing MODULE_DEVICE_TABLE definition in brcmstb-usb-pinmap.c
@ 2021-06-16  3:50 ` Yu Jiahua
  0 siblings, 0 replies; 6+ messages in thread
From: Yu Jiahua @ 2021-06-16  3:50 UTC (permalink / raw)
  To: alcooperx, gregkh, f.fainelli, bcm-kernel-feedback-list
  Cc: linux-usb, linux-arm-kernel, linux-kernel, Yu Jiahua

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Signed-off-by: Yu Jiahua <yujiahua1@huawei.com>
---
 drivers/usb/misc/brcmstb-usb-pinmap.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/misc/brcmstb-usb-pinmap.c b/drivers/usb/misc/brcmstb-usb-pinmap.c
index b3cfe8666ea7..cbc958355359 100644
--- a/drivers/usb/misc/brcmstb-usb-pinmap.c
+++ b/drivers/usb/misc/brcmstb-usb-pinmap.c
@@ -331,6 +331,7 @@ static const struct of_device_id brcmstb_usb_pinmap_of_match[] = {
 	{ .compatible = "brcm,usb-pinmap" },
 	{ },
 };
+MODULE_DEVICE_TABLE(of, brcmstb_usb_pinmap_of_match);
 
 static struct platform_driver brcmstb_usb_pinmap_driver = {
 	.driver = {
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] drivers: usb: add missing MODULE_DEVICE_TABLE definition in brcmstb-usb-pinmap.c
  2021-06-16  3:50 ` Yu Jiahua
@ 2021-06-16  3:57   ` Florian Fainelli
  -1 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2021-06-16  3:57 UTC (permalink / raw)
  To: Yu Jiahua, alcooperx, gregkh, f.fainelli, bcm-kernel-feedback-list
  Cc: linux-usb, linux-arm-kernel, linux-kernel



On 6/15/2021 8:50 PM, Yu Jiahua wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
> 
> Signed-off-by: Yu Jiahua <yujiahua1@huawei.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] drivers: usb: add missing MODULE_DEVICE_TABLE definition in brcmstb-usb-pinmap.c
@ 2021-06-16  3:57   ` Florian Fainelli
  0 siblings, 0 replies; 6+ messages in thread
From: Florian Fainelli @ 2021-06-16  3:57 UTC (permalink / raw)
  To: Yu Jiahua, alcooperx, gregkh, f.fainelli, bcm-kernel-feedback-list
  Cc: linux-usb, linux-arm-kernel, linux-kernel



On 6/15/2021 8:50 PM, Yu Jiahua wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
> 
> Signed-off-by: Yu Jiahua <yujiahua1@huawei.com>

Acked-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] drivers: usb: add missing MODULE_DEVICE_TABLE definition in brcmstb-usb-pinmap.c
  2021-06-16  3:50 ` Yu Jiahua
@ 2021-06-16  6:17   ` Greg KH
  -1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-06-16  6:17 UTC (permalink / raw)
  To: Yu Jiahua
  Cc: alcooperx, f.fainelli, bcm-kernel-feedback-list, linux-usb,
	linux-arm-kernel, linux-kernel

On Tue, Jun 15, 2021 at 07:50:03PM -0800, Yu Jiahua wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
> 
> Signed-off-by: Yu Jiahua <yujiahua1@huawei.com>
> ---
>  drivers/usb/misc/brcmstb-usb-pinmap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/misc/brcmstb-usb-pinmap.c b/drivers/usb/misc/brcmstb-usb-pinmap.c
> index b3cfe8666ea7..cbc958355359 100644
> --- a/drivers/usb/misc/brcmstb-usb-pinmap.c
> +++ b/drivers/usb/misc/brcmstb-usb-pinmap.c
> @@ -331,6 +331,7 @@ static const struct of_device_id brcmstb_usb_pinmap_of_match[] = {
>  	{ .compatible = "brcm,usb-pinmap" },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, brcmstb_usb_pinmap_of_match);

I have asked you all to stop sending these types of patches until you
can prove that they are actually needed.

Is this change really needed?  Does the presence of a of table determine
if this module should be loaded or not?

How did you find this problem?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH -next] drivers: usb: add missing MODULE_DEVICE_TABLE definition in brcmstb-usb-pinmap.c
@ 2021-06-16  6:17   ` Greg KH
  0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2021-06-16  6:17 UTC (permalink / raw)
  To: Yu Jiahua
  Cc: alcooperx, f.fainelli, bcm-kernel-feedback-list, linux-usb,
	linux-arm-kernel, linux-kernel

On Tue, Jun 15, 2021 at 07:50:03PM -0800, Yu Jiahua wrote:
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
> 
> Signed-off-by: Yu Jiahua <yujiahua1@huawei.com>
> ---
>  drivers/usb/misc/brcmstb-usb-pinmap.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/misc/brcmstb-usb-pinmap.c b/drivers/usb/misc/brcmstb-usb-pinmap.c
> index b3cfe8666ea7..cbc958355359 100644
> --- a/drivers/usb/misc/brcmstb-usb-pinmap.c
> +++ b/drivers/usb/misc/brcmstb-usb-pinmap.c
> @@ -331,6 +331,7 @@ static const struct of_device_id brcmstb_usb_pinmap_of_match[] = {
>  	{ .compatible = "brcm,usb-pinmap" },
>  	{ },
>  };
> +MODULE_DEVICE_TABLE(of, brcmstb_usb_pinmap_of_match);

I have asked you all to stop sending these types of patches until you
can prove that they are actually needed.

Is this change really needed?  Does the presence of a of table determine
if this module should be loaded or not?

How did you find this problem?

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-06-16  6:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-16  3:50 [PATCH -next] drivers: usb: add missing MODULE_DEVICE_TABLE definition in brcmstb-usb-pinmap.c Yu Jiahua
2021-06-16  3:50 ` Yu Jiahua
2021-06-16  3:57 ` Florian Fainelli
2021-06-16  3:57   ` Florian Fainelli
2021-06-16  6:17 ` Greg KH
2021-06-16  6:17   ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.