From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A5C3C48BE6 for ; Wed, 16 Jun 2021 07:33:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 42E9C6109E for ; Wed, 16 Jun 2021 07:33:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231195AbhFPHfT (ORCPT ); Wed, 16 Jun 2021 03:35:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231132AbhFPHfT (ORCPT ); Wed, 16 Jun 2021 03:35:19 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E62EFC061574; Wed, 16 Jun 2021 00:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hwWvq7TQGATF8evlhCqvc2H6xYP+A2KS0Fsb7ItfDEA=; b=rfU9gyQ8pkR0Bj/6M2Fwtc7p0b EcTHyyOyRmon6A/cjIvUpGynakobo7+nqn/9scVkMLVlzTJzrZh/7DRiot2edAV/3xv5hfW6LQz8m XFr0DMhsxfwQ708P+PQulaY4ioxb5mlS/zUek8YPgGHOkcXo0JTi74/uB1YL1Evfj/HQ5Audp9Wyv rTqKHG19bH6Lb+O2Wwdgv+n7lxQemIDvBrzVHPHmFShZ2ckov9PDV83sGG9R6EBilUles0UMd+FmW jgaaB9g6Flq/0bRp6vh5SMoCf+sV+U1lXWLrgNIGcqpNpamTCOJXma1ZIrvK65+/XfU5s39EejP3d eurEDpFA==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltQ2G-007koT-Ej; Wed, 16 Jun 2021 07:32:40 +0000 Date: Wed, 16 Jun 2021 08:32:28 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: guaneryu@gmail.com, Chandan Babu R , Allison Henderson , linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me, amir73il@gmail.com, ebiggers@kernel.org Subject: Re: [PATCH 07/13] fstests: automatically generate group files Message-ID: References: <162370433910.3800603.9623820748404628250.stgit@locust> <162370437774.3800603.15907676407985880109.stgit@locust> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162370437774.3800603.15907676407985880109.stgit@locust> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Mon, Jun 14, 2021 at 01:59:37PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Now that we've moved the group membership details into the test case > files themselves, automatically generate the group files during build. > The autogenerated files are named "group.list" instead of "group" to > avoid conflicts between generated and (stale) SCM files as everyone > rebases. Hmm, so we now need to run make to regenerate the group information? That is for sure going to create various issues with people forgetting to regenerate it. What about regenerating it everytime a group based run is executed?