All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	"Eric W . Biederman" <ebiederm@xmission.com>,
	Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH 5/6] posix-cpu-timers: Force next expiration recalc after early timer firing
Date: Wed, 16 Jun 2021 15:23:50 +0200	[thread overview]
Message-ID: <YMn7Zl2uc6NyUfXJ@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210616115923.GC801071@lothringen>

On Wed, Jun 16, 2021 at 01:59:23PM +0200, Frederic Weisbecker wrote:
> On Wed, Jun 16, 2021 at 11:42:53AM +0200, Peter Zijlstra wrote:
> > I'm thinking this is a better fix than patch #2. AFAICT you can now go
> > back to unconditionally doing start, and then if we fire it early, we'll
> > disarm the thing.
> > 
> > That would avoid the disconnect between the start condition and the fire
> > condition.
> 
> Right but the drawback is that we unconditionally start the threadgroup
> counter while initializing the timer to 0 (deactivated).
> 
> Then in the next tick at least one thread will need to lock the sighand
> and re-evaluate the whole list.

Yes.. but how common is it to enqueue expired timers? Surely that's an
unlikely corner case. All normal timers will have to suffer one extra
tick and iteration on exit, so I find it hard to justify complexity to
optimize an unlikely case.

I would rather have more obvious code.


  reply	other threads:[~2021-06-16 13:24 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 11:31 [PATCH 0/6] posix-cpu-timers: Bunch of fixes Frederic Weisbecker
2021-06-04 11:31 ` [PATCH 1/6] posix-cpu-timers: Fix rearm racing against process tick Frederic Weisbecker
2021-06-09 11:54   ` Frederic Weisbecker
2021-06-11 11:49     ` Peter Zijlstra
2021-06-11 12:37       ` Frederic Weisbecker
2021-06-04 11:31 ` [PATCH 2/6] posix-cpu-timers: Don't start process wide cputime counter if timer is disabled Frederic Weisbecker
2021-06-09 12:18   ` Frederic Weisbecker
2021-06-10 10:24     ` Frederic Weisbecker
2021-06-16  8:51   ` Peter Zijlstra
2021-06-16 10:51     ` Frederic Weisbecker
2021-06-16 11:26       ` Peter Zijlstra
2021-06-16 11:50         ` Peter Zijlstra
2021-06-04 11:31 ` [PATCH 3/6] posix-cpu-timers: Force next_expiration recalc after timer deletion Frederic Weisbecker
2021-06-16  9:16   ` Peter Zijlstra
2021-06-04 11:31 ` [PATCH 4/6] posix-cpu-timers: Force next_expiration recalc after timer reset Frederic Weisbecker
2021-06-16  9:23   ` Peter Zijlstra
2021-06-16 11:21     ` Frederic Weisbecker
2021-06-16 11:33       ` Peter Zijlstra
2021-06-04 11:31 ` [PATCH 5/6] posix-cpu-timers: Force next expiration recalc after early timer firing Frederic Weisbecker
2021-06-16  9:42   ` Peter Zijlstra
2021-06-16 11:59     ` Frederic Weisbecker
2021-06-16 13:23       ` Peter Zijlstra [this message]
2021-06-16 14:53         ` Frederic Weisbecker
2021-06-04 11:31 ` [PATCH 6/6] posix-cpu-timers: Force next expiration recalc after itimer reset Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMn7Zl2uc6NyUfXJ@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=ebiederm@xmission.com \
    --cc=frederic@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.