All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [RFC PATCH 2/3] lib: Add $LTPROOT/testcases/bin into PATH
Date: Wed, 16 Jun 2021 12:42:22 +0200	[thread overview]
Message-ID: <YMnVjvuMnymDD2cA@pevik> (raw)
In-Reply-To: <YMnLEjDAVQqwH7Wq@yuki>

Hi Cyril,

> I guess that we can also fairly simplify the code by expecting that PATH
> is never unset from the start, maybe we should just check it and WARN if
> it's not. Also we can assume that if LTPROOT is set we do not have to
> add the start_dir since the start_dir is only useful when tests are
> executed from the git checkout.

I'm sorry to sent patchset with full of bugs, thanks for all your explanation.
While your suggestion could work, it's a question if my effort help to anything
(as Li noted). My intend was to require only LTPROOT, but even we expect
script/binary is called by full path (otherwise adjusting PATH would be required
anyway) fix work only for C API. tst_test.sh PATH is missing for shell API :(.
(discussed with Li under 3rd patch)

Kind regards,
Petr

  reply	other threads:[~2021-06-16 10:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-15 16:33 [LTP] [RFC PATCH 0/3] C, shell API: Add $LTPROOT/testcases/bin into PATH Petr Vorel
2021-06-15 16:33 ` [LTP] [RFC PATCH 1/3] tst_test.sh: " Petr Vorel
2021-06-15 16:33 ` [LTP] [RFC PATCH 2/3] lib: " Petr Vorel
2021-06-16  9:57   ` Cyril Hrubis
2021-06-16 10:42     ` Petr Vorel [this message]
2021-06-15 16:33 ` [LTP] [RFC PATCH 3/3] doc: Update LTPROOT and PATH environment variables Petr Vorel
2021-06-16  9:42   ` Li Wang
2021-06-16 10:01     ` Petr Vorel
2021-06-16 10:21       ` Li Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMnVjvuMnymDD2cA@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.