All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] typo: Add necessary spaces in the outputs
Date: Wed, 16 Jun 2021 13:38:47 +0200	[thread overview]
Message-ID: <YMnix3wc3nTTUfXs@pevik> (raw)
In-Reply-To: <YMniMEyDjhCLcx8g@pevik>

> Hi Ziyao,

> > Hi!

> > Ping. I checked it based on the latest code. Are there any changes that need
> > to be added?
> Well, as I note previously on some places it'd be better to join string, e.g.
> testcases/kernel/syscalls/setsid/setsid01.c
> testcases/open_posix_testsuite/conformance/interfaces/sched_setparam/2-1.c
> testcases/kernel/syscalls/sysinfo/sysinfo02.c

> The reason is that string on single line is easier to grep.
> That's why checkpatch.pl from kernel relaxed max line from 80 to 100
> (good at least for string).
And because this I'd personally go for joining string most of the time, even
long strings like
testcases/kernel/syscalls/sched_get_priority_max/sched_get_priority_max01.c

Kind regards,
Petr

> But I'm ok to merge it without.

> Kind regards,
> Petr

> > Kind Regards,
> > Ziyao

  reply	other threads:[~2021-06-16 11:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-18  6:45 Xie Ziyao
2021-05-18  9:27 ` Li Wang
2021-05-20  5:03   ` Petr Vorel
2021-06-16 11:11     ` Xie Ziyao
2021-06-16 11:36       ` Petr Vorel
2021-06-16 11:38         ` Petr Vorel [this message]
2021-06-16 12:07         ` Xie Ziyao
2021-06-16 13:22           ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMnix3wc3nTTUfXs@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --subject='Re: [LTP] [PATCH] typo: Add necessary spaces in the outputs' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.