From: Patrick Steinhardt <ps@pks.im>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] perf: fix when running with TEST_OUTPUT_DIRECTORY
Date: Wed, 16 Jun 2021 14:13:42 +0200 [thread overview]
Message-ID: <YMnq9uPnmjotC5w7@ncase> (raw)
In-Reply-To: <87mtrqxcq1.fsf@evledraar.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 941 bytes --]
On Wed, Jun 16, 2021 at 01:33:32PM +0200, Ævar Arnfjörð Bjarmason wrote:
>
> On Wed, Jun 16 2021, Patrick Steinhardt wrote:
>
> > When the TEST_OUTPUT_DIRECTORY is defined, then all test data will be
> > written in that directory instead of the default directory located in
>
> Is the timing of this patch a coincidence, or did you run into this
> related to the other patches related to this variable now,
> i.e. https://lore.kernel.org/git/20210609170520.67014-1-felipe.contreras@gmail.com/
> and related.
Coincidence. In fact, I already sent this patch a few weeks ago as part
of [1]. But given that this patch set turned out to not be an easy sell
and that I didn't yet find the time to work on it again, I decided to
split out this patch and upstream it standalone.
Your remarks all make sense to me, will address them in v2. Thanks!
Patrick
[1]: http://public-inbox.org/git/cover.1621451532.git.ps@pks.im/
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-16 12:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 9:12 [PATCH] perf: fix when running with TEST_OUTPUT_DIRECTORY Patrick Steinhardt
2021-06-16 11:33 ` Ævar Arnfjörð Bjarmason
2021-06-16 12:13 ` Patrick Steinhardt [this message]
2021-06-18 13:56 ` [PATCH v2] " Patrick Steinhardt
2021-06-29 1:12 ` Junio C Hamano
2021-07-19 8:25 ` Jeff King
2021-07-19 10:52 ` Patrick Steinhardt
2021-07-19 10:53 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMnq9uPnmjotC5w7@ncase \
--to=ps@pks.im \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.