From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A117C48BE6 for ; Wed, 16 Jun 2021 20:26:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2103161003 for ; Wed, 16 Jun 2021 20:26:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233482AbhFPU2s (ORCPT ); Wed, 16 Jun 2021 16:28:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233471AbhFPU2s (ORCPT ); Wed, 16 Jun 2021 16:28:48 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF282C06175F for ; Wed, 16 Jun 2021 13:26:40 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id j11-20020a9d738b0000b02903ea3c02ded8so3829188otk.5 for ; Wed, 16 Jun 2021 13:26:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=T6gAZUccFikvtHCOVi1+1qn3JiUL2nu1CR9FCcCl0vw=; b=J/uaZSGnkBHGkMQg/39IxMz3uwjTcFNFFgiHfdL/4cg5SNHXVxYnfsS0ciu3LzKJKV rQCAuNJaO1Y7oLoifjLYWa1AdP14YPjexECYs8Fjc15FmDvEil6DaqQ3DJ3SpM4SA5Fm nbu/8lS3NmZKqOZjbzIp18VXH8tYK0Qr3Cr6QdnBFruCkpN6VOnsM07MXtwBTCJ/goGm VCGjjiEatOMYQW+5nkaxVBu11QWLIGH1DQK0gHLHEnCDEbaVssB8oF2EOzQ52POxe/57 /4UsfSYfXHOtQmEFLUutCYn7IXYkaUjtTOoZZHRI0GFH55DDkqqed/6u60qo2+JNGYoq dJ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=T6gAZUccFikvtHCOVi1+1qn3JiUL2nu1CR9FCcCl0vw=; b=XGeSVTo1f3ZqZKUPYRL0ofDjgD805lGtbjmLZEkBAsPyOmV1r4fbRbSyXa9eV+8376 txfAqwJhseTpV5GmGURyyIQnNJhLyLyV5gpJmNyw/pKdRcFMonXOTF0czWL700iGkFUM MB2XfEG1tA7dLteRumkSrB4RkWkymsNXMsRRSKKj+DkGeUwzujFN4YWEbvOC0Uy95UFt mtXv4akoh6BNQ6ToBGohnfPujXyHuANPLBXyCpDHDCIxhGiivjRKIoNB2k4ferEIkTBN +rFY0Rzw3BozgVm4yl4Rj++0mXkbjG3pYaM72K9+fbcodav56xZoW8nxuYki682u+mit EC9Q== X-Gm-Message-State: AOAM530k8eBzECkUa5D7z4NCuSurOM11qj6kFpnnu/LWebeWF6BPPKB/ 7H5w1scNRHPa/y7/QDRCo64tuA== X-Google-Smtp-Source: ABdhPJwtJnLmMYb4u0xCB0siYoVRKCx2zq1adGTibu3BIJ45pIRYbWxgJUiCYuJ5TeotUMoowtOdwA== X-Received: by 2002:a05:6830:411c:: with SMTP id w28mr1462057ott.196.1623875200030; Wed, 16 Jun 2021 13:26:40 -0700 (PDT) Received: from yoga (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id v1sm796040ota.22.2021.06.16.13.26.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jun 2021 13:26:39 -0700 (PDT) Date: Wed, 16 Jun 2021 15:26:37 -0500 From: Bjorn Andersson To: Sibi Sankar Cc: jassisinghbrar@gmail.com, manivannan.sadhasivam@linaro.org, agross@kernel.org, rananta@codeaurora.org, vnkgutta@codeaurora.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mailbox: qcom-ipcc: Fix IPCC mbox channel exhaustion Message-ID: References: <1623865378-1943-1-git-send-email-sibis@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623865378-1943-1-git-send-email-sibis@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 16 Jun 12:42 CDT 2021, Sibi Sankar wrote: > Fix IPCC (Inter-Processor Communication Controller) channel exhaustion by > setting the channel private data to NULL on mbox shutdown. > > Err Logs: > remoteproc: MBA booted without debug policy, loading mpss > remoteproc: glink-edge: failed to acquire IPC channel > remoteproc: failed to probe subdevices for remoteproc: -16 > > Fixes: fa74a0257f45 ("mailbox: Add support for Qualcomm IPCC") > Signed-off-by: Sibi Sankar > Cc: stable@vger.kernel.org Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/mailbox/qcom-ipcc.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c > index 2d13c72944c6..584700cd1585 100644 > --- a/drivers/mailbox/qcom-ipcc.c > +++ b/drivers/mailbox/qcom-ipcc.c > @@ -155,6 +155,11 @@ static int qcom_ipcc_mbox_send_data(struct mbox_chan *chan, void *data) > return 0; > } > > +static void qcom_ipcc_mbox_shutdown(struct mbox_chan *chan) > +{ > + chan->con_priv = NULL; > +} > + > static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox, > const struct of_phandle_args *ph) > { > @@ -184,6 +189,7 @@ static struct mbox_chan *qcom_ipcc_mbox_xlate(struct mbox_controller *mbox, > > static const struct mbox_chan_ops ipcc_mbox_chan_ops = { > .send_data = qcom_ipcc_mbox_send_data, > + .shutdown = qcom_ipcc_mbox_shutdown, > }; > > static int qcom_ipcc_setup_mbox(struct qcom_ipcc *ipcc) > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >