From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C88E7C48BE5 for ; Wed, 16 Jun 2021 20:53:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A4E076128C for ; Wed, 16 Jun 2021 20:53:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233745AbhFPUzj (ORCPT ); Wed, 16 Jun 2021 16:55:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:38192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233698AbhFPUzi (ORCPT ); Wed, 16 Jun 2021 16:55:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id EFE1861076; Wed, 16 Jun 2021 20:53:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623876812; bh=219hjrkK1oqhlyk9es2Sd6dg6iucL/BDKkWssXgsobM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pcpo12zLL0x1Ztnh/FpOyGT+X65ESKmv+HroFnocsqxDaKIq8k8SbkiOgqdGpj5sO VI5jXBo1e+NTY0R2z3lxeI9CVuwFhHtneP4PGa3qdwf3i6CMm4jiIotDXd2svDQQPA s9m5OWQepnORMie4O+RSiM5dmcHygWGJDb5wy6Ss+UJ56YwWuDO2+wY2nUg62700rK AOL88coR2Sy/hQ56A336dytoR0/8L5gtEfdTHxAivsGxwSasshOGjcPzr1BdokA9Tj MMRrstdxPsa0nyaLHRxJHamHWsoMG2X26Ms2Ans/7eoMQbthsty/AYqez8OitabUd+ acSGQwcAbyKQA== Date: Wed, 16 Jun 2021 13:53:30 -0700 From: Eric Biggers To: "Darrick J. Wong" Cc: guaneryu@gmail.com, Allison Henderson , linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me, amir73il@gmail.com Subject: Re: [PATCH 05/13] fstests: move test group info to test files Message-ID: References: <162370433910.3800603.9623820748404628250.stgit@locust> <162370436680.3800603.3592918737641309773.stgit@locust> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <162370436680.3800603.3592918737641309773.stgit@locust> Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org On Mon, Jun 14, 2021 at 01:59:26PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Refactor every test in the entire test suite to use the new boilerplate > functions. This also migrates all the test group information into the > test files. This patch has been autogenerated via the command: > > ./tools/convert-group btrfs ceph cifs ext4 f2fs generic nfs ocfs2 overlay perf shared udf xfs > > NOTE: This patch submission only contains diffs of the first seven btrfs > tests because vger rejects 1.5MB patches. The full conversion is in the > git branch linked from the cover letter. > > Signed-off-by: Darrick J. Wong > Reviewed-by: Allison Henderson Looks good, thanks for doing this! I can't review the whole commit, but the changes to the tests I've written look fine, and they still run and pass. Also I verified that the diff matches that produced by convert-group, as claimed. Reviewed-by: Eric Biggers - Eric