From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ED4BC48BE5 for ; Wed, 16 Jun 2021 23:30:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B97F61166 for ; Wed, 16 Jun 2021 23:30:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234612AbhFPXcv (ORCPT ); Wed, 16 Jun 2021 19:32:51 -0400 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:60871 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S234508AbhFPXcu (ORCPT ); Wed, 16 Jun 2021 19:32:50 -0400 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 15GNUbU7032395 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 16 Jun 2021 19:30:37 -0400 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 3C13115C3CB8; Wed, 16 Jun 2021 19:30:37 -0400 (EDT) Date: Wed, 16 Jun 2021 19:30:37 -0400 From: "Theodore Ts'o" To: Jiapeng Chong Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: Remove redundant assignment to error Message-ID: References: <1619691409-83160-1-git-send-email-jiapeng.chong@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1619691409-83160-1-git-send-email-jiapeng.chong@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 29, 2021 at 06:16:49PM +0800, Jiapeng Chong wrote: > Variable error is set to zero but this value is never read as it's not > used later on, hence it is a redundant assignment and can be removed. > > Cleans up the following clang-analyzer warning: > > fs/ext4/ioctl.c:657:3: warning: Value stored to 'error' is never read > [clang-analyzer-deadcode.DeadStores]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied, thanks. - Ted