All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v3] ssh-stress: Convert to new api
Date: Thu, 17 Jun 2021 07:14:41 +0200	[thread overview]
Message-ID: <YMraQVl2Hjnlu2rX@pevik> (raw)
In-Reply-To: <b092967d-2104-03d3-a95d-2042724ecca0@jv-coder.de>

Hi Joerg,

> Hi Petr,

> On 6/16/2021 4:36 PM, Petr Vorel wrote:
> > Hi Joerg, Alexey,

> > ...
> > > >   cleanup()
> > > >   {
> > > > +	local pids
> > > > +
> > > >   	# Stop the ssh daemon
> > > > -	test -s sshd.pid && kill $(cat sshd.pid)
> > > > -	pkill 'netstress$'
> > > > -	tst_rmdir
> > > > -	[ "$rtmpdir" ] && tst_rhost_run -c "rm -rf $rtmpdir"
> > > > -	TMPDIR=
> > > > +	[ -s sshd.pid ] && kill $(cat sshd.pid)
> > > > +	[ -n "$NETSTRESS_PID" ] && kill -2 $NETSTRESS_PID >/dev/null 2>&1
> > > > +
> > > > +	tst_rhost_run -c "kill $RHOST_PIDS"  >/dev/null 2>&1
> > And check also $RHOST_PIDS, right?
> > [ -n "$RHOST_PIDS" ] && tst_rhost_run -c "kill $RHOST_PIDS" >/dev/null 2>&1
> Right... But actually doesn't matter. Just "kill" does nothing"
Sure, but just to sync it with previous kill of $NETSTRESS_PID
(both have stderr redirected, thus it shouldn't be necessary, but does not
harm).

Kind regards,
Petr

> > > > +
> > > > +	# Kill all remaining ssh processes
> > > > +	tst_rhost_run -c "pkill -f '^ssh $RHOST_SSH_CONF'"
> > > Perhaps we should check that $RHOST_SSH_CONF is set before running
> > > pkill.
> > [ -n "$RHOST_SSH_CONF" ] && tst_rhost_run -c "pkill -f '^ssh $RHOST_SSH_CONF'"
> Yes, this should be done...

> > No need to repost, I'll fix it before merge.
> Thanks

> J?rg

  reply	other threads:[~2021-06-17  5:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16  8:18 [LTP] [PATCH v3] ssh-stress: Convert to new api Joerg Vehlow
2021-06-16 11:16 ` Petr Vorel
2021-06-16 14:11 ` Alexey Kodanev
2021-06-16 14:36   ` Petr Vorel
2021-06-17  4:20     ` Joerg Vehlow
2021-06-17  5:14       ` Petr Vorel [this message]
2021-06-17  5:18 ` Petr Vorel
2021-06-17  6:56   ` Joerg Vehlow
2021-06-17 12:41     ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMraQVl2Hjnlu2rX@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.