From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 454266E0C4 for ; Thu, 17 Jun 2021 06:40:56 +0000 (UTC) Date: Thu, 17 Jun 2021 09:42:51 +0300 From: Petri Latvala Message-ID: References: <20210616113714.5766-1-andrzej.turko@linux.intel.com> <20210616113714.5766-2-andrzej.turko@linux.intel.com> <20210617060646.GB4129@zkempczy-mobl2> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210617060646.GB4129@zkempczy-mobl2> Subject: Re: [igt-dev] [PATCH i-g-t 1/1] lib/intel_allocator: Check validity of the file descriptor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Zbigniew =?utf-8?Q?Kempczy=C5=84ski?= Cc: igt-dev@lists.freedesktop.org List-ID: T24gVGh1LCBKdW4gMTcsIDIwMjEgYXQgMDg6MDY6NDZBTSArMDIwMCwgWmJpZ25pZXcgS2VtcGN6 ecWEc2tpIHdyb3RlOgo+IE9uIFdlZCwgSnVuIDE2LCAyMDIxIGF0IDAzOjA1OjUwUE0gKzAzMDAs IFBldHJpIExhdHZhbGEgd3JvdGU6Cj4gPiBPbiBXZWQsIEp1biAxNiwgMjAyMSBhdCAwMTozNzox NFBNICswMjAwLCBBbmRyemVqIFR1cmtvIHdyb3RlOgo+ID4gPiBBbGwgcHJvY2VkdXJlcyBmb3Ig b3BlbmluZyBwYXJ0aWN1bGFyIHR5cGVzIG9mIGFsbG9jYXRvcnMKPiA+ID4gcXVlcnkgdGhlIGd0 dCBzaXplLiBFdmVuIGlmIHRoZSB1c2VyIGhhcyBwcm92aWRlZCB0aGUKPiA+ID4gYm91bmRhcmll cyBvZiB0aGUgYWRkcmVzcyBzcGFjZSBtYW5hZ2VkIGJ5IHRoZSBhbGxvY2F0b3IsCj4gPiA+IHRo ZSBxdWVyeSBpcyBwZXJmb3JtZWQgZm9yIHRoZSBzYWtlIG9mIHZhbGlkYXRpb24uCj4gPiA+IAo+ ID4gPiBnZW1fYXBlcnR1cmVfc2l6ZSgpIGNhbGxlZCB3aXRoIGFuIGludmFsaWQgaWQgcmV0dXJu cyBhCj4gPiA+IGRlZmF1bHQgdmFsdWUgaW5zdGVhZCBvZiBmYWlsaW5nLiBUaHVzLCB3ZSBuZWVk IHRvCj4gPiA+IGFkZGl0aW9uYWxseSBjaGVjayB3aGV0aGVyIHRoZSBmaWxlIGRlc2NyaXB0b3Ig aXMgdmFsaWQuCj4gPiA+IAo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBBbmRyemVqIFR1cmtvIDxhbmRy emVqLnR1cmtvQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gQ2M6IFpiaWduaWV3IEtlbXBjennFhHNr aSA8emJpZ25pZXcua2VtcGN6eW5za2lAaW50ZWwuY29tPgo+ID4gPiAtLS0KPiA+ID4gIGxpYi9p bnRlbF9hbGxvY2F0b3IuYyB8IDExICsrKysrKysrKysrCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwg MTEgaW5zZXJ0aW9ucygrKQo+ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2xpYi9pbnRlbF9hbGxv Y2F0b3IuYyBiL2xpYi9pbnRlbF9hbGxvY2F0b3IuYwo+ID4gPiBpbmRleCA5NmY4MzlkNGIuLmMw NjBlMTBjMyAxMDA2NDQKPiA+ID4gLS0tIGEvbGliL2ludGVsX2FsbG9jYXRvci5jCj4gPiA+ICsr KyBiL2xpYi9pbnRlbF9hbGxvY2F0b3IuYwo+ID4gPiBAQCAtMTY2LDYgKzE2NiwxNSBAQCBzdGF0 aWMgaW5saW5lIHZvaWQgbWFwX2VudHJ5X2ZyZWVfZnVuYyhzdHJ1Y3QgaWd0X21hcF9lbnRyeSAq ZW50cnkpCj4gPiA+ICAJZnJlZShlbnRyeS0+ZGF0YSk7Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4g K3N0YXRpYyBib29sIGNhbl9yZXBvcnRfZ3R0X3NpemUoaW50IGZkKQo+ID4gPiArewo+ID4gPiAr CXN0cnVjdCBkcm1faTkxNV9nZW1fY29udGV4dF9wYXJhbSBwID0gewo+ID4gPiArCQkucGFyYW0g PSBJOTE1X0NPTlRFWFRfUEFSQU1fR1RUX1NJWkUKPiA+ID4gKwl9Owo+ID4gPiArCj4gPiA+ICsJ cmV0dXJuIChfX2dlbV9jb250ZXh0X2dldF9wYXJhbShmZCwgJnApID09IDApOwo+ID4gPiArfQo+ ID4gPiArCj4gPiA+ICBzdGF0aWMgdWludDY0X3QgX19oYW5kbGVfY3JlYXRlKHN0cnVjdCBhbGxv Y2F0b3IgKmFsKQo+ID4gPiAgewo+ID4gPiAgCXN0cnVjdCBoYW5kbGVfZW50cnkgKmggPSBtYWxs b2Moc2l6ZW9mKCpoKSk7Cj4gPiA+IEBAIC0yNzEsNiArMjgwLDggQEAgc3RhdGljIHN0cnVjdCBp bnRlbF9hbGxvY2F0b3IgKmludGVsX2FsbG9jYXRvcl9jcmVhdGUoaW50IGZkLAo+ID4gPiAgewo+ ID4gPiAgCXN0cnVjdCBpbnRlbF9hbGxvY2F0b3IgKmlhbCA9IE5VTEw7Cj4gPiA+ICAKPiA+ID4g KwlpZ3RfYXNzZXJ0KGNhbl9yZXBvcnRfZ3R0X3NpemUoZmQpKTsKPiA+ID4gKwo+ID4gCj4gPiBJ cyBpZ3RfYXNzZXJ0IGNvcnJlY3QgaGVyZSAoYXMgb3Bwb3NlZCB0byBpZ3RfcmVxdWlyZSk/IE9y IGluIG90aGVyCj4gPiB3b3JkcywgaXMgaW5hYmlsaXR5IHRvIHJlcG9ydCBndHQgc2l6ZSBhIGtl cm5lbCBidWcgb3Igbm90Pwo+IAo+IEluIHRoaXMgY2FzZSB5ZXMsIHdlIHdhbnQgdG8gYXNzZXJ0 LiBMZXQgbWUgdHJ5IHRvIGV4cGxhaW4gdGhlIHNjZW5hcmlvLgo+IAo+IAo+IDEuIGFsbG9jYXRv ciB0aHJlYWQgYWN0cyBmb3IgY2hpbGRyZW4sIGZvciBleGFtcGxlIHdlIGdvdCAKPiAgICBmZCBp OTE1ID09IDMgYW5kIGN0eCA9PSAwCj4gCj4gMi4gY2hpbGQgMSBkb2VzOiAKPiAgICAKPiAgICBh aG5kID0gaW50ZWxfYWxsb2NhdG9yX29wZW4oaTkxNSA9PSAzLCBjdHggPT0gMCk7Cj4gCj4gICAg LT4gYWxsb2NhdG9yIChpbnNpZGUgc2ltcGxlKSBjYWxscyBnZW1fYXBlcnR1cmVfc2l6ZShpOTE1 KQo+ICAgICAgIHRvIGZpbmQgb3V0IHZtIHNpemUgLSB0aGlzIHdvcmtzIHBlcmZlY3QKPiAKPiAz LiBjaGlsZCAyIGRvZXM6IAo+ICAgIAo+ICAgIGk5MTUgPSBnZW1fcmVvcGVuX2RyaXZlcihpOTE1 KTsKPiAgICBhaG5kID0gaW50ZWxfYWxsb2NhdG9yX29wZW4oaTkxNSA9PSA1LCBjdHggPT0gMCk7 Cj4gCj4gICAgLT4gYWxsb2NhdG9yIGRvZXMgc2FtZSB3aGF0IGNoaWxkIDEsIGJ1dCBnZW1fYXBl cnR1cmVfc2l6ZShpOTE1KQo+ICAgICAgIGlzIGNhbGxlZCBvbiBpbnZhbGlkIGZyb20gYWxsb2Nh dG9yIHByb2Nlc3MgaGFuZGxlLiAKPiAgICAKPiBDdXJyZW50IGltcGxlbWVudGF0aW9uIG9mIGdl bV9hcGVydHVyZV9zaXplKCkgY2FsbHMgCj4gZ2VtX2dsb2JhbF9hcGVydHVyZV9zaXplKCkgd2hh dCByZXNldHMgZXJybm8gb24gZXJyb3IgcmV0dXJuaW5nCj4gcHJlZGVmaW5lZCAyNTZNQiBzaXpl Lgo+IAo+IFdlIHdhbnQgdG8gYXZvaWQgc3VjaCBtaXN0YWtlcyBpbiB0aGUgZnV0dXJlIGluIGFs bG9jYXRvci4gUGxhbiBpczoKPiAKPiAxLiBpbnRyb2R1Y2UgaWd0X2Fzc2VydCgpIG9uIHN1Y2gg Y2FzZS4gQ3VycmVudGx5IGRvZXMgbm90aGluZyBiZWNhdXNlCj4gICAgdGhlcmUncyBubyB0ZXN0 IHdobyBkb2VzIGNoaWxkIDIgc2NlbmFyaW8gKGJ1dCBzb29uIHdpbGwgYmUpLgo+IAo+IDIuIHB1 dCBmYWlsaW5nIHRlc3QgdG8gYXBpX2ludGVsX2FsbG9jYXRvci5jICh3aGljaCBleGVyY2lzZSBh Ym92ZSAKPiAgICBjaGlsZCAyIHNjZW5hcmlvKS4KPiAKPiAzLiBmaXggYWxsb2NhdG9yIC0+IGRy b3AgY2FsbGluZyBnZW1fYXBlcnR1cmVfc2l6ZSgpIG9uIGFsbG9jYXRvcgo+ICAgIHRocmVhZCBh bmQgbW92ZSBpdCB0byB0aGUgY2FsbGVyIChpdCBoYXMgYWN0aXZlIGZkIHRvIGtlcm5lbCkuCj4g ICAgVGhhdHMgd2lsbCBkcm9wIGFsbG9jYXRvciB0aHJlYWQgaTkxNSBmZCBkZXBlbmRlbmN5IGFu ZCB0aGlzIAo+ICAgIGlzIHdoYXQgd2Ugd2FudC4KPiAKPiBPbmUgc2NlbmFyaW8gaXMgd2UgY2Fu bm90IGhhbmRsZSAtIHR3byBvciBtb3JlIGNoaWxkcmVuIHJlb3BlbnMgCj4gZHJpdmVyLiBJbiBz dWNoIGNhc2UgdGhleSBtYXkgaGF2ZSBzYW1lIGk5MTUgZmQgc28gdGhleSBzdGFydHMKPiBzaGFy aW5nIHZtIGluc3RlYWQgaGF2aW5nIHNlcGFyYXRlLiBCdXQgd2Ugc3RpbGwgaGF2ZSBwb3NzaWJp bGl0eQo+IHRvIHVzZSAoaTkxNSwgdm0pIGFzIGEga2V5IHNvIGluIHN1Y2ggc2NlbmFyaW8gd2Ug bWF5IHVzZSBjaGlsZAo+IHBpZCBhcyB2bWlkLCB0aGVuIGVhY2ggY2hpbGQgd2lsbCBoYXZlIHNl cGFyYXRlIHZtIGZvciBhbGxvY2F0aW9ucy4KPiBPciBpZiBjaGlsZCB3aWxsIGNhbGwgaW50ZWxf YWxsb2NhdG9yX2luaXQoKSBpdCB3aWxsIHRvdGFsbHkgCj4gZHJvcCBhbGxvY2F0b3IgdGhyZWFk IGFyYml0cmF0aW9uIC0+IHRoaXMgcmVpbml0aWFsaXplcyBhbGxvY2F0b3IKPiBkYXRhIHdpdGhp biBjaGlsZCBzbyBpdCBjb21lcyBzdGFuZGFsb25lIGFsbG9jYXRvci4KCgpZZWFoIGFzc2VydCBz b3VuZHMgbW9yZSBwcm9wZXIgdGhlbi4gQWx0aG91Z2ggdGhlIGJlc3Qgd291bGQgYmUgYW4KaWd0 X2Fzc2VydF9pZ3RfaXNfYnJva2VuX2RvbnRfYmxhbWVfdGhlX2tlcm5lbCgpIGJ1dCBvbmUgbXVz dCB1c2Ugd2hhdApvbmUgaGFzLi4uCgoKLS0gClBldHJpIExhdHZhbGEKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0 LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==