From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6950BC2B9F4 for ; Thu, 17 Jun 2021 08:55:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 379DB613B9 for ; Thu, 17 Jun 2021 08:55:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230526AbhFQI5U (ORCPT ); Thu, 17 Jun 2021 04:57:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230291AbhFQI5U (ORCPT ); Thu, 17 Jun 2021 04:57:20 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16B14C061574; Thu, 17 Jun 2021 01:55:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7kLQp6MYKDk8/sAaxwp980AGLDLmbDndmOr3pBheMP8=; b=s8gPNuR5E60SDx/0jvFuG+ztKT LhkO7ekXck3IFxpaFRh0aXcx68zPSCb9j8qEojrfsBzB458A8Wpo3blG/4i9Fgwvbw3TjTMpCRW59 VDdK549e9Uj+LlQ4b0QFL2VyktYjZNBGvUW6vlpaztsCzTyyYhazCPnhn1tUZ5f4pnweFZ+zoTfcW vi3pQgHb9r1oipRjtDslyHYP3KK6c5uEA0YJ0qhlIfuVzu7oTLsvgGpZktf1hxdc8y2w+1WnpyYtm 5hFg7oBbDir+o13KteeAI+h/AHOcmJHO7kEJdITTE4WSd+WSgTmHe3mKfyx7gYxOZETR30oq6EHa1 6BJ7DQog==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltnnN-008wOt-0k; Thu, 17 Jun 2021 08:54:45 +0000 Date: Thu, 17 Jun 2021 09:54:41 +0100 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, Dave Chinner , ceph-devel@vger.kernel.org, Chao Yu , Damien Le Moal , "Darrick J. Wong" , Jaegeuk Kim , Jeff Layton , Johannes Thumshirn , linux-cifs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Miklos Szeredi , Steve French , Ted Tso , Matthew Wilcox , Pavel Reichl , Dave Chinner , Eric Sandeen Subject: Re: [PATCH 07/14] xfs: Refactor xfs_isilocked() Message-ID: References: <20210615090844.6045-1-jack@suse.cz> <20210615091814.28626-7-jack@suse.cz> <20210617085319.GD32587@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210617085319.GD32587@quack2.suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Thu, Jun 17, 2021 at 10:53:19AM +0200, Jan Kara wrote: > On Thu 17-06-21 08:53:28, Christoph Hellwig wrote: > > On Tue, Jun 15, 2021 at 11:17:57AM +0200, Jan Kara wrote: > > > From: Pavel Reichl > > > > > > Refactor xfs_isilocked() to use newly introduced __xfs_rwsem_islocked(). > > > __xfs_rwsem_islocked() is a helper function which encapsulates checking > > > state of rw_semaphores hold by inode. > > > > Looks good with the updated commit log: > > > > Signed-off-by: Christoph Hellwig > > I suppose you mean Reviewed-by, don't you? Yes: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D824C2B9F4 for ; Thu, 17 Jun 2021 08:55:55 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E978D61245; Thu, 17 Jun 2021 08:55:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E978D61245 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1ltnoW-0000o3-2O; Thu, 17 Jun 2021 08:55:52 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ltnoU-0000nc-9S for linux-f2fs-devel@lists.sourceforge.net; Thu, 17 Jun 2021 08:55:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7kLQp6MYKDk8/sAaxwp980AGLDLmbDndmOr3pBheMP8=; b=BNVNKPaeLkpdCKprdLzCQoyVc7 ppCMtHgied1LreFfRFXpXwaAepe6nqalemkNkaaAshouqFNJzUGgDf3ZWHd5GFBUXlc2Zy5LI7a9h TdPPR4yyyHYJZBqDSoZWUxJ83O1fwH6AwuwzWk742QpAz90kTtZp1YDlhMqKmtBV3Zzg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7kLQp6MYKDk8/sAaxwp980AGLDLmbDndmOr3pBheMP8=; b=AftQGU0VJCrfqxAsW0C/3QG9k4 Kh38DwgX1Ay3ejDTWuqCYg/pwiJziOcwIF1j5PotpKS2mH5jeA0PhHzMsxU0d/P1Qz0q0twF44Oem EjNs7UnwOblCoUGz4oIDzBSjCLKwBTlgpoRvBF7h5XpGigL6IoTyUmEcEdy8hzwMdpSU=; Received: from casper.infradead.org ([90.155.50.34]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1ltnoQ-00DToN-EM for linux-f2fs-devel@lists.sourceforge.net; Thu, 17 Jun 2021 08:55:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7kLQp6MYKDk8/sAaxwp980AGLDLmbDndmOr3pBheMP8=; b=s8gPNuR5E60SDx/0jvFuG+ztKT LhkO7ekXck3IFxpaFRh0aXcx68zPSCb9j8qEojrfsBzB458A8Wpo3blG/4i9Fgwvbw3TjTMpCRW59 VDdK549e9Uj+LlQ4b0QFL2VyktYjZNBGvUW6vlpaztsCzTyyYhazCPnhn1tUZ5f4pnweFZ+zoTfcW vi3pQgHb9r1oipRjtDslyHYP3KK6c5uEA0YJ0qhlIfuVzu7oTLsvgGpZktf1hxdc8y2w+1WnpyYtm 5hFg7oBbDir+o13KteeAI+h/AHOcmJHO7kEJdITTE4WSd+WSgTmHe3mKfyx7gYxOZETR30oq6EHa1 6BJ7DQog==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltnnN-008wOt-0k; Thu, 17 Jun 2021 08:54:45 +0000 Date: Thu, 17 Jun 2021 09:54:41 +0100 From: Christoph Hellwig To: Jan Kara Message-ID: References: <20210615090844.6045-1-jack@suse.cz> <20210615091814.28626-7-jack@suse.cz> <20210617085319.GD32587@quack2.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210617085319.GD32587@quack2.suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1ltnoQ-00DToN-EM Subject: Re: [f2fs-dev] [PATCH 07/14] xfs: Refactor xfs_isilocked() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Chinner , linux-mm@kvack.org, linux-cifs@vger.kernel.org, "Darrick J. Wong" , Matthew Wilcox , Christoph Hellwig , linux-ext4@vger.kernel.org, Eric Sandeen , Dave Chinner , Jaegeuk Kim , ceph-devel@vger.kernel.org, linux-xfs@vger.kernel.org, Damien Le Moal , Ted Tso , Miklos Szeredi , Jeff Layton , linux-f2fs-devel@lists.sourceforge.net, Steve French , linux-fsdevel@vger.kernel.org, Pavel Reichl , Johannes Thumshirn Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Thu, Jun 17, 2021 at 10:53:19AM +0200, Jan Kara wrote: > On Thu 17-06-21 08:53:28, Christoph Hellwig wrote: > > On Tue, Jun 15, 2021 at 11:17:57AM +0200, Jan Kara wrote: > > > From: Pavel Reichl > > > > > > Refactor xfs_isilocked() to use newly introduced __xfs_rwsem_islocked(). > > > __xfs_rwsem_islocked() is a helper function which encapsulates checking > > > state of rw_semaphores hold by inode. > > > > Looks good with the updated commit log: > > > > Signed-off-by: Christoph Hellwig > > I suppose you mean Reviewed-by, don't you? Yes: Reviewed-by: Christoph Hellwig _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel