From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 244D6C48BE5 for ; Thu, 17 Jun 2021 13:22:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05E5F6112D for ; Thu, 17 Jun 2021 13:22:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232500AbhFQNYm (ORCPT ); Thu, 17 Jun 2021 09:24:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:58748 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229931AbhFQNYl (ORCPT ); Thu, 17 Jun 2021 09:24:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 81262613BA; Thu, 17 Jun 2021 13:22:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623936153; bh=m8K5khmOV4Nt95fDzRf7f7CuZlwaLm2UDMhLZOcWULs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=xa4OOiGtb2s2c6xosB8LEOG+gNZ84PRyBoDa09ioQao+sz4MK5zqRDenVsZEAZ7yM IQ+1ClNUraerQMlwzeWiacQNxPzdZDVMshXPe0OAYLRpvJMdACX4zZyvC8S8+I6LpH 7dWMM5nutSBB2Q8Zfsaalk4e3JA5Wd60BCpUuzFk= Date: Thu, 17 Jun 2021 15:22:30 +0200 From: Greg Kroah-Hartman To: Linyu Yuan Cc: Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Linyu Yuan Subject: Re: [PATCH v3] usb: gadget: eem: fix echo command packet response issue Message-ID: References: <20210616115142.34075-1-linyyuan@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210616115142.34075-1-linyyuan@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 16, 2021 at 07:51:42PM +0800, Linyu Yuan wrote: > From: Linyu Yuan > > when receive eem echo command, it will send a response, > but queue this response to the usb request which allocate > from gadget device endpoint zero, > and transmit the request to IN endpoint of eem interface. > > on dwc3 gadget, it will trigger following warning in function > __dwc3_gadget_ep_queue(), > > if (WARN(req->dep != dep, "request %pK belongs to '%s'\n", > &req->request, req->dep->name)) > return -EINVAL; Is this really a problem? I am guessing the request will not work at all? Or just warn and continue with it? How was this ever working? > > fix it by allocating a usb request from IN endpoint of eem interface, > and transmit the usb request to same IN endpoint of eem interface. > > Signed-off-by: Linyu Yuan > --- What commit does this fix? Should it be backported to older stable kernels? If so, how far back? thanks, greg k-h