From: Matthias Kaehlcke <mka@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Masahiro Yamada <masahiroy@kernel.org>
Cc: Naresh Kamboju <naresh.kamboju@linaro.org>,
Linux-Next Mailing List <linux-next@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
linux-usb@vger.kernel.or, lkft-triage@lists.linaro.org,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kbuild@vger.kernel.org
Subject: Re: [next] [arm64] allmodconfig build failed - xhci-plat.c:427: undefined reference to `onboard_hub_destroy_pdevs'
Date: Thu, 17 Jun 2021 11:16:18 -0700 [thread overview]
Message-ID: <YMuRcrE8xlWnFSWW@google.com> (raw)
In-Reply-To: <YMtSFVg6UoOpDqIP@kroah.com>
On Thu, Jun 17, 2021 at 03:45:57PM +0200, Greg Kroah-Hartman wrote:
> On Thu, Jun 17, 2021 at 07:09:15PM +0530, Naresh Kamboju wrote:
> > The arm64 allmodconfig build failed on Linux next 20210617 tag due to
> > the commit,
> >
> > c950686b382d ("usb: host: xhci-plat: Create platform device for
> > onboard hubs in probe()")
> >
> > build error:
> > ------------
> > aarch64-linux-gnu-ld: drivers/usb/host/xhci-plat.o: in function
> > `xhci_plat_remove':
> > drivers/usb/host/xhci-plat.c:427: undefined reference to
> > `onboard_hub_destroy_pdevs'
> > drivers/usb/host/xhci-plat.c:427:(.text+0x82c): relocation truncated
> > to fit: R_AARCH64_CALL26 against undefined symbol
> > `onboard_hub_destroy_pdevs'
> > aarch64-linux-gnu-ld: drivers/usb/host/xhci-plat.o: in function
> > `xhci_plat_probe':
> > drivers/usb/host/xhci-plat.c:379: undefined reference to
> > `onboard_hub_create_pdevs'
> > drivers/usb/host/xhci-plat.c:379:(.text+0x131c): relocation truncated
> > to fit: R_AARCH64_CALL26 against undefined symbol
> > `onboard_hub_create_pdevs'
> > make[1]: *** [Makefile:1252: vmlinux] Error 1
> > make[1]: Target '__all' not remade because of errors.
> > make: *** [Makefile:222: __sub-make] Error 2
> > make: Target '__all' not remade because of errors.
>
> Matthias, this is due to your patch, yet-another config option mis-match
> somewhere. Can you please fix it up?
I can repro this with:
make -j 16 ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- \
KCONFIG_ALLCONFIG=arch/arm64/configs/defconfig allmodconfig kernel modules
This results in:
CONFIG_USB_XHCI_PLATFORM=y
CONFIG_USB_ONBOARD_HUB=m
The following Kconfig dependency was supposed to prevent this scenario:
config USB_XHCI_PLATFORM
depends on USB_ONBOARD_HUB || !USB_ONBOARD_HUB
But apparently this isn't the case.
With the above allmodconfig command the following warning is emitted:
WARNING: unmet direct dependencies detected for USB_XHCI_PLATFORM
Depends on [m]: USB_SUPPORT [=y] && USB [=y] && USB_XHCI_HCD [=y] && (USB_ONBOARD_HUB [=m] || !USB_ONBOARD_HUB [=m])
I read through kconfig-language.rst multiple times, but it's still not
clear to me how to specify this dependency properly.
Masahiro/Greg, do you have any pointers?
next prev parent reply other threads:[~2021-06-17 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 13:39 [next] [arm64] allmodconfig build failed - xhci-plat.c:427: undefined reference to `onboard_hub_destroy_pdevs' Naresh Kamboju
2021-06-17 13:42 ` Naresh Kamboju
2021-06-17 13:45 ` Greg Kroah-Hartman
2021-06-17 18:16 ` Matthias Kaehlcke [this message]
2021-06-18 6:40 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMuRcrE8xlWnFSWW@google.com \
--to=mka@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-usb@vger.kernel.or \
--cc=lkft-triage@lists.linaro.org \
--cc=masahiroy@kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.