From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D162C49361 for ; Thu, 17 Jun 2021 20:30:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7EBB1613EC for ; Thu, 17 Jun 2021 20:30:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232515AbhFQUdC (ORCPT ); Thu, 17 Jun 2021 16:33:02 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:52348 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232271AbhFQUc7 (ORCPT ); Thu, 17 Jun 2021 16:32:59 -0400 Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A9B4521B1C; Thu, 17 Jun 2021 20:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1623961850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MrOSZdFOt9wTUVyZxzKZ+9qRk1GhEPDQuhCcMSdan0=; b=Nzml9LQc5a54Z6G6NC24xdoLvkPsFpO/is604opqVvgX7yV9TeF13FFC+5J8sv4fSo2JR8 ZezTUrpJe6WMXC9X7cmUOKL12NEs7iEo5p/kYbX+gYyRfSITZoHufdpn9VkFd7ki/Sg96f MbB0pLsV6iBvUhdOca9xfx47z6t7ueI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1623961850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MrOSZdFOt9wTUVyZxzKZ+9qRk1GhEPDQuhCcMSdan0=; b=AFKiXakYcmVG5XKv+m6WtjG96wImTTAwKdUtoWj6WX9fuBYwl/6wkJQnxqIqUOyKcjnnVV gwQh/Dw8CKd88WDA== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 50E7A118DD; Thu, 17 Jun 2021 20:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1623961850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MrOSZdFOt9wTUVyZxzKZ+9qRk1GhEPDQuhCcMSdan0=; b=Nzml9LQc5a54Z6G6NC24xdoLvkPsFpO/is604opqVvgX7yV9TeF13FFC+5J8sv4fSo2JR8 ZezTUrpJe6WMXC9X7cmUOKL12NEs7iEo5p/kYbX+gYyRfSITZoHufdpn9VkFd7ki/Sg96f MbB0pLsV6iBvUhdOca9xfx47z6t7ueI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1623961850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MrOSZdFOt9wTUVyZxzKZ+9qRk1GhEPDQuhCcMSdan0=; b=AFKiXakYcmVG5XKv+m6WtjG96wImTTAwKdUtoWj6WX9fuBYwl/6wkJQnxqIqUOyKcjnnVV gwQh/Dw8CKd88WDA== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id waNDEfqwy2ASDgAALh3uQQ (envelope-from ); Thu, 17 Jun 2021 20:30:50 +0000 Date: Thu, 17 Jun 2021 22:30:48 +0200 From: Joerg Roedel To: Nick Desaulniers Cc: Joerg Roedel , Will Deacon , David Woodhouse , iommu@lists.linux-foundation.org, LKML , clang-built-linux , Lu Baolu , kernel test robot Subject: Re: [PATCH] iommu/vt-d: Fix W=1 clang warning in intel/perf.c Message-ID: References: <20210617145339.2692-1-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 17, 2021 at 10:16:50AM -0700, Nick Desaulniers wrote: > On Thu, Jun 17, 2021 at 7:54 AM Joerg Roedel wrote: > > > > From: Joerg Roedel > > > > Fix this warning when compiled with clang and W=1: > > > > drivers/iommu/intel/perf.c:16: warning: Function parameter or member 'latency_lock' not described in 'DEFINE_SPINLOCK' > > drivers/iommu/intel/perf.c:16: warning: expecting prototype for perf.c(). Prototype was for DEFINE_SPINLOCK() instead > > I think these warnings are actually produced by kernel-doc? (not clang) Will kernel-doc check automatically when COMPILER=clang is set and W=1? Because I did not explicitly enable any kernel-doc checks. Regards, Joerg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_RED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 819ADC2B9F4 for ; Thu, 17 Jun 2021 20:30:58 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 42D08613E7 for ; Thu, 17 Jun 2021 20:30:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 42D08613E7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 13757842D9; Thu, 17 Jun 2021 20:30:58 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9uwBzw_xyLhu; Thu, 17 Jun 2021 20:30:57 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 262C6842BB; Thu, 17 Jun 2021 20:30:57 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id F32F2C000D; Thu, 17 Jun 2021 20:30:56 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 09A47C000B for ; Thu, 17 Jun 2021 20:30:55 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E05A0842CC for ; Thu, 17 Jun 2021 20:30:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pmSmKVPunJJS for ; Thu, 17 Jun 2021 20:30:53 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8F029840F9 for ; Thu, 17 Jun 2021 20:30:53 +0000 (UTC) Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A9B4521B1C; Thu, 17 Jun 2021 20:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1623961850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MrOSZdFOt9wTUVyZxzKZ+9qRk1GhEPDQuhCcMSdan0=; b=Nzml9LQc5a54Z6G6NC24xdoLvkPsFpO/is604opqVvgX7yV9TeF13FFC+5J8sv4fSo2JR8 ZezTUrpJe6WMXC9X7cmUOKL12NEs7iEo5p/kYbX+gYyRfSITZoHufdpn9VkFd7ki/Sg96f MbB0pLsV6iBvUhdOca9xfx47z6t7ueI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1623961850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MrOSZdFOt9wTUVyZxzKZ+9qRk1GhEPDQuhCcMSdan0=; b=AFKiXakYcmVG5XKv+m6WtjG96wImTTAwKdUtoWj6WX9fuBYwl/6wkJQnxqIqUOyKcjnnVV gwQh/Dw8CKd88WDA== Received: from imap3-int (imap-alt.suse-dmz.suse.de [192.168.254.47]) by imap.suse.de (Postfix) with ESMTP id 50E7A118DD; Thu, 17 Jun 2021 20:30:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1623961850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MrOSZdFOt9wTUVyZxzKZ+9qRk1GhEPDQuhCcMSdan0=; b=Nzml9LQc5a54Z6G6NC24xdoLvkPsFpO/is604opqVvgX7yV9TeF13FFC+5J8sv4fSo2JR8 ZezTUrpJe6WMXC9X7cmUOKL12NEs7iEo5p/kYbX+gYyRfSITZoHufdpn9VkFd7ki/Sg96f MbB0pLsV6iBvUhdOca9xfx47z6t7ueI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1623961850; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7MrOSZdFOt9wTUVyZxzKZ+9qRk1GhEPDQuhCcMSdan0=; b=AFKiXakYcmVG5XKv+m6WtjG96wImTTAwKdUtoWj6WX9fuBYwl/6wkJQnxqIqUOyKcjnnVV gwQh/Dw8CKd88WDA== Received: from director2.suse.de ([192.168.254.72]) by imap3-int with ESMTPSA id waNDEfqwy2ASDgAALh3uQQ (envelope-from ); Thu, 17 Jun 2021 20:30:50 +0000 Date: Thu, 17 Jun 2021 22:30:48 +0200 From: Joerg Roedel To: Nick Desaulniers Subject: Re: [PATCH] iommu/vt-d: Fix W=1 clang warning in intel/perf.c Message-ID: References: <20210617145339.2692-1-joro@8bytes.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: kernel test robot , Will Deacon , LKML , clang-built-linux , iommu@lists.linux-foundation.org, David Woodhouse X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Thu, Jun 17, 2021 at 10:16:50AM -0700, Nick Desaulniers wrote: > On Thu, Jun 17, 2021 at 7:54 AM Joerg Roedel wrote: > > > > From: Joerg Roedel > > > > Fix this warning when compiled with clang and W=1: > > > > drivers/iommu/intel/perf.c:16: warning: Function parameter or member 'latency_lock' not described in 'DEFINE_SPINLOCK' > > drivers/iommu/intel/perf.c:16: warning: expecting prototype for perf.c(). Prototype was for DEFINE_SPINLOCK() instead > > I think these warnings are actually produced by kernel-doc? (not clang) Will kernel-doc check automatically when COMPILER=clang is set and W=1? Because I did not explicitly enable any kernel-doc checks. Regards, Joerg _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu