From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34868C48BE8 for ; Fri, 18 Jun 2021 07:42:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10FF3613AA for ; Fri, 18 Jun 2021 07:42:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233270AbhFRHoT (ORCPT ); Fri, 18 Jun 2021 03:44:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230433AbhFRHoT (ORCPT ); Fri, 18 Jun 2021 03:44:19 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B977C061574 for ; Fri, 18 Jun 2021 00:42:08 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id t7so7310486edd.5 for ; Fri, 18 Jun 2021 00:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=v52H1DGhwEBbToMjprp5OIYmxTHaBZzbygv2ty6zyTA=; b=dDj24zSRZV8EKE1Zp5M2dp1HZFeICLy7YE63TfpDkIVzJZ3FoLPsFddFh34nqv4QP2 PFD9Ui270iQuK0zRwTOO4pOnL7P8YOPTpL3GAjDMCrZQsJvqZAHVhoMjz/TTdRgt3wgG A0PCgJpU8RqU0ZEc0RK2TE6Ehk3W87VKdkB+QlxLecfy5oBkUOr67zlULx0LW7V7VMZ2 RHk4FDYAuvEiO5g7Bn+hBd9COd/bHu1i8c0qYLGm3ZXlo761c0LOSFBaXroaWNm3zXvL M5/5OVmWLndb68QIRJdLdgw67BpWLd7NhXDYappZvvUk+wpD1T5NQh+6Ok5rHTWGUYST qvoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=v52H1DGhwEBbToMjprp5OIYmxTHaBZzbygv2ty6zyTA=; b=Qzzb5Bo/YgGcECPVpT51tSB7OTufBRmYWjoLeLFy9uy3080B/Df90XrD5rwuAnG9nQ k23lEFQdtmQnWTXUlOCdnNgOpWxuj3km3Yvz7ngtDOiiljuIAmcoP0gusU1KajtzjxIT ajsN5qfgKE3v534YbMmFSG2bn6mm/Z8EeSQe8CXTElPbujcaGGZT1CO2d3PFHG+lQVoZ T0K975Gq5AjHhVi5/jE2IufXxqQ6J2wZY1kJVrflHXR+wDCD7+0yA+Cm71RZq+XZWRkz tzWIOZJgJ7rRcANWf7YeK69nNrAnK7WqtooMY8Fc001LzJo8WUKHBCG1yyCe+DXpSTir 8y2w== X-Gm-Message-State: AOAM5310Xv58MksWXYYf4su61TiKqHmNss00NornF/WieDHvXZ7pMiv8 z3g9exKotyGCteJmjx2WnGtu2Q== X-Google-Smtp-Source: ABdhPJwIMcxh29slWUpqVvymbEU7IrUGEPStgx5v5WFVtHmmlxhiXwp4hieNxZEXP8fTg0+HhYxHlw== X-Received: by 2002:a05:6402:b76:: with SMTP id cb22mr3227635edb.112.1624002126744; Fri, 18 Jun 2021 00:42:06 -0700 (PDT) Received: from myrica (adsl-84-226-111-173.adslplus.ch. [84.226.111.173]) by smtp.gmail.com with ESMTPSA id br24sm683484ejb.55.2021.06.18.00.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 00:42:06 -0700 (PDT) Date: Fri, 18 Jun 2021 09:41:46 +0200 From: Jean-Philippe Brucker To: Eric Auger Cc: rjw@rjwysocki.net, lenb@kernel.org, joro@8bytes.org, mst@redhat.com, will@kernel.org, catalin.marinas@arm.com, baolu.lu@linux.intel.com, dwmw2@infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, sebastien.boeuf@intel.com, robin.murphy@arm.com, kevin.tian@intel.com, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, sudeep.holla@arm.com Subject: Re: [PATCH v4 2/6] ACPI: Move IOMMU setup code out of IORT Message-ID: References: <20210610075130.67517-1-jean-philippe@linaro.org> <20210610075130.67517-3-jean-philippe@linaro.org> <2c53c9cf-43e6-11c2-6ee3-530ad1f87aec@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2c53c9cf-43e6-11c2-6ee3-530ad1f87aec@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi Eric, On Wed, Jun 16, 2021 at 11:35:13AM +0200, Eric Auger wrote: > > -const struct iommu_ops *iort_iommu_configure_id(struct device *dev, > > - const u32 *id_in) > > +int iort_iommu_configure_id(struct device *dev, const u32 *id_in) > > { > > struct acpi_iort_node *node; > > - const struct iommu_ops *ops; > > + const struct iommu_ops *ops = NULL; Oops, I need to remove this (and add -Werror to my tests.) > > +static const struct iommu_ops *acpi_iommu_configure_id(struct device *dev, > > + const u32 *id_in) > > +{ > > + int err; > > + const struct iommu_ops *ops; > > + > > + /* > > + * If we already translated the fwspec there is nothing left to do, > > + * return the iommu_ops. > > + */ > > + ops = acpi_iommu_fwspec_ops(dev); > > + if (ops) > > + return ops; > > + > > + err = iort_iommu_configure_id(dev, id_in); > > + > > + /* > > + * If we have reason to believe the IOMMU driver missed the initial > > + * add_device callback for dev, replay it to get things in order. > > + */ > > + if (!err && dev->bus && !device_iommu_mapped(dev)) > > + err = iommu_probe_device(dev); > Previously we had: >     if (!err) { >         ops = iort_fwspec_iommu_ops(dev); >         err = iort_add_device_replay(dev); >     } > > Please can you explain the transform? I see the > > acpi_iommu_fwspec_ops call below but is it not straightforward to me. I figured that iort_add_device_replay() is only used once and is sufficiently simple to be inlined manually (saving 10 lines). Then I replaced the ops assignment with returns, which saves another line and may be slightly clearer? I guess it's mostly a matter of taste, the behavior should be exactly the same. > Also the comment mentions replay. Unsure if it is still OK. The "replay" part is, but "add_device" isn't accurate because it has since been replaced by probe_device. I'll refresh the comment. Thanks, Jean From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2BE4C48BDF for ; Fri, 18 Jun 2021 07:42:12 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 784886120A for ; Fri, 18 Jun 2021 07:42:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 784886120A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 334114022D; Fri, 18 Jun 2021 07:42:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BlFFWZHhjM8I; Fri, 18 Jun 2021 07:42:11 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id 0E1DC401F2; Fri, 18 Jun 2021 07:42:10 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id E3D1FC000D; Fri, 18 Jun 2021 07:42:10 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 09CE0C000B for ; Fri, 18 Jun 2021 07:42:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D6438605F6 for ; Fri, 18 Jun 2021 07:42:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=linaro.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QYaDbvBKGFa8 for ; Fri, 18 Jun 2021 07:42:08 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by smtp3.osuosl.org (Postfix) with ESMTPS id B26BC605F4 for ; Fri, 18 Jun 2021 07:42:08 +0000 (UTC) Received: by mail-ed1-x52c.google.com with SMTP id w21so7334637edv.3 for ; Fri, 18 Jun 2021 00:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=v52H1DGhwEBbToMjprp5OIYmxTHaBZzbygv2ty6zyTA=; b=dDj24zSRZV8EKE1Zp5M2dp1HZFeICLy7YE63TfpDkIVzJZ3FoLPsFddFh34nqv4QP2 PFD9Ui270iQuK0zRwTOO4pOnL7P8YOPTpL3GAjDMCrZQsJvqZAHVhoMjz/TTdRgt3wgG A0PCgJpU8RqU0ZEc0RK2TE6Ehk3W87VKdkB+QlxLecfy5oBkUOr67zlULx0LW7V7VMZ2 RHk4FDYAuvEiO5g7Bn+hBd9COd/bHu1i8c0qYLGm3ZXlo761c0LOSFBaXroaWNm3zXvL M5/5OVmWLndb68QIRJdLdgw67BpWLd7NhXDYappZvvUk+wpD1T5NQh+6Ok5rHTWGUYST qvoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=v52H1DGhwEBbToMjprp5OIYmxTHaBZzbygv2ty6zyTA=; b=tI23ug610DuT6sMOMWsoo1EnglD13PEJ2MC82e0rY6RSQXKWfV6PAH3m4Eiby3n+i4 VjmJDdJdsVPS9hBSRZKr+a212xtqfFMrBln2UmkjzhF7TR9KbCt4GnvV3OmGp6YjDZMG sg4Pj7scu3ynTS3GBNx1oJa+2KNgVEGDA183B5DQmqg1TIz5pmqnb7JXd08q+Pha9A4T HwdeepsDkPcxiJS3L9sTj6mRllgDgKYe3tRSpHmOmdkV5v6NLwmHEgAg5NTMiLOg9/7Z danX5g5JLvdWTlfRyGNQk7LBuzmscKUIJ8556pZE53uaX7s1ZsCAC8MtbqiRiIUnaznN S+bw== X-Gm-Message-State: AOAM533pW8kcFXG36IcrnMKpWk6KPDHXI3KCeCHHImGFfeHVZPucW9rT fhtFeSH3TE7D2dk6SlHpiAhrUw== X-Google-Smtp-Source: ABdhPJwIMcxh29slWUpqVvymbEU7IrUGEPStgx5v5WFVtHmmlxhiXwp4hieNxZEXP8fTg0+HhYxHlw== X-Received: by 2002:a05:6402:b76:: with SMTP id cb22mr3227635edb.112.1624002126744; Fri, 18 Jun 2021 00:42:06 -0700 (PDT) Received: from myrica (adsl-84-226-111-173.adslplus.ch. [84.226.111.173]) by smtp.gmail.com with ESMTPSA id br24sm683484ejb.55.2021.06.18.00.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 00:42:06 -0700 (PDT) Date: Fri, 18 Jun 2021 09:41:46 +0200 From: Jean-Philippe Brucker To: Eric Auger Subject: Re: [PATCH v4 2/6] ACPI: Move IOMMU setup code out of IORT Message-ID: References: <20210610075130.67517-1-jean-philippe@linaro.org> <20210610075130.67517-3-jean-philippe@linaro.org> <2c53c9cf-43e6-11c2-6ee3-530ad1f87aec@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2c53c9cf-43e6-11c2-6ee3-530ad1f87aec@redhat.com> Cc: kevin.tian@intel.com, mst@redhat.com, catalin.marinas@arm.com, sudeep.holla@arm.com, rjw@rjwysocki.net, robin.murphy@arm.com, virtualization@lists.linux-foundation.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, sebastien.boeuf@intel.com, guohanjun@huawei.com, will@kernel.org, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org, lenb@kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" SGkgRXJpYywKCk9uIFdlZCwgSnVuIDE2LCAyMDIxIGF0IDExOjM1OjEzQU0gKzAyMDAsIEVyaWMg QXVnZXIgd3JvdGU6Cj4gPiAtY29uc3Qgc3RydWN0IGlvbW11X29wcyAqaW9ydF9pb21tdV9jb25m aWd1cmVfaWQoc3RydWN0IGRldmljZSAqZGV2LAo+ID4gLQkJCQkJCWNvbnN0IHUzMiAqaWRfaW4p Cj4gPiAraW50IGlvcnRfaW9tbXVfY29uZmlndXJlX2lkKHN0cnVjdCBkZXZpY2UgKmRldiwgY29u c3QgdTMyICppZF9pbikKPiA+ICB7Cj4gPiAgCXN0cnVjdCBhY3BpX2lvcnRfbm9kZSAqbm9kZTsK PiA+IC0JY29uc3Qgc3RydWN0IGlvbW11X29wcyAqb3BzOwo+ID4gKwljb25zdCBzdHJ1Y3QgaW9t bXVfb3BzICpvcHMgPSBOVUxMOwoKT29wcywgSSBuZWVkIHRvIHJlbW92ZSB0aGlzIChhbmQgYWRk IC1XZXJyb3IgdG8gbXkgdGVzdHMuKQoKCj4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCBpb21tdV9v cHMgKmFjcGlfaW9tbXVfY29uZmlndXJlX2lkKHN0cnVjdCBkZXZpY2UgKmRldiwKPiA+ICsJCQkJ CQkgICAgICAgY29uc3QgdTMyICppZF9pbikKPiA+ICt7Cj4gPiArCWludCBlcnI7Cj4gPiArCWNv bnN0IHN0cnVjdCBpb21tdV9vcHMgKm9wczsKPiA+ICsKPiA+ICsJLyoKPiA+ICsJICogSWYgd2Ug YWxyZWFkeSB0cmFuc2xhdGVkIHRoZSBmd3NwZWMgdGhlcmUgaXMgbm90aGluZyBsZWZ0IHRvIGRv LAo+ID4gKwkgKiByZXR1cm4gdGhlIGlvbW11X29wcy4KPiA+ICsJICovCj4gPiArCW9wcyA9IGFj cGlfaW9tbXVfZndzcGVjX29wcyhkZXYpOwo+ID4gKwlpZiAob3BzKQo+ID4gKwkJcmV0dXJuIG9w czsKPiA+ICsKPiA+ICsJZXJyID0gaW9ydF9pb21tdV9jb25maWd1cmVfaWQoZGV2LCBpZF9pbik7 Cj4gPiArCj4gPiArCS8qCj4gPiArCSAqIElmIHdlIGhhdmUgcmVhc29uIHRvIGJlbGlldmUgdGhl IElPTU1VIGRyaXZlciBtaXNzZWQgdGhlIGluaXRpYWwKPiA+ICsJICogYWRkX2RldmljZSBjYWxs YmFjayBmb3IgZGV2LCByZXBsYXkgaXQgdG8gZ2V0IHRoaW5ncyBpbiBvcmRlci4KPiA+ICsJICov Cj4gPiArCWlmICghZXJyICYmIGRldi0+YnVzICYmICFkZXZpY2VfaW9tbXVfbWFwcGVkKGRldikp Cj4gPiArCQllcnIgPSBpb21tdV9wcm9iZV9kZXZpY2UoZGV2KTsKPiBQcmV2aW91c2x5IHdlIGhh ZDoKPiDCoMKgwqAgaWYgKCFlcnIpIHsKPiDCoMKgwqAgwqDCoMKgIG9wcyA9IGlvcnRfZndzcGVj X2lvbW11X29wcyhkZXYpOwo+IMKgwqDCoCDCoMKgwqAgZXJyID0gaW9ydF9hZGRfZGV2aWNlX3Jl cGxheShkZXYpOwo+IMKgwqDCoCB9Cj4gCj4gUGxlYXNlIGNhbiB5b3UgZXhwbGFpbiB0aGUgdHJh bnNmb3JtPyBJIHNlZSB0aGUKPiAKPiBhY3BpX2lvbW11X2Z3c3BlY19vcHMgY2FsbCBiZWxvdyBi dXQgaXMgaXQgbm90IHN0cmFpZ2h0Zm9yd2FyZCB0byBtZS4KCkkgZmlndXJlZCB0aGF0IGlvcnRf YWRkX2RldmljZV9yZXBsYXkoKSBpcyBvbmx5IHVzZWQgb25jZSBhbmQgaXMKc3VmZmljaWVudGx5 IHNpbXBsZSB0byBiZSBpbmxpbmVkIG1hbnVhbGx5IChzYXZpbmcgMTAgbGluZXMpLiBUaGVuIEkK cmVwbGFjZWQgdGhlIG9wcyBhc3NpZ25tZW50IHdpdGggcmV0dXJucywgd2hpY2ggc2F2ZXMgYW5v dGhlciBsaW5lIGFuZCBtYXkKYmUgc2xpZ2h0bHkgY2xlYXJlcj8gIEkgZ3Vlc3MgaXQncyBtb3N0 bHkgYSBtYXR0ZXIgb2YgdGFzdGUsIHRoZSBiZWhhdmlvcgpzaG91bGQgYmUgZXhhY3RseSB0aGUg c2FtZS4KCj4gQWxzbyB0aGUgY29tbWVudCBtZW50aW9ucyByZXBsYXkuIFVuc3VyZSBpZiBpdCBp cyBzdGlsbCBPSy4KClRoZSAicmVwbGF5IiBwYXJ0IGlzLCBidXQgImFkZF9kZXZpY2UiIGlzbid0 IGFjY3VyYXRlIGJlY2F1c2UgaXQgaGFzIHNpbmNlCmJlZW4gcmVwbGFjZWQgYnkgcHJvYmVfZGV2 aWNlLiBJJ2xsIHJlZnJlc2ggdGhlIGNvbW1lbnQuCgpUaGFua3MsCkplYW4KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0Cmlv bW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0 aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F397C49361 for ; Fri, 18 Jun 2021 07:42:13 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D5A2613AA for ; Fri, 18 Jun 2021 07:42:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D5A2613AA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=virtualization-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id F2610401FA; Fri, 18 Jun 2021 07:42:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WRw9QD-cKFMK; Fri, 18 Jun 2021 07:42:12 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 83F074021F; Fri, 18 Jun 2021 07:42:11 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1C7B0C000B; Fri, 18 Jun 2021 07:42:11 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0F625C000D for ; Fri, 18 Jun 2021 07:42:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id E8B3C40462 for ; Fri, 18 Jun 2021 07:42:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=linaro.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iq_d54sks2uC for ; Fri, 18 Jun 2021 07:42:09 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by smtp4.osuosl.org (Postfix) with ESMTPS id CA26140510 for ; Fri, 18 Jun 2021 07:42:08 +0000 (UTC) Received: by mail-ed1-x529.google.com with SMTP id u24so7265397edy.11 for ; Fri, 18 Jun 2021 00:42:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=v52H1DGhwEBbToMjprp5OIYmxTHaBZzbygv2ty6zyTA=; b=dDj24zSRZV8EKE1Zp5M2dp1HZFeICLy7YE63TfpDkIVzJZ3FoLPsFddFh34nqv4QP2 PFD9Ui270iQuK0zRwTOO4pOnL7P8YOPTpL3GAjDMCrZQsJvqZAHVhoMjz/TTdRgt3wgG A0PCgJpU8RqU0ZEc0RK2TE6Ehk3W87VKdkB+QlxLecfy5oBkUOr67zlULx0LW7V7VMZ2 RHk4FDYAuvEiO5g7Bn+hBd9COd/bHu1i8c0qYLGm3ZXlo761c0LOSFBaXroaWNm3zXvL M5/5OVmWLndb68QIRJdLdgw67BpWLd7NhXDYappZvvUk+wpD1T5NQh+6Ok5rHTWGUYST qvoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=v52H1DGhwEBbToMjprp5OIYmxTHaBZzbygv2ty6zyTA=; b=sdZVG8V6B5Bj98whdMHHfYjAf79h+ZuEhjwesxMiQPNRrB6Gpvw6oms1eZOlq6tL5N eJggfUKeNGgY6E3KTnnmNAERQpPsXemuSuKvwCEYPHD82NpOhtJGt6OZ39cQlIsh3oIj cx5E7BzgUC8JwAz2DCa0N9UBW2WsRRAHq4s1TC5rLyx6ZSFt369hqqoaC9WnwRADHnYW oJSxAObV3bRsNK5lktrVfWVUElAa4aEQMSOYZeE4/3GjlFBeKLeM3K3QOcgIGSuhEonh rnzjRFm+1aEPPGcpu/8gbPRmReqfb2YjkX6lkNSyvGJgA/yPRQHLd5DXQrzOGILowdh9 nPWg== X-Gm-Message-State: AOAM532dLZwSiNO4DajfMWwVakbsQrQuiIFPk70z5KIrPdPWwo5A66MQ VoMfAM2rglvYl1TwIIiTdm/35A== X-Google-Smtp-Source: ABdhPJwIMcxh29slWUpqVvymbEU7IrUGEPStgx5v5WFVtHmmlxhiXwp4hieNxZEXP8fTg0+HhYxHlw== X-Received: by 2002:a05:6402:b76:: with SMTP id cb22mr3227635edb.112.1624002126744; Fri, 18 Jun 2021 00:42:06 -0700 (PDT) Received: from myrica (adsl-84-226-111-173.adslplus.ch. [84.226.111.173]) by smtp.gmail.com with ESMTPSA id br24sm683484ejb.55.2021.06.18.00.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 00:42:06 -0700 (PDT) Date: Fri, 18 Jun 2021 09:41:46 +0200 From: Jean-Philippe Brucker To: Eric Auger Subject: Re: [PATCH v4 2/6] ACPI: Move IOMMU setup code out of IORT Message-ID: References: <20210610075130.67517-1-jean-philippe@linaro.org> <20210610075130.67517-3-jean-philippe@linaro.org> <2c53c9cf-43e6-11c2-6ee3-530ad1f87aec@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2c53c9cf-43e6-11c2-6ee3-530ad1f87aec@redhat.com> Cc: lorenzo.pieralisi@arm.com, mst@redhat.com, catalin.marinas@arm.com, joro@8bytes.org, sudeep.holla@arm.com, rjw@rjwysocki.net, robin.murphy@arm.com, virtualization@lists.linux-foundation.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, sebastien.boeuf@intel.com, guohanjun@huawei.com, baolu.lu@linux.intel.com, will@kernel.org, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org, lenb@kernel.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" SGkgRXJpYywKCk9uIFdlZCwgSnVuIDE2LCAyMDIxIGF0IDExOjM1OjEzQU0gKzAyMDAsIEVyaWMg QXVnZXIgd3JvdGU6Cj4gPiAtY29uc3Qgc3RydWN0IGlvbW11X29wcyAqaW9ydF9pb21tdV9jb25m aWd1cmVfaWQoc3RydWN0IGRldmljZSAqZGV2LAo+ID4gLQkJCQkJCWNvbnN0IHUzMiAqaWRfaW4p Cj4gPiAraW50IGlvcnRfaW9tbXVfY29uZmlndXJlX2lkKHN0cnVjdCBkZXZpY2UgKmRldiwgY29u c3QgdTMyICppZF9pbikKPiA+ICB7Cj4gPiAgCXN0cnVjdCBhY3BpX2lvcnRfbm9kZSAqbm9kZTsK PiA+IC0JY29uc3Qgc3RydWN0IGlvbW11X29wcyAqb3BzOwo+ID4gKwljb25zdCBzdHJ1Y3QgaW9t bXVfb3BzICpvcHMgPSBOVUxMOwoKT29wcywgSSBuZWVkIHRvIHJlbW92ZSB0aGlzIChhbmQgYWRk IC1XZXJyb3IgdG8gbXkgdGVzdHMuKQoKCj4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCBpb21tdV9v cHMgKmFjcGlfaW9tbXVfY29uZmlndXJlX2lkKHN0cnVjdCBkZXZpY2UgKmRldiwKPiA+ICsJCQkJ CQkgICAgICAgY29uc3QgdTMyICppZF9pbikKPiA+ICt7Cj4gPiArCWludCBlcnI7Cj4gPiArCWNv bnN0IHN0cnVjdCBpb21tdV9vcHMgKm9wczsKPiA+ICsKPiA+ICsJLyoKPiA+ICsJICogSWYgd2Ug YWxyZWFkeSB0cmFuc2xhdGVkIHRoZSBmd3NwZWMgdGhlcmUgaXMgbm90aGluZyBsZWZ0IHRvIGRv LAo+ID4gKwkgKiByZXR1cm4gdGhlIGlvbW11X29wcy4KPiA+ICsJICovCj4gPiArCW9wcyA9IGFj cGlfaW9tbXVfZndzcGVjX29wcyhkZXYpOwo+ID4gKwlpZiAob3BzKQo+ID4gKwkJcmV0dXJuIG9w czsKPiA+ICsKPiA+ICsJZXJyID0gaW9ydF9pb21tdV9jb25maWd1cmVfaWQoZGV2LCBpZF9pbik7 Cj4gPiArCj4gPiArCS8qCj4gPiArCSAqIElmIHdlIGhhdmUgcmVhc29uIHRvIGJlbGlldmUgdGhl IElPTU1VIGRyaXZlciBtaXNzZWQgdGhlIGluaXRpYWwKPiA+ICsJICogYWRkX2RldmljZSBjYWxs YmFjayBmb3IgZGV2LCByZXBsYXkgaXQgdG8gZ2V0IHRoaW5ncyBpbiBvcmRlci4KPiA+ICsJICov Cj4gPiArCWlmICghZXJyICYmIGRldi0+YnVzICYmICFkZXZpY2VfaW9tbXVfbWFwcGVkKGRldikp Cj4gPiArCQllcnIgPSBpb21tdV9wcm9iZV9kZXZpY2UoZGV2KTsKPiBQcmV2aW91c2x5IHdlIGhh ZDoKPiDCoMKgwqAgaWYgKCFlcnIpIHsKPiDCoMKgwqAgwqDCoMKgIG9wcyA9IGlvcnRfZndzcGVj X2lvbW11X29wcyhkZXYpOwo+IMKgwqDCoCDCoMKgwqAgZXJyID0gaW9ydF9hZGRfZGV2aWNlX3Jl cGxheShkZXYpOwo+IMKgwqDCoCB9Cj4gCj4gUGxlYXNlIGNhbiB5b3UgZXhwbGFpbiB0aGUgdHJh bnNmb3JtPyBJIHNlZSB0aGUKPiAKPiBhY3BpX2lvbW11X2Z3c3BlY19vcHMgY2FsbCBiZWxvdyBi dXQgaXMgaXQgbm90IHN0cmFpZ2h0Zm9yd2FyZCB0byBtZS4KCkkgZmlndXJlZCB0aGF0IGlvcnRf YWRkX2RldmljZV9yZXBsYXkoKSBpcyBvbmx5IHVzZWQgb25jZSBhbmQgaXMKc3VmZmljaWVudGx5 IHNpbXBsZSB0byBiZSBpbmxpbmVkIG1hbnVhbGx5IChzYXZpbmcgMTAgbGluZXMpLiBUaGVuIEkK cmVwbGFjZWQgdGhlIG9wcyBhc3NpZ25tZW50IHdpdGggcmV0dXJucywgd2hpY2ggc2F2ZXMgYW5v dGhlciBsaW5lIGFuZCBtYXkKYmUgc2xpZ2h0bHkgY2xlYXJlcj8gIEkgZ3Vlc3MgaXQncyBtb3N0 bHkgYSBtYXR0ZXIgb2YgdGFzdGUsIHRoZSBiZWhhdmlvcgpzaG91bGQgYmUgZXhhY3RseSB0aGUg c2FtZS4KCj4gQWxzbyB0aGUgY29tbWVudCBtZW50aW9ucyByZXBsYXkuIFVuc3VyZSBpZiBpdCBp cyBzdGlsbCBPSy4KClRoZSAicmVwbGF5IiBwYXJ0IGlzLCBidXQgImFkZF9kZXZpY2UiIGlzbid0 IGFjY3VyYXRlIGJlY2F1c2UgaXQgaGFzIHNpbmNlCmJlZW4gcmVwbGFjZWQgYnkgcHJvYmVfZGV2 aWNlLiBJJ2xsIHJlZnJlc2ggdGhlIGNvbW1lbnQuCgpUaGFua3MsCkplYW4KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KVmlydHVhbGl6YXRpb24gbWFpbGlu ZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8v bGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBC45C49361 for ; Fri, 18 Jun 2021 07:43:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F7A561209 for ; Fri, 18 Jun 2021 07:43:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8F7A561209 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/lEjm4uoqGdrCLez/IaecfxBOzbux1Vr5oxKr3fM5wk=; b=H4qXZ2MTE4JAtG PBcbz3fCGO4jBh1BZ5tiROVseUCvaHWnKJW9lhuoQs5xpIXcJymVjA00R3DGNObZACmg7YeDErdRV gcUdagU8N7nrTTYK2cI/fZ4foCFkDgxcO4cJmsVwAznT0FwxIuqMH1AsBuqmn2sZOLLPCja0jpmNI QMPacdveE6sY34v4MY1CEXj1DgGdkE7TbPVJLpEPu28nEp53lIw0ma5wHameNB2eGhttSdWWTA9M4 H1tqBBGTk7Ffj4nf6XftMe12r+OjD6+5b6mwJr+mu2RPzdI3WFPHBkPZJV7XA7oHrTyOV46LTgsDC /xeivP9jGypMjUu45J9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lu98m-00D7Oe-U3; Fri, 18 Jun 2021 07:42:13 +0000 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lu98j-00D7No-Au for linux-arm-kernel@lists.infradead.org; Fri, 18 Jun 2021 07:42:10 +0000 Received: by mail-ed1-x531.google.com with SMTP id i13so7299321edb.9 for ; Fri, 18 Jun 2021 00:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=v52H1DGhwEBbToMjprp5OIYmxTHaBZzbygv2ty6zyTA=; b=dDj24zSRZV8EKE1Zp5M2dp1HZFeICLy7YE63TfpDkIVzJZ3FoLPsFddFh34nqv4QP2 PFD9Ui270iQuK0zRwTOO4pOnL7P8YOPTpL3GAjDMCrZQsJvqZAHVhoMjz/TTdRgt3wgG A0PCgJpU8RqU0ZEc0RK2TE6Ehk3W87VKdkB+QlxLecfy5oBkUOr67zlULx0LW7V7VMZ2 RHk4FDYAuvEiO5g7Bn+hBd9COd/bHu1i8c0qYLGm3ZXlo761c0LOSFBaXroaWNm3zXvL M5/5OVmWLndb68QIRJdLdgw67BpWLd7NhXDYappZvvUk+wpD1T5NQh+6Ok5rHTWGUYST qvoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=v52H1DGhwEBbToMjprp5OIYmxTHaBZzbygv2ty6zyTA=; b=dZI9oLCjju3rU9pwAIqDq19cBNFQKF3a/jac7nc9fpKhIRRTEkOFvXi8luNRn8dtzq weSdKGXYHn79o/YVv9oj58LXAw5j+DykEyna2HIv/xfdqLHM/+HZGWk/faXdRxe8TiN3 jyu7mNfcIi9HowoGsUYhKvPqoOw9UpVuRNh+SJv1C5ZfCNUrmNExomZ0Trnkr6bXcNPf g5Z9G8FdyqQm48ULe1KD0NctpbMbXHW/kdKuc2Qsdo2AzLk3WxoPIZoDMmQIxV6mS5EN abRhXVzUDuR7kMIkJhdPHafm1QlhhhvGeFWKI8VUUex6VCrLdQlkFS80ssN0UcSqdrp1 a18w== X-Gm-Message-State: AOAM531nNidmXhcHMDaU34YmoOJhw3NH2sXZFocATlry58IG2rLEslUi ZyZfTNW9mkuHeQgEA6Np2qvkZA== X-Google-Smtp-Source: ABdhPJwIMcxh29slWUpqVvymbEU7IrUGEPStgx5v5WFVtHmmlxhiXwp4hieNxZEXP8fTg0+HhYxHlw== X-Received: by 2002:a05:6402:b76:: with SMTP id cb22mr3227635edb.112.1624002126744; Fri, 18 Jun 2021 00:42:06 -0700 (PDT) Received: from myrica (adsl-84-226-111-173.adslplus.ch. [84.226.111.173]) by smtp.gmail.com with ESMTPSA id br24sm683484ejb.55.2021.06.18.00.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 00:42:06 -0700 (PDT) Date: Fri, 18 Jun 2021 09:41:46 +0200 From: Jean-Philippe Brucker To: Eric Auger Cc: rjw@rjwysocki.net, lenb@kernel.org, joro@8bytes.org, mst@redhat.com, will@kernel.org, catalin.marinas@arm.com, baolu.lu@linux.intel.com, dwmw2@infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux-foundation.org, virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, sebastien.boeuf@intel.com, robin.murphy@arm.com, kevin.tian@intel.com, lorenzo.pieralisi@arm.com, guohanjun@huawei.com, sudeep.holla@arm.com Subject: Re: [PATCH v4 2/6] ACPI: Move IOMMU setup code out of IORT Message-ID: References: <20210610075130.67517-1-jean-philippe@linaro.org> <20210610075130.67517-3-jean-philippe@linaro.org> <2c53c9cf-43e6-11c2-6ee3-530ad1f87aec@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2c53c9cf-43e6-11c2-6ee3-530ad1f87aec@redhat.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210618_004209_552604_BB1D9DDA X-CRM114-Status: GOOD ( 22.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgRXJpYywKCk9uIFdlZCwgSnVuIDE2LCAyMDIxIGF0IDExOjM1OjEzQU0gKzAyMDAsIEVyaWMg QXVnZXIgd3JvdGU6Cj4gPiAtY29uc3Qgc3RydWN0IGlvbW11X29wcyAqaW9ydF9pb21tdV9jb25m aWd1cmVfaWQoc3RydWN0IGRldmljZSAqZGV2LAo+ID4gLQkJCQkJCWNvbnN0IHUzMiAqaWRfaW4p Cj4gPiAraW50IGlvcnRfaW9tbXVfY29uZmlndXJlX2lkKHN0cnVjdCBkZXZpY2UgKmRldiwgY29u c3QgdTMyICppZF9pbikKPiA+ICB7Cj4gPiAgCXN0cnVjdCBhY3BpX2lvcnRfbm9kZSAqbm9kZTsK PiA+IC0JY29uc3Qgc3RydWN0IGlvbW11X29wcyAqb3BzOwo+ID4gKwljb25zdCBzdHJ1Y3QgaW9t bXVfb3BzICpvcHMgPSBOVUxMOwoKT29wcywgSSBuZWVkIHRvIHJlbW92ZSB0aGlzIChhbmQgYWRk IC1XZXJyb3IgdG8gbXkgdGVzdHMuKQoKCj4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCBpb21tdV9v cHMgKmFjcGlfaW9tbXVfY29uZmlndXJlX2lkKHN0cnVjdCBkZXZpY2UgKmRldiwKPiA+ICsJCQkJ CQkgICAgICAgY29uc3QgdTMyICppZF9pbikKPiA+ICt7Cj4gPiArCWludCBlcnI7Cj4gPiArCWNv bnN0IHN0cnVjdCBpb21tdV9vcHMgKm9wczsKPiA+ICsKPiA+ICsJLyoKPiA+ICsJICogSWYgd2Ug YWxyZWFkeSB0cmFuc2xhdGVkIHRoZSBmd3NwZWMgdGhlcmUgaXMgbm90aGluZyBsZWZ0IHRvIGRv LAo+ID4gKwkgKiByZXR1cm4gdGhlIGlvbW11X29wcy4KPiA+ICsJICovCj4gPiArCW9wcyA9IGFj cGlfaW9tbXVfZndzcGVjX29wcyhkZXYpOwo+ID4gKwlpZiAob3BzKQo+ID4gKwkJcmV0dXJuIG9w czsKPiA+ICsKPiA+ICsJZXJyID0gaW9ydF9pb21tdV9jb25maWd1cmVfaWQoZGV2LCBpZF9pbik7 Cj4gPiArCj4gPiArCS8qCj4gPiArCSAqIElmIHdlIGhhdmUgcmVhc29uIHRvIGJlbGlldmUgdGhl IElPTU1VIGRyaXZlciBtaXNzZWQgdGhlIGluaXRpYWwKPiA+ICsJICogYWRkX2RldmljZSBjYWxs YmFjayBmb3IgZGV2LCByZXBsYXkgaXQgdG8gZ2V0IHRoaW5ncyBpbiBvcmRlci4KPiA+ICsJICov Cj4gPiArCWlmICghZXJyICYmIGRldi0+YnVzICYmICFkZXZpY2VfaW9tbXVfbWFwcGVkKGRldikp Cj4gPiArCQllcnIgPSBpb21tdV9wcm9iZV9kZXZpY2UoZGV2KTsKPiBQcmV2aW91c2x5IHdlIGhh ZDoKPiDCoMKgwqAgaWYgKCFlcnIpIHsKPiDCoMKgwqAgwqDCoMKgIG9wcyA9IGlvcnRfZndzcGVj X2lvbW11X29wcyhkZXYpOwo+IMKgwqDCoCDCoMKgwqAgZXJyID0gaW9ydF9hZGRfZGV2aWNlX3Jl cGxheShkZXYpOwo+IMKgwqDCoCB9Cj4gCj4gUGxlYXNlIGNhbiB5b3UgZXhwbGFpbiB0aGUgdHJh bnNmb3JtPyBJIHNlZSB0aGUKPiAKPiBhY3BpX2lvbW11X2Z3c3BlY19vcHMgY2FsbCBiZWxvdyBi dXQgaXMgaXQgbm90IHN0cmFpZ2h0Zm9yd2FyZCB0byBtZS4KCkkgZmlndXJlZCB0aGF0IGlvcnRf YWRkX2RldmljZV9yZXBsYXkoKSBpcyBvbmx5IHVzZWQgb25jZSBhbmQgaXMKc3VmZmljaWVudGx5 IHNpbXBsZSB0byBiZSBpbmxpbmVkIG1hbnVhbGx5IChzYXZpbmcgMTAgbGluZXMpLiBUaGVuIEkK cmVwbGFjZWQgdGhlIG9wcyBhc3NpZ25tZW50IHdpdGggcmV0dXJucywgd2hpY2ggc2F2ZXMgYW5v dGhlciBsaW5lIGFuZCBtYXkKYmUgc2xpZ2h0bHkgY2xlYXJlcj8gIEkgZ3Vlc3MgaXQncyBtb3N0 bHkgYSBtYXR0ZXIgb2YgdGFzdGUsIHRoZSBiZWhhdmlvcgpzaG91bGQgYmUgZXhhY3RseSB0aGUg c2FtZS4KCj4gQWxzbyB0aGUgY29tbWVudCBtZW50aW9ucyByZXBsYXkuIFVuc3VyZSBpZiBpdCBp cyBzdGlsbCBPSy4KClRoZSAicmVwbGF5IiBwYXJ0IGlzLCBidXQgImFkZF9kZXZpY2UiIGlzbid0 IGFjY3VyYXRlIGJlY2F1c2UgaXQgaGFzIHNpbmNlCmJlZW4gcmVwbGFjZWQgYnkgcHJvYmVfZGV2 aWNlLiBJJ2xsIHJlZnJlc2ggdGhlIGNvbW1lbnQuCgpUaGFua3MsCkplYW4KCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK