All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Ulrich Hecht <uli@fpond.eu>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: Ulrich Hecht <uli+renesas@fpond.eu>,
	linux-renesas-soc@vger.kernel.org, linux-mmc@vger.kernel.org,
	ulf.hansson@linaro.org
Subject: Re: [PATCH] mmc: renesas_sdhi: increase suspend/resume latency limit
Date: Fri, 18 Jun 2021 10:17:18 +0200	[thread overview]
Message-ID: <YMxWjsAQNt9DG0Ef@ninjato> (raw)
In-Reply-To: <461686971.488794.1622648414815@webmail.strato.com>

[-- Attachment #1: Type: text/plain, Size: 851 bytes --]

Hi Uli,

> _mmc_detect_card_removed() calls mmc_sd_alive(), which tries to send a
> command to the SD card to see if it's still there, which in turn
> triggers the retune. IOW, this is expected to fail, and the error
> message is misleading.

This makes perfect sense to me. I disabled tuning in
_mmc_detect_card_removed() and the message is gone, of course. I'll send
a patch right away. With that sorted out, the patch works for me nicely
and we have *finally* RPM kicking in for SDHI. Looks good to me.

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

However, I'd appreciate if Shimoda-san could also test this against his
test-suite to make sure there are no other issues unearthed now that RPM
is finally suspending the device. I will also add do additional
suspend/resume tests before I say Tested-by.

Good work so far, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2021-06-18  8:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 15:53 [PATCH] mmc: renesas_sdhi: increase suspend/resume latency limit Ulrich Hecht
2021-05-19 14:25 ` Wolfram Sang
2021-06-02 15:40   ` Ulrich Hecht
2021-06-18  8:17     ` Wolfram Sang [this message]
2021-06-18 10:40       ` Wolfram Sang
2021-06-30  4:44 ` Wolfram Sang
2021-07-30 15:28 ` Wolfram Sang
2021-08-02  5:34   ` Yoshihiro Shimoda
2021-08-02 11:18     ` Ulrich Hecht
2021-08-03 11:16       ` Yoshihiro Shimoda
2021-08-04  5:29         ` Yoshihiro Shimoda
2021-08-04 16:17           ` Ulrich Hecht
2021-08-02 12:53     ` Wolfram Sang
2021-08-03 11:16       ` Yoshihiro Shimoda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YMxWjsAQNt9DG0Ef@ninjato \
    --to=wsa@kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=uli+renesas@fpond.eu \
    --cc=uli@fpond.eu \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.